Files
linux/arch/mips/include/asm
James Hogan b45bacd2d0 MIPS: KVM: Fix timer IRQ race when writing CP0_Compare
Writing CP0_Compare clears the timer interrupt pending bit
(CP0_Cause.TI), but this wasn't being done atomically. If a timer
interrupt raced with the write of the guest CP0_Compare, the timer
interrupt could end up being pending even though the new CP0_Compare is
nowhere near CP0_Count.

We were already updating the hrtimer expiry with
kvm_mips_update_hrtimer(), which used both kvm_mips_freeze_hrtimer() and
kvm_mips_resume_hrtimer(). Close the race window by expanding out
kvm_mips_update_hrtimer(), and clearing CP0_Cause.TI and setting
CP0_Compare between the freeze and resume. Since the pending timer
interrupt should not be cleared when CP0_Compare is written via the KVM
user API, an ack argument is added to distinguish the source of the
write.

Fixes: e30492bbe9 ("MIPS: KVM: Rewrite count/compare timer emulation")
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Cc: kvm@vger.kernel.org
Cc: <stable@vger.kernel.org> # 3.16.x-
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2016-05-10 15:56:50 +02:00
..
2013-02-01 10:00:22 +01:00
2013-02-01 10:00:22 +01:00
2013-02-01 10:00:22 +01:00
2015-06-21 21:52:44 +02:00
2014-08-26 02:18:58 +02:00
2016-04-03 12:32:09 +02:00
2016-04-03 12:32:09 +02:00
2013-02-01 10:00:22 +01:00
2016-04-03 12:32:09 +02:00
2013-02-01 10:00:22 +01:00
2013-02-01 10:00:22 +01:00
2015-11-11 08:36:36 +01:00
2014-01-22 20:19:02 +01:00
2016-01-12 20:46:56 +02:00
2009-12-05 09:10:12 -08:00
2015-05-13 10:55:42 +02:00
2013-02-01 10:00:22 +01:00
2015-11-12 11:35:47 +01:00
2015-08-26 15:23:03 +02:00
2013-02-01 10:00:22 +01:00
2009-07-03 15:45:29 +01:00
2013-01-24 13:20:09 +01:00
2015-05-28 15:31:53 +02:00
2014-08-26 02:18:56 +02:00
2012-03-28 18:30:02 +01:00
2014-05-24 00:07:01 +02:00
2013-02-01 10:00:22 +01:00
2016-02-01 23:36:38 +01:00
2013-02-01 10:00:22 +01:00
2011-07-26 16:49:47 -07:00
2015-06-21 21:54:29 +02:00
2016-01-24 01:44:21 +01:00
2013-02-01 10:00:22 +01:00
2013-02-01 10:00:22 +01:00
2013-02-01 10:00:22 +01:00
2015-09-03 12:08:05 +02:00
2012-12-13 16:46:47 +01:00
2013-02-01 10:00:22 +01:00
2013-02-01 10:00:22 +01:00
2013-02-01 10:00:22 +01:00
2013-02-01 10:00:22 +01:00
2014-05-24 00:07:01 +02:00
2016-04-03 12:32:09 +02:00
2016-01-24 03:20:46 +01:00
2013-02-01 10:00:22 +01:00
2016-01-23 00:28:57 +01:00
2015-09-03 12:08:05 +02:00
2014-08-02 00:06:38 +02:00
2013-02-01 10:00:22 +01:00
2014-01-22 20:19:02 +01:00
2016-04-03 12:32:09 +02:00
2013-02-01 10:00:22 +01:00
2013-02-01 10:00:22 +01:00
2013-02-01 10:00:22 +01:00
2013-02-01 10:00:22 +01:00
2015-09-03 12:08:05 +02:00
2011-12-07 22:01:45 +00:00
2013-02-01 10:00:22 +01:00
2013-02-01 10:00:22 +01:00
2016-04-03 12:32:09 +02:00
2015-09-03 12:08:05 +02:00
2013-09-18 17:13:58 +02:00
2013-02-01 10:00:22 +01:00