Eric Dumazet 45cac67545
net: fix recent csum changes ...
Vladimir reported csum issues after my recent change in skb_postpull_rcsum()
Issue here is the following:
initial skb->csum is the csum of
[part to be pulled][rest of packet]
Old code:
skb->csum = csum_sub(skb->csum, csum_partial(pull, pull_length, 0));
New code:
skb->csum = ~csum_partial(pull, pull_length, ~skb->csum);
This is broken if the csum of [pulled part]
happens to be equal to skb->csum, because end
result of skb->csum is 0 in new code, instead
of being 0xffffffff
David Laight suggested to use
skb->csum = -csum_partial(pull, pull_length, -skb->csum);
I based my patches on existing code present in include/net/seg6.h,
update_csum_diff4() and update_csum_diff16() which might need
a similar fix.
I guess that my tests, mostly pulling 40 bytes of IPv6 header
were not providing enough entropy to hit this bug.
v2: added wsum_negate() to make sparse happy.
Fixes: 29c30026440bd28476f6edumazet@google.com >
Reported-by: Vladimir Oltean <vladimir.oltean@nxp.com >
Suggested-by: David Laight <David.Laight@ACULAB.COM >
Cc: David Lebrun <dlebrun@google.com >
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com >
Link: https://lore.kernel.org/r/20211204045356.3659278-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org >
2021-12-06 16:26:46 -08:00
2021-11-04 21:04:25 +09:00
2021-11-16 15:16:30 +01:00
2021-07-01 13:19:48 -07:00
2021-11-19 11:52:25 +00:00
2021-11-01 09:31:03 +01:00
2021-12-02 11:44:56 -08:00
2021-11-17 20:17:05 -08:00
2019-06-05 17:37:07 +02:00
2021-11-25 21:00:45 -08:00
2021-06-01 16:54:42 -07:00
2020-02-28 14:51:30 +01:00
2021-10-18 12:54:41 +01:00
2021-04-27 14:02:06 -07:00
2019-05-30 11:26:41 -07:00
2021-04-23 10:17:26 +01:00
2021-11-26 18:01:58 -08:00
2021-06-11 13:32:46 -07:00
2021-11-01 13:36:09 +00:00
2021-11-23 11:51:37 +00:00
2021-10-13 09:40:45 -07:00
2021-08-03 13:05:25 +01:00
2020-07-21 18:30:47 -07:00
2021-08-03 11:50:22 +01:00
2020-05-01 12:15:37 -07:00
2021-11-30 12:15:58 +00:00
2021-11-30 12:15:58 +00:00
2021-03-26 17:43:55 +01:00
2021-12-01 19:15:54 -08:00
2019-05-21 11:28:45 +02:00
2019-06-19 17:09:55 +02:00
2021-10-28 10:43:58 -07:00
2020-02-29 14:39:08 +01:00
2021-12-06 16:26:46 -08:00
2020-07-15 07:45:24 -07:00
2020-03-27 19:40:38 -07:00
2021-10-20 15:24:36 -07:00
2021-10-20 15:24:36 -07:00
2021-08-05 11:46:42 +01:00
2021-10-13 09:40:46 -07:00
2019-05-30 11:29:52 -07:00
2019-05-30 11:29:52 -07:00
2021-12-06 16:05:10 -08:00
2021-07-30 15:33:24 +02:00
2019-05-21 11:52:39 +02:00
2019-05-21 11:52:39 +02:00
2021-10-13 09:40:46 -07:00
2021-12-01 18:58:00 -08:00
2019-12-16 16:09:44 -08:00
2021-11-29 19:50:45 -08:00
2021-07-09 13:55:53 -07:00
2020-05-08 21:33:33 -07:00
2021-12-06 16:05:10 -08:00
2020-05-05 13:23:29 -07:00
2020-02-19 13:52:32 +01:00
2020-04-20 07:34:16 +02:00
2019-06-19 17:09:55 +02:00
2021-12-06 16:06:02 -08:00
2019-12-24 22:37:30 -08:00
2021-11-29 14:43:35 +00:00
2021-10-29 14:03:22 +01:00
2021-08-19 18:09:18 -07:00
2021-09-02 11:44:19 +01:00
2021-01-21 13:33:45 +01:00
2021-01-21 13:33:45 +01:00
2019-12-09 10:36:44 -08:00
2021-10-18 12:54:41 +01:00
2021-02-12 16:31:46 -08:00
2019-03-22 12:09:31 -07:00
2021-01-29 20:39:14 -08:00
2021-12-06 16:26:46 -08:00
2020-06-22 21:12:44 -07:00
2019-10-25 16:24:32 -07:00
2021-06-28 14:29:45 -07:00
2021-08-13 09:58:25 +02:00
2019-05-30 11:26:41 -07:00
2021-12-06 16:05:11 -08:00
2019-04-22 21:50:53 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-03-30 13:45:04 -07:00
2021-01-27 18:18:15 -08:00
2021-11-23 20:16:18 -08:00
2021-10-15 11:33:08 +01:00
2020-12-12 15:08:54 -08:00
2021-07-23 16:44:57 -07:00
2021-11-17 20:21:52 -08:00
2019-09-27 12:05:02 +02:00
2021-10-04 12:53:35 +01:00
2021-11-16 13:16:54 +00:00
2021-11-22 15:44:49 +00:00
2021-11-19 20:09:55 -08:00
2021-12-06 16:05:11 -08:00
2021-12-02 11:56:04 +00:00
2021-12-06 16:05:11 -08:00
2021-10-07 19:52:58 +02:00
2021-11-20 14:11:00 +00:00
2020-11-19 10:49:50 -08:00
2021-11-22 15:44:49 +00:00
2021-11-16 13:10:34 +00:00
2019-06-19 17:09:55 +02:00
2020-06-20 17:22:22 -07:00
2021-03-23 14:14:50 -07:00
2019-10-08 13:23:05 -07:00
2021-10-13 09:40:46 -07:00
2021-07-27 13:05:56 +01:00
2021-11-07 19:25:29 +00:00
2021-08-30 01:51:36 +02:00
2021-10-22 10:20:56 -07:00
2019-05-30 11:26:41 -07:00
2021-06-24 12:41:12 -07:00
2021-10-29 13:23:51 +01:00
2021-10-29 13:23:51 +01:00
2020-03-02 11:16:27 -08:00
2021-03-26 15:14:56 -07:00
2020-02-28 12:08:37 -08:00
2020-05-29 21:20:20 -07:00
2021-10-28 10:43:58 -07:00
2019-12-09 10:36:44 -08:00
2021-11-23 11:51:37 +00:00
2021-12-06 16:05:11 -08:00
2021-08-01 12:00:51 +02:00
2019-05-21 11:28:45 +02:00
2021-07-27 11:43:50 +01:00
2019-11-12 08:18:03 -08:00
2019-04-11 13:59:49 -07:00
2021-09-24 14:07:10 +01:00
2021-11-16 18:02:46 +01:00
2021-11-18 11:29:40 +00:00
2020-03-04 13:25:55 -08:00
2019-05-30 11:26:32 -07:00
2021-10-19 12:24:51 +01:00
2021-09-26 11:09:07 +01:00
2021-05-17 15:29:35 -07:00
2021-08-09 15:34:21 -07:00
2019-05-30 11:26:32 -07:00
2021-03-25 17:40:43 -07:00
2020-07-31 09:24:23 +02:00
2020-08-24 14:35:00 -07:00
2021-10-13 09:40:45 -07:00
2020-11-23 18:36:21 -05:00
2020-06-23 20:27:09 -07:00
2021-08-04 10:01:26 +01:00
2019-04-22 21:47:25 -07:00
2021-12-06 16:05:12 -08:00
2020-07-13 11:03:44 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-06-04 15:39:32 -07:00
2021-04-28 14:06:45 -07:00
2020-09-28 15:19:03 -07:00
2019-10-05 16:29:00 -07:00
2021-06-15 18:01:05 +02:00
2021-12-02 11:44:56 -08:00
2021-08-03 13:05:26 +01:00
2021-11-09 01:05:34 +01:00
2021-10-27 14:54:02 +01:00
2019-05-30 11:26:32 -07:00
2021-11-16 13:10:35 +00:00
2019-05-30 11:26:32 -07:00
2019-10-04 14:07:07 -07:00
2021-10-28 10:43:58 -07:00
2020-06-23 20:10:15 -07:00
2020-06-18 20:46:23 -07:00
2021-02-04 18:37:14 -08:00
2021-11-16 13:16:54 +00:00
2019-11-14 18:12:17 -08:00
2021-11-29 12:19:53 +00:00
2019-12-09 10:28:43 -08:00
2019-11-16 12:39:10 -08:00
2021-09-28 00:18:34 +02:00
2021-06-24 19:41:15 +02:00
2021-09-30 23:23:49 +02:00
2021-07-21 09:49:19 +02:00
2021-09-28 00:18:35 +02:00
45cac67545