Alexey Makhalov afd09b617d
ext4: fix memory leak in ext4_fill_super ...
Buffer head references must be released before calling kill_bdev();
otherwise the buffer head (and its page referenced by b_data) will not
be freed by kill_bdev, and subsequently that bh will be leaked.
If blocksizes differ, sb_set_blocksize() will kill current buffers and
page cache by using kill_bdev(). And then super block will be reread
again but using correct blocksize this time. sb_set_blocksize() didn't
fully free superblock page and buffer head, and being busy, they were
not freed and instead leaked.
This can easily be reproduced by calling an infinite loop of:
systemctl start <ext4_on_lvm>.mount, and
systemctl stop <ext4_on_lvm>.mount
... since systemd creates a cgroup for each slice which it mounts, and
the bh leak get amplified by a dying memory cgroup that also never
gets freed, and memory consumption is much more easily noticed.
Fixes: ce40733ce9ac27a0ec11https://lore.kernel.org/r/20210521075533.95732-1-amakhalov@vmware.com
Signed-off-by: Alexey Makhalov <amakhalov@vmware.com >
Signed-off-by: Theodore Ts'o <tytso@mit.edu >
Cc: stable@kernel.org
2021-06-06 10:10:23 -04:00
2021-02-27 08:07:12 -08:00
2021-01-24 14:27:20 +01:00
2021-02-23 13:39:45 -08:00
2021-03-15 17:09:54 +00:00
2021-01-24 14:27:20 +01:00
2020-09-18 16:45:50 -04:00
2021-01-24 14:27:20 +01:00
2021-03-18 13:38:42 -07:00
2021-02-23 13:39:45 -08:00
2021-02-23 13:39:45 -08:00
2021-03-19 11:51:31 -05:00
2021-01-24 14:27:20 +01:00
2021-03-11 12:13:48 +01:00
2021-01-05 23:02:47 -05:00
2021-03-11 07:47:48 -07:00
2021-02-24 10:13:55 -08:00
2020-11-10 12:14:20 -06:00
2021-02-23 13:39:45 -08:00
2021-01-24 14:27:20 +01:00
2020-09-18 16:45:50 -04:00
2021-03-13 12:26:22 -08:00
2021-02-23 13:39:45 -08:00
2020-12-09 09:39:38 -05:00
2021-01-24 14:27:20 +01:00
2021-06-06 10:10:23 -04:00
2021-03-11 07:47:48 -07:00
2021-02-23 13:39:45 -08:00
2021-03-16 15:20:16 +01:00
2021-03-12 13:25:49 -08:00
2021-01-24 14:27:20 +01:00
2021-02-23 13:39:45 -08:00
2021-02-23 13:39:45 -08:00
2021-01-24 14:27:20 +01:00
2021-02-24 13:38:35 -08:00
2021-03-18 10:37:30 -07:00
2021-02-03 19:05:52 +01:00
2021-04-09 23:32:16 -04:00
2021-02-23 13:39:45 -08:00
2021-02-27 08:07:12 -08:00
2021-02-23 13:39:45 -08:00
2021-01-25 09:36:23 -05:00
2021-01-24 14:27:20 +01:00
2021-03-11 13:17:42 -05:00
2021-01-28 10:55:37 -05:00
2021-03-11 10:58:49 -05:00
2021-03-11 07:47:48 -07:00
2021-02-23 13:39:45 -08:00
2021-02-24 13:38:26 -08:00
2021-02-24 13:38:26 -08:00
2021-01-24 14:27:20 +01:00
2021-02-23 13:39:45 -08:00
2021-02-23 13:39:45 -08:00
2021-03-13 11:27:30 -08:00
2021-03-05 17:21:25 -08:00
2020-09-18 16:45:50 -04:00
2020-09-18 16:45:50 -04:00
2021-01-05 14:42:18 +01:00
2021-02-24 13:38:26 -08:00
2021-02-23 13:39:45 -08:00
2020-10-24 12:26:05 -07:00
2021-03-11 07:47:48 -07:00
2021-01-12 14:26:31 +01:00
2021-01-24 14:27:20 +01:00
2021-01-24 14:27:20 +01:00
2021-02-23 13:39:45 -08:00
2021-02-23 13:39:45 -08:00
2021-01-24 14:27:20 +01:00
2020-09-10 14:03:31 -07:00
2021-01-24 14:27:20 +01:00
2021-02-23 13:39:45 -08:00
2021-03-15 08:50:41 -07:00
2021-03-17 08:56:50 +09:00
2020-12-15 12:53:37 -08:00
2021-01-15 12:17:25 -05:00
2021-01-24 14:27:20 +01:00
2021-01-24 14:27:20 +01:00
2021-02-21 13:20:41 -08:00
2021-02-21 13:20:41 -08:00
2020-08-24 08:49:13 +10:00
2021-03-13 11:27:30 -08:00
2021-03-11 07:47:48 -07:00
2021-02-24 13:38:30 -08:00
2021-01-06 08:42:51 -05:00
2021-02-26 09:41:05 -08:00
2020-10-14 14:54:45 -07:00
2021-02-09 07:05:44 -05:00
2021-02-24 13:38:26 -08:00
2021-02-28 11:23:38 -08:00
2020-11-15 09:49:10 -05:00
2021-02-16 09:59:41 +01:00
2021-02-24 13:38:26 -08:00
2021-02-23 13:39:45 -08:00
2021-02-24 13:38:26 -08:00
2020-10-25 20:02:08 -04:00
2021-02-01 10:02:42 -07:00
2020-08-23 17:36:59 -05:00
2020-10-13 18:38:27 -07:00
2020-07-29 16:14:27 +02:00
2021-01-13 17:26:50 +01:00
2020-08-23 17:36:59 -05:00
2021-01-24 14:27:19 +01:00
2021-02-27 08:07:12 -08:00
2021-02-23 13:39:45 -08:00
2021-03-21 09:41:14 -06:00
2021-03-21 09:41:14 -06:00
2021-03-18 09:44:35 -06:00
2020-07-31 08:16:01 +02:00
2021-03-08 10:46:30 +01:00
2021-02-21 09:29:23 -08:00
2020-10-05 13:37:04 +02:00
2021-02-23 13:39:45 -08:00
2021-03-09 10:37:34 -05:00
2021-01-29 10:06:46 +05:30
2021-01-24 14:29:34 +01:00
2021-03-11 07:47:48 -07:00
2021-02-23 13:39:45 -08:00
2021-02-27 08:07:12 -08:00
2021-02-23 13:39:45 -08:00
2021-02-24 13:38:26 -08:00
2021-03-08 15:18:43 +01:00
2021-01-24 14:27:20 +01:00
2021-01-24 14:43:45 +01:00
2021-01-25 23:29:36 -05:00
2020-07-31 08:16:00 +02:00
2021-01-24 14:27:19 +01:00
2021-03-16 22:13:10 +01:00
2021-01-21 14:06:00 -07:00
2020-08-23 17:36:59 -05:00
2021-02-21 11:02:48 -08:00
2021-04-17 23:03:50 -04:00
2021-02-13 17:17:53 +01:00
2021-02-22 10:57:46 -08:00
2021-01-14 17:40:57 -05:00
2021-01-24 14:27:18 +01:00
2021-01-24 14:27:17 +01:00
afd09b617d