Peilin Ye
f482aa9865
audit, io_uring, io-wq: Fix memory leak in io_sq_thread() and io_wqe_worker()
Currently @audit_context is allocated twice for io_uring workers:
1. copy_process() calls audit_alloc();
2. io_sq_thread() or io_wqe_worker() calls audit_alloc_kernel() (which
is effectively audit_alloc()) and overwrites @audit_context,
causing:
BUG: memory leak
unreferenced object 0xffff888144547400 (size 1024):
<...>
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 ................
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff8135cfc3>] audit_alloc+0x133/0x210
[<ffffffff81239e63>] copy_process+0xcd3/0x2340
[<ffffffff8123b5f3>] create_io_thread+0x63/0x90
[<ffffffff81686604>] create_io_worker+0xb4/0x230
[<ffffffff81686f68>] io_wqe_enqueue+0x248/0x3b0
[<ffffffff8167663a>] io_queue_iowq+0xba/0x200
[<ffffffff816768b3>] io_queue_async+0x113/0x180
[<ffffffff816840df>] io_req_task_submit+0x18f/0x1a0
[<ffffffff816841cd>] io_apoll_task_func+0xdd/0x120
[<ffffffff8167d49f>] tctx_task_work+0x11f/0x570
[<ffffffff81272c4e>] task_work_run+0x7e/0xc0
[<ffffffff8125a688>] get_signal+0xc18/0xf10
[<ffffffff8111645b>] arch_do_signal_or_restart+0x2b/0x730
[<ffffffff812ea44e>] exit_to_user_mode_prepare+0x5e/0x180
[<ffffffff844ae1b2>] syscall_exit_to_user_mode+0x12/0x20
[<ffffffff844a7e80>] do_syscall_64+0x40/0x80
Then,
3. io_sq_thread() or io_wqe_worker() frees @audit_context using
audit_free();
4. do_exit() eventually calls audit_free() again, which is okay
because audit_free() does a NULL check.
As suggested by Paul Moore, fix it by deleting audit_alloc_kernel() and
redundant audit_free() calls.
Fixes: 5bd2182d58 ("audit,io_uring,io-wq: add some basic audit support to io_uring")
Suggested-by: Paul Moore <paul@paul-moore.com>
Cc: stable@vger.kernel.org
Signed-off-by: Peilin Ye <peilin.ye@bytedance.com>
Acked-by: Paul Moore <paul@paul-moore.com>
Link: https://lore.kernel.org/r/20220803222343.31673-1-yepeilin.cs@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2022-08-04 08:33:54 -06:00
..
2022-07-08 10:55:53 +02:00
2022-08-01 11:49:06 -07:00
2022-07-27 18:09:11 +02:00
2022-05-26 17:13:43 -07:00
2022-06-23 15:26:59 +02:00
2022-07-05 13:32:59 -07:00
2022-08-01 12:24:30 -07:00
2022-05-25 16:18:27 -07:00
2021-12-02 17:25:21 +09:00
2022-07-28 12:36:35 +02:00
2022-07-22 09:22:59 -06:00
2022-06-02 08:55:01 -07:00
2022-08-02 19:12:45 -07:00
2022-08-02 19:34:45 -07:00
2022-08-02 13:46:35 -07:00
2022-07-15 10:52:11 +02:00
2022-08-02 19:12:45 -07:00
2022-08-02 19:12:45 -07:00
2022-08-02 19:12:45 -07:00
2022-08-02 19:12:45 -07:00
2022-04-06 13:43:44 -07:00
2022-02-03 11:20:34 -08:00
2022-04-25 14:37:18 +02:00
2022-04-25 14:37:28 +02:00
2022-04-25 14:37:12 +02:00
2022-06-13 14:08:57 -04:00
2022-02-22 13:51:40 -05:00
2022-01-11 13:08:21 -08:00
2022-08-04 08:33:54 -06:00
2022-03-09 10:32:06 -08:00
2022-07-05 13:32:59 -07:00
2021-09-08 15:32:35 -07:00
2022-07-05 13:33:00 -07:00
2022-07-05 13:32:59 -07:00
2022-05-23 17:51:12 -07:00
2022-05-27 11:22:03 -07:00
2022-03-15 10:32:44 +01:00
2022-06-01 15:55:25 -07:00
2022-07-11 09:52:59 -07:00
2022-07-05 13:32:59 -07:00
2022-08-02 19:12:45 -07:00
2022-05-08 03:16:59 +09:00
2022-07-15 18:21:49 +00:00
2022-06-23 19:11:28 +02:00
2022-04-15 14:49:55 -07:00
2022-06-24 09:48:55 +02:00
2022-05-10 14:42:06 -07:00
2021-08-17 17:50:51 +02:00
2022-03-31 10:36:55 +02:00
2022-05-25 13:05:42 -07:00
2022-07-15 12:21:16 -04:00
2022-07-15 12:21:16 -04:00
2021-09-08 15:32:34 -07:00
2022-05-29 10:31:36 -07:00
2022-03-23 19:00:33 -07:00
2022-06-16 19:11:30 -07:00
2022-04-21 11:40:59 -07:00
2022-06-06 08:06:00 +02:00
2022-05-19 19:30:30 +02:00
2022-06-15 07:58:04 -07:00
2022-01-31 11:21:46 +11:00
2022-08-02 19:34:45 -07:00
2021-12-28 11:26:18 +01:00
2022-04-29 14:38:00 -07:00
2021-10-14 13:29:18 +02:00
2022-06-06 08:06:00 +02:00
2022-01-08 12:43:57 -06:00
2022-07-09 11:06:19 -07:00
2022-06-23 19:11:28 +02:00
2022-05-12 20:38:37 -07:00
2022-03-23 19:00:35 -07:00
2022-08-01 15:21:42 +02:00
2022-04-11 17:07:29 -07:00
2022-03-24 19:06:48 -07:00
2022-05-03 14:11:58 -07:00
2022-07-07 09:53:43 -07:00
2022-07-19 11:40:00 -07:00
2022-04-12 14:13:01 +02:00
2022-07-05 13:32:59 -07:00
2022-05-08 01:33:09 -07:00
2022-02-25 09:36:06 +01:00
2022-04-05 09:59:38 +02:00
2022-04-05 09:59:38 +02:00
2022-05-24 11:11:13 -07:00
2022-01-15 16:30:30 +02:00
2022-04-22 18:50:54 +01:00
2022-07-15 09:52:35 -07:00
2022-04-30 08:39:32 -06:00
2022-04-29 14:38:03 -07:00
2022-02-01 17:24:39 -08:00
2021-08-16 11:39:51 -04:00
2022-04-29 14:38:03 -07:00
2022-02-17 09:11:57 -06:00
2022-05-06 14:49:44 -05:00
2022-02-25 10:40:14 -06:00
2021-09-08 11:50:27 -07:00
2022-05-19 23:25:47 -04:00
2022-08-02 19:24:24 -07:00
2022-06-23 18:41:40 +02:00
2022-06-23 19:11:28 +02:00
2021-08-17 07:49:10 -10:00
2022-07-29 07:49:02 -10:00