Linus Torvalds
a180bd1d7e
iov_iter: remove uaccess_kernel() warning from iov_iter_init()
...
This warning was there to catch any architectures that still use
CONFIG_SET_FS, and that would mis-use iov_iter_init() for anything that
wasn't a proper user space pointer. So that
WARN_ON_ONCE(uaccess_kernel());
makes perfect conceptual sense: you really shouldn't use a kernel
pointer with set_fs(KERNEL_DS) and then pass it to iov_iter_init().
HOWEVER.
Guenter Roeck reports that this warning actually triggers in no-mmu
configurations of both ARM and m68k. And the reason isn't that they
pass in a kernel pointer under set_fs(KERNEL_DS) at all: the reason is
that in those configurations, "uaccess_kernel()" is simply not reliable.
Those no-mmu setups set USER_DS and KERNEL_DS to the same values, so you
can't test for the difference.
In particular, the no-mmu case for ARM does
#define USER_DS KERNEL_DS
#define uaccess_kernel() (true)
so USER_DS and KERNEL_DS have the same value, and uaccess_kernel() is
always trivially true.
The m68k case is slightly different and not quite as obvious. It does
(spread out over multiple header files just to be extra exciting:
asm/processor.h, asm/segment.h and asm-generic/uaccess.h):
#define TASK_SIZE (0xFFFFFFFFUL)
#define USER_DS MAKE_MM_SEG(TASK_SIZE)
#define KERNEL_DS MAKE_MM_SEG(~0UL)
#define get_fs() (current_thread_info()->addr_limit)
#define uaccess_kernel() (get_fs().seg == KERNEL_DS.seg)
but the end result is the same: uaccess_kernel() will always be true,
because USER_DS and KERNEL_DS end up having the same value, even if that
value is defined differently.
This is very arguably a misfeature in those implementations, but in the
end we don't really care. All modern architectures have gotten rid of
set_fs() already, and generic kernel code never uses it. And while the
sanity check was a nice idea, an architecture would have to go the extra
mile to actually break this.
So this well-intentioned warning isn't really all that likely to find
anything but these known false positives, and as such just isn't worth
maintaining.
Reported-by: Guenter Roeck <linux@roeck-us.net >
Fixes: 8cd54c1c84 ("iov_iter: separate direction from flavour")
Cc: Matthew Wilcox <willy@infradead.org >
Cc: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2021-07-04 16:12:42 -07:00
..
2020-08-10 01:32:59 +09:00
2021-04-22 17:31:29 +10:00
2020-11-18 14:15:17 -06:00
2021-01-07 21:06:25 +01:00
2021-07-02 12:58:26 -07:00
2020-08-09 14:10:26 -07:00
2021-07-01 11:06:05 -07:00
2020-12-15 22:46:19 -08:00
2021-07-01 11:06:05 -07:00
2021-07-01 11:06:05 -07:00
2020-07-28 17:07:06 -07:00
2021-01-04 10:38:11 +09:00
2020-08-10 01:32:59 +09:00
2021-04-14 23:04:44 +10:00
2021-07-01 11:06:05 -07:00
2020-08-10 01:32:59 +09:00
2020-12-29 15:36:49 -08:00
2021-07-01 11:06:05 -07:00
2021-07-01 11:06:05 -07:00
2021-05-02 00:43:35 +09:00
2018-06-12 16:19:22 -07:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2020-11-18 14:15:17 -06:00
2021-04-14 16:30:30 +03:00
2020-11-18 14:15:17 -06:00
2019-05-30 11:26:32 -07:00
2021-05-26 13:20:50 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-05-06 19:24:12 -07:00
2020-10-16 13:25:14 -06:00
2021-05-10 15:38:20 -07:00
2019-05-21 10:50:45 +02:00
2021-06-10 13:41:26 -04:00
2020-06-11 15:14:53 +02:00
2019-06-05 17:37:16 +02:00
2018-08-16 12:14:42 -07:00
2021-04-01 09:54:37 +01:00
2019-05-24 17:27:11 +02:00
2021-01-14 19:29:58 -08:00
2018-11-30 07:22:05 +01:00
2017-11-02 11:10:55 +01:00
2020-08-20 15:45:14 -04:00
2019-06-19 17:09:55 +02:00
2017-11-02 11:10:55 +01:00
2021-06-23 16:41:41 -06:00
2021-05-05 16:07:40 +02:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-10-18 15:01:57 +02:00
2021-02-05 23:28:29 +01:00
2019-06-19 17:09:06 +02:00
2021-01-21 14:06:00 -07:00
2021-05-06 19:24:12 -07:00
2019-06-19 17:09:06 +02:00
2020-10-16 11:11:20 -07:00
2018-07-27 19:04:33 +08:00
2020-11-02 12:14:19 -08:00
2021-06-05 08:58:12 -07:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2020-06-18 17:26:43 +10:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-06-22 13:56:43 +02:00
2020-10-01 16:13:54 +02:00
2018-06-12 23:33:24 +02:00
2021-07-01 11:06:05 -07:00
2020-01-31 10:30:40 -08:00
2021-07-01 11:06:06 -07:00
2021-05-06 19:24:12 -07:00
2021-07-01 11:06:06 -07:00
2021-07-01 11:06:05 -07:00
2021-07-01 11:06:05 -07:00
2020-07-31 11:49:08 +02:00
2020-12-11 12:28:08 -08:00
2021-04-08 20:18:38 +09:00
2020-11-20 14:45:33 +11:00
2021-06-29 17:29:11 -07:00
2021-05-13 20:50:23 +02:00
2020-10-16 11:11:20 -07:00
2021-04-16 16:10:37 -07:00
2020-12-15 22:46:15 -08:00
2020-12-15 22:46:19 -08:00
2020-12-15 22:46:15 -08:00
2021-01-03 20:05:18 -05:00
2020-10-16 11:11:22 -07:00
2020-04-15 21:36:41 +01:00
2020-01-08 16:59:19 +00:00
2019-06-05 17:36:38 +02:00
2021-05-06 19:24:12 -07:00
2020-06-04 19:06:25 -07:00
2018-07-27 19:04:33 +08:00
2018-12-29 11:36:44 -08:00
2021-05-06 19:24:12 -07:00
2019-10-14 15:04:00 -07:00
2020-11-18 14:15:17 -06:00
2017-02-24 17:46:57 -08:00
2020-10-16 11:11:19 -07:00
2019-05-13 11:07:33 +02:00
2020-10-20 14:39:37 -07:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:56 +02:00
2020-08-14 19:56:57 -07:00
2018-05-09 06:55:44 +02:00
2021-07-04 16:12:42 -07:00
2019-02-19 20:52:19 -07:00
2019-05-30 11:26:32 -07:00
2019-05-24 17:27:11 +02:00
2017-11-02 11:10:55 +01:00
2021-04-14 16:30:30 +03:00
2021-07-02 12:58:26 -07:00
2021-06-29 10:53:53 -07:00
2021-03-08 14:27:43 -08:00
2021-05-05 11:27:27 -07:00
2020-09-28 12:14:08 +01:00
2021-02-26 09:41:05 -08:00
2019-08-30 18:47:15 -07:00
2019-06-19 17:09:08 +02:00
2021-04-10 11:09:41 +02:00
2020-09-07 11:24:17 +02:00
2021-07-02 12:08:10 -07:00
2021-05-19 15:05:11 +02:00
2020-10-16 11:11:19 -07:00
2020-12-28 12:24:47 +00:00
2018-04-11 10:28:35 -07:00
2021-05-06 19:24:12 -07:00
2020-03-25 16:38:39 -06:00
2019-06-05 17:37:06 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-06-22 16:42:08 +02:00
2019-06-07 13:15:06 -07:00
2021-02-17 17:31:06 -06:00
2021-04-16 16:10:37 -07:00
2019-05-24 17:39:02 +02:00
2021-06-29 17:29:11 -07:00
2018-10-16 13:45:44 +02:00
2019-05-21 10:50:45 +02:00
2020-09-26 10:33:57 -07:00
2017-11-02 11:10:55 +01:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2021-05-05 12:48:46 -07:00
2020-08-24 14:24:25 -07:00
2017-11-02 11:10:55 +01:00
2019-07-03 16:57:18 +02:00
2017-11-02 11:10:55 +01:00
2020-02-16 18:33:00 -08:00
2019-05-21 10:50:45 +02:00
2021-03-26 19:41:58 +11:00
2017-11-04 09:26:51 +09:00
2020-06-28 20:45:27 -07:00
2021-04-16 16:10:37 -07:00
2021-07-01 11:06:05 -07:00
2018-01-26 11:45:16 -06:00
2021-05-06 19:24:12 -07:00
2019-05-21 10:50:45 +02:00
2021-05-13 03:27:38 +00:00
2019-05-21 11:28:45 +02:00
2019-05-21 10:50:45 +02:00
2021-04-16 16:10:37 -07:00
2020-10-24 20:21:57 +02:00
2019-06-05 17:37:16 +02:00
2019-09-25 17:51:39 -07:00
2020-08-12 10:58:00 -07:00
2019-11-25 09:15:32 +01:00
2020-07-28 17:09:49 -07:00
2021-03-04 17:36:59 -05:00
2020-10-29 08:55:45 -06:00
2021-06-26 09:19:16 -04:00
2019-07-11 15:17:41 -07:00
2019-08-08 07:45:01 -06:00
2020-11-20 14:45:33 +11:00
2019-09-24 15:54:09 -07:00
2020-11-18 14:15:17 -06:00
2021-06-29 10:53:46 -07:00
2021-05-19 10:51:40 +02:00
2019-11-14 13:15:11 -05:00
2021-05-06 19:24:12 -07:00
2019-05-30 11:26:32 -07:00
2021-07-01 11:06:05 -07:00
2021-07-01 11:06:05 -07:00
2020-11-19 11:56:16 -08:00
2020-05-01 12:35:21 +10:00
2021-06-18 11:43:09 +02:00
2021-05-10 15:38:20 -07:00
2020-08-12 10:57:59 -07:00
2020-08-12 10:58:00 -07:00
2019-07-01 19:34:46 -07:00
2021-01-20 14:13:48 -08:00
2019-05-21 10:50:45 +02:00
2020-12-15 22:46:16 -08:00
2021-01-18 11:03:26 +01:00
2020-12-15 22:46:16 -08:00
2019-05-21 10:50:45 +02:00
2018-11-30 12:13:15 -08:00
2021-07-01 11:06:03 -07:00
2021-07-01 11:06:03 -07:00
2018-10-15 16:31:29 -04:00
2021-04-09 14:54:23 -07:00
2021-07-02 12:58:26 -07:00
2020-12-15 22:46:16 -08:00
2020-05-08 18:18:12 +01:00
2021-06-25 11:31:03 -06:00
2020-12-15 22:46:16 -08:00
2018-10-16 13:45:44 +02:00
2019-12-04 19:44:13 -08:00
2020-03-06 11:56:59 +01:00
2019-05-21 10:50:45 +02:00
2020-06-15 13:32:11 -07:00
2019-07-16 19:23:22 -07:00
2017-02-26 11:03:38 -05:00
2021-06-29 12:07:18 -07:00
2021-03-24 15:16:09 -07:00
2021-05-27 15:38:03 +02:00
2017-01-09 13:58:57 -05:00
2019-05-21 10:50:45 +02:00
2020-04-07 10:43:43 -07:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2021-07-01 11:06:05 -07:00
2019-04-08 16:44:21 -06:00
2020-10-16 11:11:20 -07:00
2021-02-26 09:41:05 -08:00
2019-10-16 14:56:21 +02:00
2017-07-21 09:38:30 +02:00
2021-04-30 11:20:40 -07:00
2021-03-30 13:42:33 -04:00
2015-09-10 13:29:01 -07:00
2021-07-01 11:06:05 -07:00
2019-10-03 12:12:23 -04:00
2021-02-17 14:08:01 +01:00
2020-08-12 10:58:00 -07:00
2020-11-18 14:15:17 -06:00
2020-04-07 10:43:43 -07:00
2021-02-26 09:41:05 -08:00
2021-02-05 11:03:47 -08:00
2019-05-24 17:39:02 +02:00
2018-06-07 17:34:39 -07:00
2020-10-16 11:11:22 -07:00
2020-03-23 17:01:47 +01:00
2021-07-02 12:08:10 -07:00
2017-11-02 11:10:55 +01:00
2021-03-30 13:42:33 -04:00
2020-08-12 10:58:00 -07:00