Files
linux/include/linux
Craig Gallek d894ba18d4 soreuseport: fix ordering for mixed v4/v6 sockets
With the SO_REUSEPORT socket option, it is possible to create sockets
in the AF_INET and AF_INET6 domains which are bound to the same IPv4 address.
This is only possible with SO_REUSEPORT and when not using IPV6_V6ONLY on
the AF_INET6 sockets.

Prior to the commits referenced below, an incoming IPv4 packet would
always be routed to a socket of type AF_INET when this mixed-mode was used.
After those changes, the same packet would be routed to the most recently
bound socket (if this happened to be an AF_INET6 socket, it would
have an IPv4 mapped IPv6 address).

The change in behavior occurred because the recent SO_REUSEPORT optimizations
short-circuit the socket scoring logic as soon as they find a match.  They
did not take into account the scoring logic that favors AF_INET sockets
over AF_INET6 sockets in the event of a tie.

To fix this problem, this patch changes the insertion order of AF_INET
and AF_INET6 addresses in the TCP and UDP socket lists when the sockets
have SO_REUSEPORT set.  AF_INET sockets will be inserted at the head of the
list and AF_INET6 sockets with SO_REUSEPORT set will always be inserted at
the tail of the list.  This will force AF_INET sockets to always be
considered first.

Fixes: e32ea7e747 ("soreuseport: fast reuseport UDP socket selection")
Fixes: 125e80b88687 ("soreuseport: fast reuseport TCP socket selection")

Reported-by: Maciej Żenczykowski <maze@google.com>
Signed-off-by: Craig Gallek <kraig@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2016-04-14 21:14:03 -04:00
..
2015-10-17 21:22:08 -07:00
2015-10-07 18:08:15 +01:00
2016-03-04 23:50:27 -06:00
2015-05-13 12:04:55 -05:00
2015-12-23 08:37:10 -07:00
2016-02-11 10:07:18 -05:00
2016-03-15 16:55:16 -07:00
2015-12-22 09:38:34 -07:00
2016-03-20 09:34:02 -06:00
2015-12-06 12:46:31 +01:00
2016-03-08 15:28:31 -05:00
2016-03-11 21:19:16 +08:00
2016-02-16 13:04:58 -05:00
2016-03-26 16:14:37 -04:00
2016-02-26 13:28:35 +02:00
2015-06-24 17:49:45 -07:00
2015-12-28 13:41:50 +01:00
2016-01-15 17:56:32 -08:00
2015-05-05 13:40:42 -06:00
2015-11-25 09:22:00 -07:00
2016-03-11 14:58:58 -05:00
2015-10-23 05:44:28 -07:00
2016-02-11 09:59:22 -05:00
2016-03-22 15:36:02 -07:00
2015-10-01 15:06:43 +02:00
2015-12-14 10:03:46 +01:00
2015-06-25 12:06:45 +02:00
2016-01-28 14:19:12 -08:00
2016-03-25 16:37:42 -07:00
2016-03-22 15:36:02 -07:00
2016-02-16 13:04:58 -05:00
2016-03-22 15:36:02 -07:00
2015-07-28 08:50:42 +01:00
2016-01-15 17:56:32 -08:00
2015-04-29 17:17:17 -05:00
2016-03-09 15:43:42 -08:00
2016-01-15 17:56:32 -08:00
2015-10-27 18:55:31 -07:00
2015-06-24 17:49:41 -07:00
2015-10-20 22:10:45 +08:00
2015-07-21 10:39:05 -07:00
2016-03-05 12:24:06 -08:00
2016-03-09 16:36:13 -05:00
2016-03-17 14:57:16 -04:00
2016-02-08 15:20:01 -05:00
2016-02-16 13:04:58 -05:00
2015-09-10 13:29:01 -07:00
2016-02-11 18:35:48 -08:00
2016-02-11 18:35:48 -08:00
2016-03-14 15:43:11 -04:00
2016-02-10 01:11:54 +01:00
2015-10-06 17:08:19 +02:00
2016-02-16 13:04:58 -05:00
2015-10-22 08:59:18 -07:00
2016-03-17 15:09:34 -07:00
2016-03-09 16:36:13 -05:00
2015-11-16 09:23:47 +01:00
2016-03-22 15:36:02 -07:00
2016-03-22 15:36:02 -07:00
2016-03-22 15:36:02 -07:00
2016-01-10 22:13:15 -05:00
2016-01-04 16:11:11 -05:00
2016-03-25 16:37:42 -07:00
2016-03-25 16:37:42 -07:00
2016-03-25 16:37:42 -07:00
2016-04-01 14:38:59 -04:00
2016-03-17 15:09:34 -07:00
2015-06-25 17:00:39 -07:00
2016-03-18 14:10:57 +08:00
2015-08-17 11:25:28 -07:00
2015-10-01 09:57:59 -07:00
2015-10-19 01:01:21 +02:00
2016-01-28 14:13:44 -08:00
2015-11-23 09:44:58 +01:00
2016-02-22 16:10:08 -07:00
2016-01-14 16:00:49 -08:00
2015-12-03 07:24:29 -08:00
2015-09-08 15:35:28 -07:00