Darrick J. Wong 9e9be9840f
xfs: fix broken variable-sized allocation detection in xfs_rtallocate_extent_block ...
This function tries to find a suitable free space extent starting from
a particular rtbitmap block. Some time ago, I added a clamping function
to prevent the free space scans from running off the end of the bitmap,
but I didn't quite get the logic right.
Let's say there's an allocation request with a minlen of 5 and a maxlen
of 32 and we're scanning the last rtbitmap block. If we come within 4
rtx of the end of the rt volume, maxlen will get clamped to 4. If the
next 3 rtx are free, we could have satisfied the allocation, but the
code setting partial besti/bestlen for "minlen < maxlen" will think that
we're doing a non-variable allocation and ignore it.
The root of this problem is overwriting maxlen; I should have stuffed
the results in a different variable, which would not have introduced
this bug.
Signed-off-by: Darrick J. Wong <djwong@kernel.org >
Reviewed-by: Christoph Hellwig <hch@lst.de >
2024-09-01 08:58:19 -07:00
2024-08-13 13:53:09 +02:00
2024-07-18 09:50:08 +02:00
2024-07-11 16:14:26 +02:00
2024-08-24 16:09:16 +02:00
2024-07-15 11:31:32 -07:00
2024-08-31 19:27:01 -04:00
2024-05-31 12:31:39 +02:00
2024-03-12 20:32:19 -07:00
2024-08-27 16:42:09 +02:00
2024-07-24 10:53:13 +02:00
2024-08-21 22:32:58 +02:00
2024-05-31 12:31:39 +02:00
2024-06-17 20:42:57 +02:00
2024-07-15 11:14:59 -07:00
2024-05-19 09:21:03 -07:00
2024-07-15 11:31:32 -07:00
2024-06-13 12:48:46 -05:00
2024-05-13 14:14:05 -07:00
2024-07-02 06:21:18 +02:00
2024-07-15 11:14:59 -07:00
2024-08-21 08:12:05 +08:00
2024-07-17 12:53:47 -07:00
2024-05-28 15:57:23 +02:00
2024-06-26 12:54:11 +02:00
2024-07-18 17:03:42 -07:00
2024-07-23 15:21:19 -07:00
2024-07-15 11:31:32 -07:00
2024-03-26 09:04:53 +01:00
2024-08-18 08:45:39 -07:00
2024-07-09 10:40:03 +02:00
2024-07-15 11:14:59 -07:00
2024-07-15 10:52:51 -07:00
2024-07-27 15:11:59 -07:00
2024-07-15 11:14:59 -07:00
2024-07-21 17:15:46 -07:00
2024-07-15 13:28:14 -07:00
2024-07-17 13:11:42 -07:00
2024-07-08 23:59:37 -04:00
2024-07-23 14:32:21 -07:00
2024-07-23 15:15:16 -07:00
2024-05-04 19:02:39 +02:00
2024-07-08 14:10:03 -04:00
2024-07-15 11:14:59 -07:00
2024-08-28 07:47:36 -05:00
2024-08-22 17:01:10 -04:00
2024-07-08 13:47:24 -04:00
2024-09-01 06:55:47 +12:00
2024-07-26 14:33:10 -07:00
2024-06-03 16:37:07 +02:00
2024-06-05 09:52:38 +02:00
2024-07-22 10:50:18 -07:00
2024-07-21 17:56:22 -07:00
2024-06-20 09:46:01 +02:00
2024-05-31 12:31:41 +02:00
2024-08-24 16:00:46 +02:00
2024-07-24 10:29:50 -07:00
2024-07-18 14:48:11 -07:00
2024-05-28 11:52:53 +02:00
2024-05-28 11:52:49 +02:00
2024-07-24 20:59:29 +02:00
2024-04-25 20:56:25 -07:00
2024-05-31 12:31:41 +02:00
2024-08-21 22:32:58 +02:00
2024-08-28 16:52:17 -05:00
2024-08-13 13:56:46 +02:00
2024-04-23 13:27:43 +02:00
2024-05-28 11:52:45 +02:00
2024-07-22 18:25:47 -07:00
2024-08-07 20:27:49 -04:00
2024-07-12 22:01:09 +02:00
2024-06-26 12:54:11 +02:00
2024-07-21 17:56:22 -07:00
2024-06-20 19:30:02 -04:00
2024-07-15 11:31:32 -07:00
2024-06-12 11:01:31 -07:00
2024-09-01 08:58:19 -07:00
2024-06-11 11:22:57 +09:00
2024-07-21 17:15:46 -07:00
2024-04-26 10:33:05 +02:00
2024-08-29 06:20:44 +12:00
2024-08-23 13:08:31 +02:00
2024-08-26 13:00:38 -07:00
2024-07-23 17:30:42 -07:00
2024-08-09 20:19:00 -07:00
2024-07-15 11:14:59 -07:00
2024-05-28 12:06:51 +02:00
2024-07-18 17:03:42 -07:00
2024-07-24 20:59:29 +02:00
2024-04-25 20:56:20 -07:00
2024-08-30 12:25:50 +12:00
2024-04-11 10:21:24 +02:00
2024-07-24 20:59:29 +02:00
2024-02-08 10:12:26 +01:00
2024-05-05 14:00:48 -07:00
2024-08-13 13:24:29 -07:00
2024-05-10 08:26:31 +02:00
2024-05-28 15:57:23 +02:00
2024-07-24 20:59:29 +02:00
2024-08-05 19:23:11 -04:00
2024-07-02 06:20:49 +02:00
2024-07-24 20:59:29 +02:00
2024-06-05 17:03:57 +02:00
2024-08-13 13:52:16 +02:00
2024-07-15 12:34:01 -07:00
2024-05-13 06:58:35 +02:00
2024-03-14 17:43:30 -07:00
2024-06-19 13:13:55 -07:00
2024-08-12 22:03:26 +02:00
2024-08-12 22:03:25 +02:00
2024-03-11 10:21:06 -07:00
2024-02-27 11:21:31 +01:00
2024-02-08 10:12:37 +01:00
2024-07-15 11:54:04 -07:00
2024-05-31 12:31:43 +02:00
2024-07-24 10:53:12 +02:00
2024-07-24 10:53:13 +02:00
2024-07-18 09:50:08 +02:00
2024-07-15 10:52:51 -07:00
2024-07-24 10:53:13 +02:00
2024-07-24 20:59:29 +02:00
2024-03-12 20:03:34 -07:00
2024-06-28 14:36:43 +02:00
2024-06-20 15:19:17 -06:00
2024-06-03 15:49:26 +02:00
2024-04-15 14:54:13 -07:00
2024-02-20 09:23:52 +01:00
2024-05-02 16:28:20 +02:00
2024-05-24 13:34:07 +02:00
2024-04-15 16:03:25 -04:00
2024-07-15 14:20:22 -07:00
2024-08-22 02:07:23 -04:00
2024-04-10 16:23:02 -06:00
2024-07-12 15:52:15 -07:00
2024-07-24 10:53:14 +02:00
9e9be9840f