mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-02-13 21:22:56 -05:00
Populate nested lease info to the queue-get response that returns the
ifindex, queue id with type and optionally netns id if the device
resides in a different netns.
Example with ynl client:
# ip a
[...]
4: enp10s0f0np0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 xdp/id:24 qdisc mq state UP group default qlen 1000
link/ether e8:eb:d3:a3:43:f6 brd ff:ff:ff:ff:ff:ff
inet 10.0.0.2/24 scope global enp10s0f0np0
valid_lft forever preferred_lft forever
inet6 fe80::eaeb:d3ff:fea3:43f6/64 scope link proto kernel_ll
valid_lft forever preferred_lft forever
[...]
# ethtool -i enp10s0f0np0
driver: mlx5_core
[...]
# ./pyynl/cli.py \
--spec ~/netlink/specs/netdev.yaml \
--do queue-get \
--json '{"ifindex": 4, "id": 15, "type": "rx"}'
{'id': 15,
'ifindex': 4,
'lease': {'ifindex': 8, 'netns-id': 0, 'queue': {'id': 1, 'type': 'rx'}},
'napi-id': 8227,
'type': 'rx',
'xsk': {}}
# ip netns list
foo (id: 0)
# ip netns exec foo ip a
[...]
8: nk@NONE: <BROADCAST,MULTICAST,NOARP,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff
inet6 fe80::200:ff:fe00:0/64 scope link proto kernel_ll
valid_lft forever preferred_lft forever
[...]
# ip netns exec foo ethtool -i nk
driver: netkit
[...]
# ip netns exec foo ls /sys/class/net/nk/queues/
rx-0 rx-1 tx-0
# ip netns exec foo ./pyynl/cli.py \
--spec ~/netlink/specs/netdev.yaml \
--do queue-get \
--json '{"ifindex": 8, "id": 1, "type": "rx"}'
{'id': 1, 'ifindex': 8, 'type': 'rx'}
Note that the caller of netdev_nl_queue_fill_one() holds the netdevice
lock. For the queue-get we do not lock both devices. When queues get
{un,}leased, both devices are locked, thus if __netif_get_rx_queue_peer()
returns true, the peer pointer points to a valid device. The netns-id
is fetched via peernet2id_alloc() similarly as done in OVS.
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Co-developed-by: David Wei <dw@davidwei.uk>
Signed-off-by: David Wei <dw@davidwei.uk>
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20260115082603.219152-4-daniel@iogearbox.net
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
278 lines
7.1 KiB
C
278 lines
7.1 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
#include <linux/ethtool_netlink.h>
|
|
#include <linux/netdevice.h>
|
|
#include <net/netdev_lock.h>
|
|
#include <net/netdev_queues.h>
|
|
#include <net/netdev_rx_queue.h>
|
|
#include <net/page_pool/memory_provider.h>
|
|
|
|
#include "page_pool_priv.h"
|
|
|
|
void netdev_rx_queue_lease(struct netdev_rx_queue *rxq_dst,
|
|
struct netdev_rx_queue *rxq_src)
|
|
{
|
|
netdev_assert_locked(rxq_src->dev);
|
|
netdev_assert_locked(rxq_dst->dev);
|
|
|
|
netdev_hold(rxq_src->dev, &rxq_src->lease_tracker, GFP_KERNEL);
|
|
|
|
WRITE_ONCE(rxq_src->lease, rxq_dst);
|
|
WRITE_ONCE(rxq_dst->lease, rxq_src);
|
|
}
|
|
|
|
void netdev_rx_queue_unlease(struct netdev_rx_queue *rxq_dst,
|
|
struct netdev_rx_queue *rxq_src)
|
|
{
|
|
netdev_assert_locked(rxq_dst->dev);
|
|
netdev_assert_locked(rxq_src->dev);
|
|
|
|
WRITE_ONCE(rxq_src->lease, NULL);
|
|
WRITE_ONCE(rxq_dst->lease, NULL);
|
|
|
|
netdev_put(rxq_src->dev, &rxq_src->lease_tracker);
|
|
}
|
|
|
|
bool netif_rxq_is_leased(struct net_device *dev, unsigned int rxq_idx)
|
|
{
|
|
if (rxq_idx < dev->real_num_rx_queues)
|
|
return READ_ONCE(__netif_get_rx_queue(dev, rxq_idx)->lease);
|
|
return false;
|
|
}
|
|
|
|
static bool netif_lease_dir_ok(const struct net_device *dev,
|
|
enum netif_lease_dir dir)
|
|
{
|
|
if (dir == NETIF_VIRT_TO_PHYS && !dev->dev.parent)
|
|
return true;
|
|
if (dir == NETIF_PHYS_TO_VIRT && dev->dev.parent)
|
|
return true;
|
|
return false;
|
|
}
|
|
|
|
struct netdev_rx_queue *
|
|
__netif_get_rx_queue_lease(struct net_device **dev, unsigned int *rxq_idx,
|
|
enum netif_lease_dir dir)
|
|
{
|
|
struct net_device *orig_dev = *dev;
|
|
struct netdev_rx_queue *rxq = __netif_get_rx_queue(orig_dev, *rxq_idx);
|
|
|
|
if (rxq->lease) {
|
|
if (!netif_lease_dir_ok(orig_dev, dir))
|
|
return NULL;
|
|
rxq = rxq->lease;
|
|
*rxq_idx = get_netdev_rx_queue_index(rxq);
|
|
*dev = rxq->dev;
|
|
}
|
|
return rxq;
|
|
}
|
|
|
|
bool netif_rx_queue_lease_get_owner(struct net_device **dev,
|
|
unsigned int *rxq_idx)
|
|
{
|
|
struct net_device *orig_dev = *dev;
|
|
struct netdev_rx_queue *rxq;
|
|
|
|
/* The physical device needs to be locked. If there is indeed a lease,
|
|
* then the virtual device holds a reference on the physical device
|
|
* and the lease stays active until the virtual device is torn down.
|
|
* When queues get {un,}leased both devices are always locked.
|
|
*/
|
|
netdev_ops_assert_locked(orig_dev);
|
|
rxq = __netif_get_rx_queue_lease(dev, rxq_idx, NETIF_PHYS_TO_VIRT);
|
|
if (rxq && orig_dev != *dev)
|
|
return true;
|
|
return false;
|
|
}
|
|
|
|
/* See also page_pool_is_unreadable() */
|
|
bool netif_rxq_has_unreadable_mp(struct net_device *dev, unsigned int rxq_idx)
|
|
{
|
|
if (rxq_idx < dev->real_num_rx_queues)
|
|
return __netif_get_rx_queue(dev, rxq_idx)->mp_params.mp_ops;
|
|
return false;
|
|
}
|
|
EXPORT_SYMBOL(netif_rxq_has_unreadable_mp);
|
|
|
|
bool netif_rxq_has_mp(struct net_device *dev, unsigned int rxq_idx)
|
|
{
|
|
if (rxq_idx < dev->real_num_rx_queues)
|
|
return __netif_get_rx_queue(dev, rxq_idx)->mp_params.mp_priv;
|
|
return false;
|
|
}
|
|
|
|
int netdev_rx_queue_restart(struct net_device *dev, unsigned int rxq_idx)
|
|
{
|
|
struct netdev_rx_queue *rxq = __netif_get_rx_queue(dev, rxq_idx);
|
|
const struct netdev_queue_mgmt_ops *qops = dev->queue_mgmt_ops;
|
|
void *new_mem, *old_mem;
|
|
int err;
|
|
|
|
if (!qops || !qops->ndo_queue_stop || !qops->ndo_queue_mem_free ||
|
|
!qops->ndo_queue_mem_alloc || !qops->ndo_queue_start)
|
|
return -EOPNOTSUPP;
|
|
|
|
netdev_assert_locked(dev);
|
|
|
|
new_mem = kvzalloc(qops->ndo_queue_mem_size, GFP_KERNEL);
|
|
if (!new_mem)
|
|
return -ENOMEM;
|
|
|
|
old_mem = kvzalloc(qops->ndo_queue_mem_size, GFP_KERNEL);
|
|
if (!old_mem) {
|
|
err = -ENOMEM;
|
|
goto err_free_new_mem;
|
|
}
|
|
|
|
err = qops->ndo_queue_mem_alloc(dev, new_mem, rxq_idx);
|
|
if (err)
|
|
goto err_free_old_mem;
|
|
|
|
err = page_pool_check_memory_provider(dev, rxq);
|
|
if (err)
|
|
goto err_free_new_queue_mem;
|
|
|
|
if (netif_running(dev)) {
|
|
err = qops->ndo_queue_stop(dev, old_mem, rxq_idx);
|
|
if (err)
|
|
goto err_free_new_queue_mem;
|
|
|
|
err = qops->ndo_queue_start(dev, new_mem, rxq_idx);
|
|
if (err)
|
|
goto err_start_queue;
|
|
} else {
|
|
swap(new_mem, old_mem);
|
|
}
|
|
|
|
qops->ndo_queue_mem_free(dev, old_mem);
|
|
|
|
kvfree(old_mem);
|
|
kvfree(new_mem);
|
|
|
|
return 0;
|
|
|
|
err_start_queue:
|
|
/* Restarting the queue with old_mem should be successful as we haven't
|
|
* changed any of the queue configuration, and there is not much we can
|
|
* do to recover from a failure here.
|
|
*
|
|
* WARN if we fail to recover the old rx queue, and at least free
|
|
* old_mem so we don't also leak that.
|
|
*/
|
|
if (qops->ndo_queue_start(dev, old_mem, rxq_idx)) {
|
|
WARN(1,
|
|
"Failed to restart old queue in error path. RX queue %d may be unhealthy.",
|
|
rxq_idx);
|
|
qops->ndo_queue_mem_free(dev, old_mem);
|
|
}
|
|
|
|
err_free_new_queue_mem:
|
|
qops->ndo_queue_mem_free(dev, new_mem);
|
|
|
|
err_free_old_mem:
|
|
kvfree(old_mem);
|
|
|
|
err_free_new_mem:
|
|
kvfree(new_mem);
|
|
|
|
return err;
|
|
}
|
|
EXPORT_SYMBOL_NS_GPL(netdev_rx_queue_restart, "NETDEV_INTERNAL");
|
|
|
|
int __net_mp_open_rxq(struct net_device *dev, unsigned int rxq_idx,
|
|
const struct pp_memory_provider_params *p,
|
|
struct netlink_ext_ack *extack)
|
|
{
|
|
struct netdev_rx_queue *rxq;
|
|
int ret;
|
|
|
|
if (!netdev_need_ops_lock(dev))
|
|
return -EOPNOTSUPP;
|
|
|
|
if (rxq_idx >= dev->real_num_rx_queues) {
|
|
NL_SET_ERR_MSG(extack, "rx queue index out of range");
|
|
return -ERANGE;
|
|
}
|
|
rxq_idx = array_index_nospec(rxq_idx, dev->real_num_rx_queues);
|
|
|
|
if (dev->cfg->hds_config != ETHTOOL_TCP_DATA_SPLIT_ENABLED) {
|
|
NL_SET_ERR_MSG(extack, "tcp-data-split is disabled");
|
|
return -EINVAL;
|
|
}
|
|
if (dev->cfg->hds_thresh) {
|
|
NL_SET_ERR_MSG(extack, "hds-thresh is not zero");
|
|
return -EINVAL;
|
|
}
|
|
if (dev_xdp_prog_count(dev)) {
|
|
NL_SET_ERR_MSG(extack, "unable to custom memory provider to device with XDP program attached");
|
|
return -EEXIST;
|
|
}
|
|
|
|
rxq = __netif_get_rx_queue(dev, rxq_idx);
|
|
if (rxq->mp_params.mp_ops) {
|
|
NL_SET_ERR_MSG(extack, "designated queue already memory provider bound");
|
|
return -EEXIST;
|
|
}
|
|
#ifdef CONFIG_XDP_SOCKETS
|
|
if (rxq->pool) {
|
|
NL_SET_ERR_MSG(extack, "designated queue already in use by AF_XDP");
|
|
return -EBUSY;
|
|
}
|
|
#endif
|
|
|
|
rxq->mp_params = *p;
|
|
ret = netdev_rx_queue_restart(dev, rxq_idx);
|
|
if (ret) {
|
|
rxq->mp_params.mp_ops = NULL;
|
|
rxq->mp_params.mp_priv = NULL;
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
int net_mp_open_rxq(struct net_device *dev, unsigned int rxq_idx,
|
|
struct pp_memory_provider_params *p)
|
|
{
|
|
int ret;
|
|
|
|
netdev_lock(dev);
|
|
ret = __net_mp_open_rxq(dev, rxq_idx, p, NULL);
|
|
netdev_unlock(dev);
|
|
return ret;
|
|
}
|
|
|
|
void __net_mp_close_rxq(struct net_device *dev, unsigned int ifq_idx,
|
|
const struct pp_memory_provider_params *old_p)
|
|
{
|
|
struct netdev_rx_queue *rxq;
|
|
int err;
|
|
|
|
if (WARN_ON_ONCE(ifq_idx >= dev->real_num_rx_queues))
|
|
return;
|
|
|
|
rxq = __netif_get_rx_queue(dev, ifq_idx);
|
|
|
|
/* Callers holding a netdev ref may get here after we already
|
|
* went thru shutdown via dev_memory_provider_uninstall().
|
|
*/
|
|
if (dev->reg_state > NETREG_REGISTERED &&
|
|
!rxq->mp_params.mp_ops)
|
|
return;
|
|
|
|
if (WARN_ON_ONCE(rxq->mp_params.mp_ops != old_p->mp_ops ||
|
|
rxq->mp_params.mp_priv != old_p->mp_priv))
|
|
return;
|
|
|
|
rxq->mp_params.mp_ops = NULL;
|
|
rxq->mp_params.mp_priv = NULL;
|
|
err = netdev_rx_queue_restart(dev, ifq_idx);
|
|
WARN_ON(err && err != -ENETDOWN);
|
|
}
|
|
|
|
void net_mp_close_rxq(struct net_device *dev, unsigned ifq_idx,
|
|
struct pp_memory_provider_params *old_p)
|
|
{
|
|
netdev_lock(dev);
|
|
__net_mp_close_rxq(dev, ifq_idx, old_p);
|
|
netdev_unlock(dev);
|
|
}
|