Files
linux/lib
Herbert Xu 9d4f8e54ce rhashtable: Fix rhashtable_try_insert test
The test on whether rhashtable_insert_one did an insertion relies
on the value returned by rhashtable_lookup_one.  Unfortunately that
value is overwritten after rhashtable_insert_one returns.  Fix this
by moving the test before data gets overwritten.

Simplify the test as only data == NULL matters.

Finally move atomic_inc back within the lock as otherwise it may
be reordered with the atomic_dec on the removal side, potentially
leading to an underflow.

Reported-by: Michael Kelley <mhklinux@outlook.com>
Fixes: e1d3422c95 ("rhashtable: Fix potential deadlock by moving schedule_work outside lock")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Tested-by: Michael Kelley <mhklinux@outlook.com>
Reviewed-by: Breno Leitao <leitao@debian.org>
Tested-by: Mikhail Zaslonko <zaslonko@linux.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
2025-01-19 12:44:28 +08:00
..
2024-07-12 16:39:53 -07:00
2024-02-01 13:06:40 +01:00
2023-02-02 22:50:01 -08:00
2023-02-02 22:50:01 -08:00
2022-10-03 14:03:21 -07:00
2024-04-25 21:07:05 -07:00
2023-08-21 13:46:25 -07:00
2023-04-17 18:01:23 +02:00
2023-10-16 12:44:06 -04:00
2024-10-14 16:33:24 -05:00
2023-10-16 12:44:06 -04:00
2022-10-03 17:34:32 -07:00
2024-07-04 23:43:10 -07:00
2024-02-15 12:17:28 -05:00
2024-06-10 11:14:52 +01:00
2024-11-30 22:41:35 -05:00