Frank Liang
8da901ffe4
net/ena: fix missing lock when update devlink params
Fix assert lock warning while calling devl_param_driverinit_value_set()
in ena.
WARNING: net/devlink/core.c:261 at devl_assert_locked+0x62/0x90, CPU#0: kworker/0:0/9
CPU: 0 UID: 0 PID: 9 Comm: kworker/0:0 Not tainted 6.19.0-rc2+ #1 PREEMPT(lazy)
Hardware name: Amazon EC2 m8i-flex.4xlarge/, BIOS 1.0 10/16/2017
Workqueue: events work_for_cpu_fn
RIP: 0010:devl_assert_locked+0x62/0x90
Call Trace:
<TASK>
devl_param_driverinit_value_set+0x15/0x1c0
ena_devlink_alloc+0x18c/0x220 [ena]
? __pfx_ena_devlink_alloc+0x10/0x10 [ena]
? trace_hardirqs_on+0x18/0x140
? lockdep_hardirqs_on+0x8c/0x130
? __raw_spin_unlock_irqrestore+0x5d/0x80
? __raw_spin_unlock_irqrestore+0x46/0x80
? devm_ioremap_wc+0x9a/0xd0
ena_probe+0x4d2/0x1b20 [ena]
? __lock_acquire+0x56a/0xbd0
? __pfx_ena_probe+0x10/0x10 [ena]
? local_clock+0x15/0x30
? __lock_release.isra.0+0x1c9/0x340
? mark_held_locks+0x40/0x70
? lockdep_hardirqs_on_prepare.part.0+0x92/0x170
? trace_hardirqs_on+0x18/0x140
? lockdep_hardirqs_on+0x8c/0x130
? __raw_spin_unlock_irqrestore+0x5d/0x80
? __raw_spin_unlock_irqrestore+0x46/0x80
? __pfx_ena_probe+0x10/0x10 [ena]
......
</TASK>
Fixes: 816b52624c ("net: ena: Control PHC enable through devlink")
Signed-off-by: Frank Liang <xiliang@redhat.com>
Reviewed-by: David Arinzon <darinzon@amazon.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://patch.msgid.link/20251231145808.6103-1-xiliang@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2026-01-04 10:42:11 -08:00
..
2025-12-15 13:00:03 -06:00
2025-12-15 13:00:33 +01:00
2025-12-05 17:29:04 -08:00
2025-12-06 18:34:24 -08:00
2025-12-16 14:23:10 +09:00
2025-11-25 12:39:26 +01:00
2025-12-16 12:58:57 +01:00
2025-12-26 11:44:35 -08:00
2025-12-19 17:23:18 -05:00
2025-12-06 18:34:24 -08:00
2025-11-21 18:42:02 +00:00
2025-12-06 18:34:24 -08:00
2025-12-08 09:38:52 +09:00
2025-12-05 17:29:04 -08:00
2025-12-06 18:34:24 -08:00
2025-12-16 07:59:30 -06:00
2025-12-05 17:29:04 -08:00
2025-12-19 14:47:46 +08:00
2025-12-05 17:47:59 -08:00
2025-12-05 13:52:43 -08:00
2025-11-26 13:58:59 +09:00
2025-11-27 18:11:43 -08:00
2025-12-09 06:35:53 +09:00
2025-12-04 18:42:48 -08:00
2025-11-25 19:20:42 -08:00
2025-12-06 09:01:27 -08:00
2025-12-26 22:04:03 +09:00
2025-12-24 21:32:57 +01:00
2025-11-20 16:44:04 +01:00
2025-11-26 14:28:19 +01:00
2025-12-13 16:36:57 +12:00
2025-12-27 16:00:47 +10:00
2025-11-26 14:40:59 +01:00
2025-12-21 15:21:10 -08:00
2025-12-09 06:10:17 +09:00
2025-12-19 08:44:22 -08:00
2025-12-06 18:34:24 -08:00
2025-12-17 00:28:51 +01:00
2025-12-12 23:59:39 +01:00
2025-12-06 18:34:24 -08:00
2025-12-04 18:54:37 -08:00
2025-12-21 15:21:10 -08:00
2025-12-21 14:41:29 -08:00
2025-12-14 06:07:09 +12:00
2025-12-05 17:29:04 -08:00
2025-12-05 17:29:04 -08:00
2025-11-28 09:47:44 -06:00
2025-12-14 15:35:35 +12:00
2025-12-06 08:27:07 -08:00
2025-12-05 17:29:04 -08:00
2025-12-04 15:18:33 -08:00
2025-12-19 15:09:09 +00:00
2025-12-17 14:14:51 +01:00
2025-12-09 08:50:27 +09:00
2025-11-26 15:09:30 +01:00
2026-01-04 10:42:11 -08:00
2025-12-11 01:40:00 -08:00
2025-12-06 09:32:25 -08:00
2025-12-09 08:53:24 +09:00
2025-12-06 18:34:24 -08:00
2025-12-16 07:59:30 -06:00
2025-12-19 13:56:17 +01:00
2025-12-13 16:29:22 +12:00
2025-12-06 18:34:24 -08:00
2025-12-02 17:03:55 -08:00
2025-11-20 22:38:38 +05:30
2025-12-09 06:45:00 +09:00
2025-12-10 06:38:17 +09:00
2025-12-04 13:50:39 -08:00
2025-12-05 17:29:04 -08:00
2025-12-17 17:24:28 +01:00
2025-12-03 12:42:36 -08:00
2025-12-03 17:24:33 -08:00
2025-12-13 16:41:50 +12:00
2025-12-04 17:10:08 -08:00
2025-12-24 11:31:29 +00:00
2025-11-29 15:20:23 -06:00
2025-12-08 09:38:52 +09:00
2025-11-26 10:16:10 -06:00
2025-12-13 17:09:06 +12:00
2025-12-07 16:15:19 +01:00
2025-12-16 21:24:28 -05:00
2025-12-03 17:24:33 -08:00
2025-12-06 09:01:27 -08:00
2025-12-08 12:37:27 +05:30
2025-12-23 15:18:22 +00:00
2025-12-06 18:52:00 -08:00
2025-12-14 15:35:35 +12:00
2025-11-21 21:27:20 +01:00
2025-12-15 12:47:39 +01:00
2025-12-06 18:42:12 -08:00
2025-12-23 11:55:16 +01:00
2025-12-16 22:24:36 -05:00
2025-11-26 15:10:39 +01:00
2025-12-23 15:59:03 +01:00
2025-12-05 13:52:43 -08:00
2025-12-04 19:42:53 -08:00
2025-12-24 08:02:57 -05:00
2025-12-06 15:41:26 -08:00
2025-12-04 17:34:16 -08:00
2025-11-27 02:03:07 -05:00
2025-12-06 10:00:49 -08:00
2025-12-06 10:49:19 -08:00
2025-12-06 18:52:00 -08:00
2025-12-06 18:52:00 -08:00