lyndonli
8879ec6dfd
drm/amdgpu: Fix the warning info when removing amdgpu device
Actually, the drm_dev_enter in psp_cmd_submit_buf does not
protect anything. If DRM device is unplugged, it will always
check the condition in WARN_ON. So drop drm_dev_enter and
drm_dev_exit in psp_cmd_submit_buf.
When removing amdgpu, the calling order is as follows:
amdgpu_pci_remove
drm_dev_unplug
amdgpu_driver_unload_kms
amdgpu_device_fini_hw
amdgpu_device_ip_fini_early
psp_hw_fini
psp_ras_terminate
psp_ta_unloadye
psp_cmd_submit_buf
[ 4507.740388] Call Trace:
[ 4507.740389] <TASK>
[ 4507.740391] psp_ta_unload+0x44/0x70 [amdgpu]
[ 4507.740485] psp_ras_terminate+0x4d/0x70 [amdgpu]
[ 4507.740575] psp_hw_fini+0x28/0xa0 [amdgpu]
[ 4507.740662] amdgpu_device_fini_hw+0x328/0x442 [amdgpu]
[ 4507.740791] amdgpu_driver_unload_kms+0x51/0x60 [amdgpu]
[ 4507.740875] amdgpu_pci_remove+0x5a/0x140 [amdgpu]
[ 4507.740962] ? _raw_spin_unlock_irqrestore+0x27/0x43
[ 4507.740965] ? __pm_runtime_resume+0x60/0x90
[ 4507.740968] pci_device_remove+0x39/0xb0
[ 4507.740971] device_remove+0x46/0x70
[ 4507.740972] device_release_driver_internal+0xd1/0x160
[ 4507.740974] driver_detach+0x4a/0x90
[ 4507.740975] bus_remove_driver+0x6c/0xf0
[ 4507.740976] driver_unregister+0x31/0x50
[ 4507.740977] pci_unregister_driver+0x40/0x90
[ 4507.740978] amdgpu_exit+0x15/0x120 [amdgpu]
v2: fix commit message style issue
Signed-off-by: lyndonli <Lyndon.Li@amd.com>
Reviewed-by: Guchun Chen <guchun.chen@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
2023-03-09 22:06:19 -05:00
..
2023-03-09 22:06:19 -05:00
2023-01-18 09:25:30 +01:00
2023-02-21 13:26:18 +01:00
2023-01-18 09:25:31 +01:00
2023-02-22 18:28:03 -08:00
2022-12-12 12:30:56 +00:00
2023-02-22 18:28:03 -08:00
2023-03-07 15:54:18 -05:00
2023-02-23 17:09:35 -08:00
2023-02-23 17:09:35 -08:00
2022-12-14 12:20:00 -08:00
2023-02-23 17:09:35 -08:00
2023-01-06 16:15:08 -03:00
2023-01-10 11:15:44 +01:00
2023-01-17 13:41:27 +00:00
2023-01-24 17:36:29 +01:00
2023-03-02 15:08:54 -08:00
2023-01-10 16:26:06 +02:00
2023-01-18 09:25:31 +01:00
2023-01-18 09:25:31 +01:00
2022-11-24 11:05:43 +10:00
2023-01-18 09:25:31 +01:00
2022-11-05 17:12:04 +01:00
2023-02-23 17:09:35 -08:00
2023-01-31 12:23:23 +01:00
2023-01-10 11:15:44 +01:00
2023-03-02 15:08:54 -08:00
2023-01-10 11:04:56 +01:00
2023-03-07 05:42:34 +10:00
2023-03-02 15:08:54 -08:00
2023-02-22 18:28:03 -08:00
2023-01-31 12:23:23 +01:00
2022-11-05 17:12:04 +01:00
2022-12-19 09:50:06 +01:00
2023-03-01 22:37:25 -05:00
2023-01-30 13:49:56 +10:00
2023-02-23 17:09:35 -08:00
2023-02-09 16:16:44 +10:00
2023-01-18 09:25:32 +01:00
2023-02-22 18:28:03 -08:00
2023-01-18 09:25:32 +01:00
2022-12-14 12:20:00 -08:00
2022-11-05 17:12:04 +01:00
2023-01-18 09:25:32 +01:00
2023-02-24 13:40:13 -08:00
2023-01-31 12:23:23 +01:00
2023-01-18 09:25:32 +01:00
2022-12-12 13:07:02 +00:00
2023-03-07 05:42:34 +10:00
2023-02-23 17:09:35 -08:00
2022-11-05 17:12:04 +01:00
2023-01-18 09:25:32 +01:00
2023-01-03 18:16:01 -01:00
2023-01-18 09:25:32 +01:00
2023-02-22 18:28:03 -08:00
2023-02-23 17:09:35 -08:00
2023-01-12 09:46:19 -01:00
2023-02-23 17:09:35 -08:00
2023-02-09 16:51:39 -08:00
2022-11-16 07:17:32 +10:00
2022-09-12 09:34:07 +02:00
2022-11-08 17:10:27 +01:00
2023-01-19 09:16:04 +01:00
2022-11-24 12:42:39 +01:00
2023-03-07 15:55:18 -05:00
2023-01-10 16:14:13 +01:00
2023-01-05 15:08:10 +01:00
2022-12-08 09:56:57 +01:00
2023-01-12 13:50:28 +01:00
2023-01-13 09:22:02 +01:00
2022-11-24 12:42:40 +01:00
2023-02-22 18:28:03 -08:00
2022-08-04 15:24:46 +02:00
2023-01-19 10:53:24 +02:00
2023-01-13 09:22:02 +01:00
2022-11-05 17:12:04 +01:00
2022-10-26 09:53:56 +03:00
2022-09-13 14:38:33 +03:00
2023-01-10 09:57:05 -03:00
2023-01-04 14:59:25 +01:00
2022-11-16 14:54:44 +02:00
2023-01-23 11:46:50 +02:00
2022-08-03 18:32:27 +02:00
2023-02-21 13:26:18 +01:00
2023-02-21 13:26:18 +01:00
2023-01-16 15:33:28 +10:00
2023-01-23 15:02:41 +01:00
2022-11-23 20:34:46 +01:00
2022-12-22 14:58:21 -03:00
2022-12-05 13:35:37 +01:00
2023-02-23 17:09:35 -08:00
2022-11-05 17:12:04 +01:00
2023-03-02 15:08:54 -08:00
2022-12-06 12:54:14 +01:00
2022-12-22 14:58:21 -03:00
2023-02-23 17:09:35 -08:00
2022-12-22 14:58:55 -03:00
2023-01-03 18:20:57 +01:00
2023-01-03 18:20:57 +01:00
2023-01-18 09:25:30 +01:00
2022-12-14 14:57:09 +01:00
2023-02-24 12:58:55 -08:00
2022-12-22 14:58:55 -03:00
2023-01-13 13:18:35 +01:00
2022-09-20 09:42:31 +02:00
2023-02-15 10:46:05 +01:00
2023-01-18 09:25:30 +01:00
2023-01-04 16:12:15 +00:00
2022-11-11 23:49:47 +03:00
2022-09-24 15:02:02 +02:00
2023-02-07 15:07:52 +01:00
2022-10-24 09:27:04 +02:00
2022-12-05 13:35:37 +01:00
2022-12-16 03:54:54 -08:00
2023-02-09 16:51:39 -08:00
2023-01-19 14:16:55 +01:00
2023-02-22 18:28:03 -08:00
2023-01-24 17:36:29 +01:00