Namjae Jeon
864fb5d371
ksmbd: fix possible deadlock in smb2_open
[ 8743.393379] ======================================================
[ 8743.393385] WARNING: possible circular locking dependency detected
[ 8743.393391] 6.4.0-rc1+ #11 Tainted: G OE
[ 8743.393397] ------------------------------------------------------
[ 8743.393402] kworker/0:2/12921 is trying to acquire lock:
[ 8743.393408] ffff888127a14460 (sb_writers#8){.+.+}-{0:0}, at: ksmbd_vfs_setxattr+0x3d/0xd0 [ksmbd]
[ 8743.393510]
but task is already holding lock:
[ 8743.393515] ffff8880360d97f0 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: ksmbd_vfs_kern_path_locked+0x181/0x670 [ksmbd]
[ 8743.393618]
which lock already depends on the new lock.
[ 8743.393623]
the existing dependency chain (in reverse order) is:
[ 8743.393628]
-> #1 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}:
[ 8743.393648] down_write_nested+0x9a/0x1b0
[ 8743.393660] filename_create+0x128/0x270
[ 8743.393670] do_mkdirat+0xab/0x1f0
[ 8743.393680] __x64_sys_mkdir+0x47/0x60
[ 8743.393690] do_syscall_64+0x5d/0x90
[ 8743.393701] entry_SYSCALL_64_after_hwframe+0x72/0xdc
[ 8743.393711]
-> #0 (sb_writers#8){.+.+}-{0:0}:
[ 8743.393728] __lock_acquire+0x2201/0x3b80
[ 8743.393737] lock_acquire+0x18f/0x440
[ 8743.393746] mnt_want_write+0x5f/0x240
[ 8743.393755] ksmbd_vfs_setxattr+0x3d/0xd0 [ksmbd]
[ 8743.393839] ksmbd_vfs_set_dos_attrib_xattr+0xcc/0x110 [ksmbd]
[ 8743.393924] compat_ksmbd_vfs_set_dos_attrib_xattr+0x39/0x50 [ksmbd]
[ 8743.394010] smb2_open+0x3432/0x3cc0 [ksmbd]
[ 8743.394099] handle_ksmbd_work+0x2c9/0x7b0 [ksmbd]
[ 8743.394187] process_one_work+0x65a/0xb30
[ 8743.394198] worker_thread+0x2cf/0x700
[ 8743.394209] kthread+0x1ad/0x1f0
[ 8743.394218] ret_from_fork+0x29/0x50
This patch add mnt_want_write() above parent inode lock and remove
nested mnt_want_write calls in smb2_open().
Fixes: 40b268d384 ("ksmbd: add mnt_want_write to ksmbd vfs functions")
Cc: stable@vger.kernel.org
Reported-by: Marios Makassikis <mmakassikis@freebox.fr>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
2023-11-23 20:50:45 -06:00
..
2023-11-04 09:20:04 -10:00
2023-10-18 13:26:18 +02:00
2023-11-07 12:11:26 -08:00
2023-11-01 15:28:33 -10:00
2023-10-30 09:47:13 -10:00
2023-11-16 16:57:19 -05:00
2023-11-07 12:11:26 -08:00
2023-10-18 13:26:19 +02:00
2023-11-13 09:09:12 -08:00
2023-08-29 14:25:26 -07:00
2023-11-10 09:52:56 -08:00
2023-10-18 13:26:19 +02:00
2023-10-18 13:26:19 +02:00
2023-10-30 09:47:13 -10:00
2023-11-02 16:15:30 -10:00
2023-11-03 15:15:47 -10:00
2023-10-18 13:26:20 +02:00
2023-10-12 15:21:00 -05:00
2023-10-09 16:24:17 +02:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-03 22:24:11 +09:00
2023-10-28 16:16:19 +02:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-01-30 12:51:54 +00:00
2023-11-07 12:11:26 -08:00
2023-11-07 11:54:17 -08:00
2023-10-30 09:47:13 -10:00
2023-10-30 09:47:13 -10:00
2023-10-18 14:08:22 +02:00
2023-10-18 14:08:22 +02:00
2023-11-07 12:11:26 -08:00
2023-11-02 19:38:47 -10:00
2023-10-18 14:08:22 +02:00
2023-11-02 19:38:47 -10:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-03 15:15:47 -10:00
2023-10-16 12:44:04 -04:00
2023-10-18 14:08:23 +02:00
2023-09-18 12:03:46 -07:00
2023-11-08 13:39:16 -08:00
2023-04-13 13:13:52 -07:00
2023-11-18 11:23:32 -08:00
2023-11-02 19:38:47 -10:00
2023-08-31 12:07:34 -05:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-07 12:11:26 -08:00
2023-11-02 20:53:31 -10:00
2023-10-18 14:08:25 +02:00
2023-10-18 14:08:25 +02:00
2023-10-30 09:47:13 -10:00
2023-11-14 08:09:36 +02:00
2023-11-02 20:53:31 -10:00
2023-10-30 19:26:39 -10:00
2023-10-18 14:08:26 +02:00
2023-10-18 14:08:26 +02:00
2023-11-02 19:38:47 -10:00
2023-10-18 14:08:26 +02:00
2023-11-02 19:38:47 -10:00
2023-10-30 09:47:13 -10:00
2023-11-23 20:50:45 -06:00
2023-11-07 12:11:26 -08:00
2023-10-05 13:42:11 +02:00
2023-10-18 14:08:28 +02:00
2023-11-03 07:41:18 -10:00
2023-11-05 08:28:32 -10:00
2023-11-02 08:19:51 -10:00
2023-11-07 12:11:26 -08:00
2023-04-13 13:13:54 -07:00
2023-10-18 14:08:29 +02:00
2023-08-20 10:33:43 -07:00
2023-11-13 09:11:41 +05:30
2023-10-18 14:08:29 +02:00
2023-09-20 14:22:01 +02:00
2023-10-18 14:43:23 -07:00
2023-10-18 13:26:15 +02:00
2023-10-18 13:26:15 +02:00
2023-10-30 19:28:19 -10:00
2022-03-03 20:38:56 -08:00
2023-10-03 19:48:44 -07:00
2022-04-22 10:57:18 -07:00
2023-10-30 19:28:19 -10:00
2023-11-02 20:53:31 -10:00
2023-11-02 20:53:31 -10:00
2022-03-03 20:38:56 -08:00
2023-06-26 09:50:21 -07:00
2023-05-17 09:16:59 +02:00
2023-10-04 10:32:20 -07:00
2023-11-02 20:53:31 -10:00
2023-10-18 14:43:23 -07:00
2023-08-18 10:12:11 -07:00
2023-07-11 11:41:34 +02:00
2023-10-18 14:43:23 -07:00
2023-10-04 10:32:20 -07:00
2023-10-18 14:43:23 -07:00
2023-10-24 17:57:45 +02:00
2023-11-02 20:53:31 -10:00
2023-10-25 22:17:04 +02:00
2023-10-12 18:53:36 +03:00
2022-12-01 10:46:54 -05:00
2023-08-21 13:46:25 -07:00
2023-10-30 09:14:19 -10:00
2023-09-22 14:09:06 +02:00
2023-10-19 11:02:47 +02:00
2023-11-02 20:53:31 -10:00
2023-10-19 11:03:15 +02:00
2023-08-28 11:04:18 -07:00
2023-11-01 15:28:33 -10:00
2023-08-23 14:17:43 -07:00
2023-08-19 12:12:12 +02:00
2023-11-07 12:11:26 -08:00
2023-11-02 20:53:31 -10:00
2023-10-22 17:08:07 -04:00
2023-10-04 10:32:25 -07:00
2023-11-03 23:28:33 +01:00
2022-07-05 16:18:21 -04:00
2023-10-25 16:47:10 -07:00
2023-10-30 09:14:19 -10:00
2023-11-02 20:53:31 -10:00
2023-10-18 13:26:15 +02:00
2023-10-19 11:03:15 +02:00
2023-11-02 20:53:31 -10:00
2023-05-19 04:30:22 +02:00
2023-05-19 04:30:22 +02:00
2023-07-13 10:28:04 +02:00
2023-05-24 08:42:16 -06:00
2023-08-15 08:32:45 +02:00
2023-08-06 15:08:35 +02:00
2023-05-24 11:03:59 +02:00
2022-11-25 13:01:55 -05:00
2023-08-29 14:25:26 -07:00
2023-10-18 13:26:15 +02:00
2023-10-18 13:26:15 +02:00
2023-05-17 15:20:17 +02:00
2023-11-07 11:46:31 -08:00
2022-04-26 13:36:25 -07:00
2023-05-23 21:43:26 -07:00
2023-11-02 20:53:31 -10:00
2023-02-20 11:53:11 -08:00
2023-10-09 16:24:16 +02:00