Files
linux/drivers/net
Eric Dumazet 78c29bd95b forcedeth: Fix NAPI race.
Eric Dumazet a écrit :
> Ingo Molnar a écrit :
>>> The following changes since commit 5298976562:
>>>   Linus Torvalds (1):
>>>         Merge git://git.kernel.org/.../davem/net-2.6
>>>
>>> are available in the git repository at:
>>>
>>>   master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git master
>> Hm, something in this lot quickly wrecked networking here - see the
>> tx timeout dump below. It starts with:
>>
>> [  351.004596] WARNING: at net/sched/sch_generic.c:246 dev_watchdog+0x10b/0x19c()
>> [  351.011815] Hardware name: System Product Name
>> [  351.016220] NETDEV WATCHDOG: eth0 (forcedeth): transmit queue 0 timed out
>>
>> Config attached. Unfortunately i've got no time to do bisection
>> today.
>
>
>
> forcedeth might have a problem, in its netif_wake_queue() logic, but
> I could not see why a recent patch could make this problem visible now.
>
> CPU0/1: AMD Athlon(tm) 64 X2 Dual Core Processor 3800+ stepping 02
> is not a new cpu either :)
>
> forcedeth uses an internal tx_stop without appropriate barrier.
>
> Could you try following patch ?
>
> (random guess as I dont have much time right now)

We might have a race in napi_schedule(), leaving interrupts disabled forever.
I cannot test this patch, I dont have the hardware...

Tested-by: Ingo Molnar <mingo@elte.hu>

Signed-off-by: David S. Miller <davem@davemloft.net>
2009-07-05 18:03:33 -07:00
..
2009-06-11 17:23:24 -07:00
2009-06-13 23:29:04 -07:00
2009-04-13 15:16:33 -07:00
2009-06-11 02:47:13 -07:00
2009-04-28 02:05:21 -07:00
2009-06-08 00:21:48 -07:00
2009-07-05 18:03:27 -07:00
2009-07-03 19:10:51 -07:00
2009-06-30 19:46:48 -07:00
2009-05-26 20:35:02 -07:00
…
2009-05-26 20:35:02 -07:00
…
…
2009-05-26 20:35:02 -07:00
2009-05-26 20:35:03 -07:00
…
…
…
…
2009-04-24 04:45:33 -07:00
2009-05-17 11:59:51 -07:00
…
2009-05-29 01:46:27 -07:00
…
…
2009-04-11 02:53:46 -07:00
…
…
…
2009-04-16 02:20:06 -07:00
…
2009-04-04 16:51:14 -07:00
2009-03-02 22:32:48 -08:00
2009-02-15 23:32:01 -08:00
2009-02-15 23:32:01 -08:00
2009-02-15 23:32:01 -08:00
2009-03-02 22:32:43 -08:00
…
2009-06-21 11:00:33 -05:00
…
…
…
…
…
2009-05-29 01:46:27 -07:00
…
…
…
2009-01-21 14:33:50 -08:00
…
…
2009-04-16 02:34:48 -07:00
2009-07-05 18:03:33 -07:00
2009-02-04 16:43:44 -08:00
…
2009-02-26 21:02:19 -08:00
…
2009-04-16 02:20:08 -07:00
…
…
…
2009-05-17 15:19:36 -07:00
…
2009-06-11 17:23:24 -07:00
2009-05-29 01:46:27 -07:00
2009-05-29 01:51:22 -07:00
2009-06-08 00:20:20 -07:00
2009-03-27 00:46:48 -07:00
2009-04-16 02:20:15 -07:00
…
…
…
2009-04-16 02:20:16 -07:00
2009-04-13 15:16:26 -07:00
2009-06-25 20:06:34 -07:00
…
2009-04-16 02:20:18 -07:00
2009-04-16 02:20:21 -07:00
…
…
2009-04-16 02:20:22 -07:00
2009-03-27 00:46:53 -07:00
…
…
2009-03-28 23:37:27 -07:00
…
2009-06-18 00:29:08 -07:00
2009-06-22 11:32:24 -07:00
2009-06-22 11:32:24 -07:00
2009-06-03 02:51:04 -07:00
…
2009-05-27 15:46:53 -07:00
2009-06-19 01:12:52 -07:00
2009-04-16 02:20:24 -07:00
…
2009-04-29 17:32:34 -07:00
…
2009-04-16 02:20:25 -07:00
…
2009-05-25 22:49:56 -07:00
…
2009-05-29 01:46:27 -07:00
…
2009-06-26 09:28:42 -07:00
2009-06-17 18:46:54 -07:00
…
…
…
2009-04-16 02:20:25 -07:00
…
2009-03-27 00:46:48 -07:00
…
…
…
…
…
…
…
2009-03-20 00:51:22 -07:00
…
2009-06-08 00:21:48 -07:00
…
2009-07-05 18:03:18 -07:00
…
2009-04-13 15:16:21 -07:00
2009-05-29 01:46:27 -07:00
2009-01-21 14:02:31 -08:00