Brian Foster 763e4cdc0f
iomap: support partial page discard on writeback block mapping failure ...
iomap writeback mapping failure only calls into ->discard_page() if
the current page has not been added to the ioend. Accordingly, the
XFS callback assumes a full page discard and invalidation. This is
problematic for sub-page block size filesystems where some portion
of a page might have been mapped successfully before a failure to
map a delalloc block occurs. ->discard_page() is not called in that
error scenario and the bio is explicitly failed by iomap via the
error return from ->prepare_ioend(). As a result, the filesystem
leaks delalloc blocks and corrupts the filesystem block counters.
Since XFS is the only user of ->discard_page(), tweak the semantics
to invoke the callback unconditionally on mapping errors and provide
the file offset that failed to map. Update xfs_discard_page() to
discard the corresponding portion of the file and pass the range
along to iomap_invalidatepage(). The latter already properly handles
both full and sub-page scenarios by not changing any iomap or page
state on sub-page invalidations.
Signed-off-by: Brian Foster <bfoster@redhat.com >
Reviewed-by: Christoph Hellwig <hch@lst.de >
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com >
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com >
2020-11-04 08:52:46 -08:00
2020-10-24 12:26:05 -07:00
2020-10-24 12:26:05 -07:00
2020-10-24 12:26:05 -07:00
2020-10-16 15:22:41 -07:00
2020-10-16 11:11:22 -07:00
2020-09-18 16:45:50 -04:00
2020-09-18 16:45:50 -04:00
2020-10-13 12:12:44 -07:00
2020-07-08 08:27:56 +02:00
2020-10-24 12:26:05 -07:00
2020-10-23 23:41:49 -05:00
2020-05-05 09:22:21 -06:00
2020-10-16 11:11:19 -07:00
2020-09-18 16:45:50 -04:00
2020-09-28 14:44:51 -07:00
2020-09-04 18:12:52 +02:00
2020-10-15 18:42:13 -07:00
2020-08-07 11:33:22 -07:00
2020-09-25 23:29:04 +02:00
2020-09-18 16:45:50 -04:00
2020-10-24 12:26:05 -07:00
2020-10-24 12:26:05 -07:00
2020-10-24 12:26:05 -07:00
2020-10-24 12:26:05 -07:00
2020-10-24 12:26:05 -07:00
2020-09-18 16:45:50 -04:00
2020-06-03 16:27:18 -07:00
2020-10-19 14:28:30 -07:00
2020-10-23 15:47:38 +02:00
2020-09-18 16:45:50 -04:00
2020-10-24 12:26:05 -07:00
2020-03-29 23:23:00 +02:00
2020-09-18 16:45:50 -04:00
2020-08-12 10:57:56 -07:00
2020-11-04 08:52:46 -08:00
2020-09-18 16:45:50 -04:00
2020-10-21 23:22:37 -04:00
2020-08-23 17:36:59 -05:00
2020-09-21 08:59:26 -07:00
2020-07-27 23:15:48 +02:00
2020-10-22 09:44:27 -07:00
2020-09-18 16:45:50 -04:00
2020-10-22 09:44:27 -07:00
2020-10-21 10:31:20 -04:00
2020-10-22 09:44:27 -07:00
2020-10-24 12:26:05 -07:00
2020-06-14 01:57:21 +09:00
2020-10-18 09:27:09 -07:00
2020-10-24 12:26:05 -07:00
2020-10-22 10:31:08 -07:00
2020-09-22 23:39:45 -04:00
2020-08-04 15:01:58 -04:00
2020-10-06 15:38:15 +02:00
2020-10-22 09:59:21 -07:00
2020-08-23 17:36:59 -05:00
2020-09-18 16:45:50 -04:00
2020-09-18 16:45:50 -04:00
2020-10-15 14:56:15 -07:00
2020-10-16 11:11:22 -07:00
2020-10-01 11:15:31 +02:00
2020-10-24 12:26:05 -07:00
2020-10-24 12:26:05 -07:00
2020-10-02 12:02:30 +02:00
2020-09-18 16:45:50 -04:00
2020-10-18 09:56:50 -07:00
2020-10-24 12:26:05 -07:00
2020-10-24 12:26:05 -07:00
2020-09-10 14:03:31 -07:00
2020-10-15 15:11:56 -07:00
2020-07-21 16:02:41 -07:00
2020-11-04 08:52:46 -08:00
2020-10-24 12:26:05 -07:00
2020-10-12 16:35:51 -07:00
2020-06-03 23:16:55 -04:00
2020-05-07 16:55:47 -05:00
2020-10-16 11:11:21 -07:00
2020-10-18 09:27:09 -07:00
2020-06-04 19:18:29 -07:00
2020-08-24 08:49:13 +10:00
2020-06-04 19:18:29 -07:00
2020-06-04 19:18:29 -07:00
2020-10-05 10:38:33 -06:00
2020-10-18 09:27:09 -07:00
2020-05-14 16:44:23 +02:00
2020-06-05 13:45:21 -07:00
2020-10-16 11:11:21 -07:00
2020-10-14 14:54:45 -07:00
2020-10-19 14:28:30 -07:00
2020-07-29 16:14:27 +02:00
2020-10-15 15:03:10 -07:00
2020-04-27 02:07:40 -04:00
2020-05-06 22:33:43 -04:00
2020-09-24 19:41:58 -04:00
2020-10-16 12:21:15 -07:00
2020-08-23 17:36:59 -05:00
2020-10-17 15:05:30 -06:00
2020-09-30 20:32:32 -06:00
2020-04-10 15:36:22 -07:00
2020-08-23 17:36:59 -05:00
2020-10-13 18:38:27 -07:00
2020-07-29 16:14:27 +02:00
2020-10-13 12:12:44 -07:00
2020-08-23 17:36:59 -05:00
2020-08-04 21:02:38 -04:00
2020-10-16 11:11:15 -07:00
2020-09-22 23:45:57 -04:00
2020-10-24 12:40:18 -07:00
2020-10-22 09:02:50 -06:00
2020-10-20 16:03:13 -06:00
2020-07-31 08:16:01 +02:00
2020-08-07 11:33:24 -07:00
2020-06-14 01:57:21 +09:00
2020-10-05 13:37:04 +02:00
2020-09-10 14:03:31 -07:00
2020-08-23 17:36:59 -05:00
2020-10-23 11:33:41 -07:00
2020-05-14 16:44:24 +02:00
2020-06-02 10:59:07 -07:00
2020-10-24 12:26:05 -07:00
2020-10-24 12:26:05 -07:00
2020-05-13 11:41:22 +02:00
2020-08-12 10:58:01 -07:00
2020-10-11 11:11:35 -07:00
2020-04-27 10:37:14 -04:00
2020-06-08 11:04:19 -07:00
2020-08-27 16:06:47 -04:00
2020-10-23 11:33:41 -07:00
2020-07-31 08:16:00 +02:00
2020-10-15 09:48:49 -07:00
2020-05-29 19:10:42 -04:00
2020-08-23 17:36:59 -05:00
2020-08-23 17:36:59 -05:00
2020-10-24 12:40:18 -07:00
2020-09-26 22:55:05 -04:00
2020-08-27 16:06:47 -04:00
2020-09-24 13:43:39 -06:00
2020-06-09 15:40:50 -07:00
2020-10-16 11:11:22 -07:00
2020-07-31 08:16:01 +02:00
2020-10-13 18:38:27 -07:00
763e4cdc0f