Alexander Lobakin
75eaf63ea7
net: skbuff: don't include <net/page_pool/types.h> to <linux/skbuff.h>
...
Currently, touching <net/page_pool/types.h> triggers a rebuild of more
than half of the kernel. That's because it's included in
<linux/skbuff.h>. And each new include to page_pool/types.h adds more
[useless] data for the toolchain to process per each source file from
that pile.
In commit 6a5bcd84e8 ("page_pool: Allow drivers to hint on SKB
recycling"), Matteo included it to be able to call a couple of functions
defined there. Then, in commit 57f05bc2ab ("page_pool: keep pp info as
long as page pool owns the page") one of the calls was removed, so only
one was left. It's the call to page_pool_return_skb_page() in
napi_frag_unref(). The function is external and doesn't have any
dependencies. Having very niche page_pool_types.h included only for that
looks like an overkill.
As %PP_SIGNATURE is not local to page_pool.c (was only in the
early submissions), nothing holds this function there. Teleport
page_pool_return_skb_page() to skbuff.c, just next to the main consumer,
skb_pp_recycle(), and rename it to napi_pp_put_page(), as it doesn't
work with skbs at all and the former name tells nothing. The #if guards
here are only to not compile and have it in the vmlinux when not needed
-- both call sites are already guarded.
Now, touching page_pool_types.h only triggers rebuilding of the drivers
using it and a couple of core networking files.
Suggested-by: Jakub Kicinski <kuba@kernel.org > # make skbuff.h less heavy
Suggested-by: Alexander Duyck <alexanderduyck@fb.com > # move to skbuff.c
Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com >
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com >
Link: https://lore.kernel.org/r/20230804180529.2483231-3-aleksander.lobakin@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org >
2023-08-07 13:05:53 -07:00
..
2023-03-27 02:33:48 +00:00
2023-07-20 11:25:24 -07:00
2021-07-01 13:19:48 -07:00
2021-11-19 11:52:25 +00:00
2023-08-06 08:36:06 +01:00
2023-07-20 10:06:36 +02:00
2023-07-18 18:41:18 -07:00
2021-11-17 20:17:05 -08:00
2023-08-07 13:05:53 -07:00
2023-06-15 22:33:26 -07:00
2023-08-02 18:42:03 -07:00
2023-02-16 10:39:28 +01:00
2020-02-28 14:51:30 +01:00
2023-02-20 16:46:10 -08:00
2023-03-17 08:56:37 +00:00
2023-05-01 07:43:19 +01:00
2023-03-18 12:23:33 +00:00
2023-08-04 15:34:03 -07:00
2022-07-22 12:53:22 +01:00
2023-03-21 21:32:18 -07:00
2023-03-18 12:23:34 +00:00
2022-08-09 22:14:02 -07:00
2021-12-13 12:34:09 +00:00
2023-07-28 18:06:30 -07:00
2022-11-02 20:38:13 -07:00
2022-07-22 12:53:22 +01:00
2023-07-14 20:39:29 -07:00
2021-03-26 17:43:55 +01:00
2023-08-03 08:38:07 -07:00
2022-11-16 11:31:47 +02:00
2023-06-21 14:01:29 +02:00
2023-07-14 20:39:29 -07:00
2023-01-27 11:19:46 +00:00
2020-07-15 07:45:24 -07:00
2020-03-27 19:40:38 -07:00
2021-12-22 15:03:47 -08:00
2022-07-22 12:53:22 +01:00
2023-07-14 20:39:29 -07:00
2022-07-24 18:39:17 -06:00
2023-07-27 17:17:32 -07:00
2022-07-22 12:53:22 +01:00
2023-01-20 09:33:22 +00:00
2023-07-31 14:11:00 -07:00
2023-07-20 12:49:40 +02:00
2023-04-20 20:20:49 -07:00
2023-04-09 15:35:49 +01:00
2023-07-18 09:47:08 +02:00
2019-12-16 16:09:44 -08:00
2021-11-29 19:50:45 -08:00
2022-12-05 21:58:27 -08:00
2023-01-13 20:59:14 -08:00
2023-03-28 18:52:28 -07:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2020-04-20 07:34:16 +02:00
2022-07-22 12:53:22 +01:00
2021-12-06 16:06:02 -08:00
2019-12-24 22:37:30 -08:00
2021-12-16 07:18:35 -08:00
2022-07-28 22:21:54 -07:00
2023-08-02 10:09:31 +01:00
2023-08-02 10:09:32 +01:00
2023-06-02 10:52:38 +01:00
2023-04-12 16:40:39 -07:00
2022-12-01 15:09:10 +01:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2021-10-18 12:54:41 +01:00
2022-11-21 13:09:07 +00:00
2022-10-31 10:43:04 +00:00
2021-01-29 20:39:14 -08:00
2023-07-29 17:10:27 +01:00
2023-06-10 00:11:41 -07:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2023-07-28 14:07:59 -07:00
2022-07-22 12:53:22 +01:00
2021-06-28 14:29:45 -07:00
2023-06-14 12:32:19 +02:00
2023-03-23 21:51:30 +01:00
2022-04-06 22:09:39 -07:00
2022-07-22 12:53:22 +01:00
2023-07-25 13:55:55 -07:00
2023-06-24 15:50:13 -07:00
2022-08-24 19:30:07 -07:00
2022-02-07 20:12:45 -08:00
2021-10-15 11:33:08 +01:00
2023-07-14 20:39:29 -07:00
2023-08-04 09:20:27 +01:00
2023-07-29 18:13:41 +01:00
2022-12-30 07:25:52 +00:00
2022-02-17 07:00:39 -06:00
2021-11-16 13:16:54 +00:00
2023-03-29 08:22:52 +01:00
2023-07-28 11:01:56 +01:00
2022-04-25 11:40:45 +01:00
2022-04-11 17:37:50 -07:00
2023-07-19 10:53:48 +01:00
2023-04-22 01:39:41 +02:00
2023-07-29 18:13:41 +01:00
2022-09-29 07:18:00 +02:00
2022-07-22 12:53:22 +01:00
2022-10-31 20:14:27 -07:00
2022-09-02 20:34:32 -07:00
2023-07-24 16:52:37 -07:00
2023-06-12 21:13:23 -07:00
2020-06-20 17:22:22 -07:00
2021-03-23 14:14:50 -07:00
2023-08-04 15:33:17 -07:00
2023-08-04 15:33:17 -07:00
2022-07-22 12:53:22 +01:00
2023-07-20 10:46:28 +02:00
2021-10-13 09:40:46 -07:00
2023-07-14 20:39:29 -07:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2022-07-28 11:29:36 +02:00
2021-11-07 19:25:29 +00:00
2021-08-30 01:51:36 +02:00
2023-06-21 09:16:57 +02:00
2022-10-12 12:57:19 +02:00
2023-05-10 11:32:09 +01:00
2023-06-20 20:06:16 -07:00
2021-10-29 13:23:51 +01:00
2020-03-02 11:16:27 -08:00
2021-03-26 15:14:56 -07:00
2022-07-22 12:53:22 +01:00
2020-05-29 21:20:20 -07:00
2022-12-12 13:11:24 -08:00
2022-11-18 12:14:55 +00:00
2022-07-22 12:53:22 +01:00
2023-08-07 08:53:55 +01:00
2023-08-07 08:53:54 +01:00
2022-05-11 12:43:10 +01:00
2023-07-28 11:35:58 -07:00
2021-12-10 06:38:26 -08:00
2023-04-18 12:59:01 +02:00
2023-08-03 08:38:07 -07:00
2022-07-22 12:53:22 +01:00
2023-07-27 13:45:51 +02:00
2022-07-22 12:53:22 +01:00
2023-05-11 18:07:05 -07:00
2023-01-28 13:51:22 +01:00
2023-07-14 20:39:29 -07:00
2023-08-04 15:33:50 -07:00
2023-07-14 20:39:30 -07:00
2023-06-02 09:55:22 +01:00
2023-08-07 08:53:54 +01:00
2023-07-12 15:59:33 -07:00
2022-07-22 12:53:22 +01:00
2022-07-15 18:50:35 -07:00
2021-08-09 15:34:21 -07:00
2022-07-22 12:53:22 +01:00
2023-04-06 12:01:20 -07:00
2023-03-17 08:56:37 +00:00
2022-10-11 17:42:58 -06:00
2023-06-19 12:05:29 +02:00
2022-02-02 14:45:18 +00:00
2022-08-01 11:59:23 -07:00
2023-08-03 14:34:37 -07:00
2023-06-19 11:32:58 -07:00
2023-07-14 20:39:30 -07:00
2022-10-31 18:10:21 -07:00
2023-08-01 10:47:24 +02:00
2023-06-27 10:50:22 -07:00
2022-07-22 12:53:22 +01:00
2022-01-04 12:17:35 +00:00
2021-04-28 14:06:45 -07:00
2023-03-15 08:18:35 +00:00
2022-10-25 11:35:16 +02:00
2023-07-25 13:55:55 -07:00
2023-08-03 18:10:10 -07:00
2022-07-22 12:53:22 +01:00
2022-07-18 11:24:10 +01:00
2023-08-02 12:28:26 -07:00
2023-02-16 09:27:07 +01:00
2023-07-31 14:33:55 -07:00
2023-07-19 10:07:27 -07:00
2023-07-28 14:07:59 -07:00
2023-07-28 14:07:59 -07:00
2023-08-01 15:06:27 -07:00
2022-12-12 15:04:39 -08:00
2022-07-22 12:53:22 +01:00
2022-11-08 16:42:28 +00:00
2023-08-07 08:53:55 +01:00
2023-08-07 08:53:55 +01:00
2023-08-02 10:58:26 +01:00
2023-03-18 12:23:34 +00:00
2022-07-22 12:53:22 +01:00
2023-07-19 09:56:49 -07:00
2023-07-19 09:56:49 -07:00
2023-08-03 08:38:07 -07:00
2023-05-21 09:21:37 +02:00
2023-07-19 09:56:49 -07:00