Eric Dumazet
27880b0b0d
net/sched: act_ife: avoid possible NULL deref
tcf_ife_encode() must make sure ife_encode() does not return NULL.
syzbot reported:
Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] SMP KASAN NOPTI
KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
RIP: 0010:ife_tlv_meta_encode+0x41/0xa0 net/ife/ife.c:166
CPU: 3 UID: 0 PID: 8990 Comm: syz.0.696 Not tainted syzkaller #0 PREEMPT(full)
Call Trace:
<TASK>
ife_encode_meta_u32+0x153/0x180 net/sched/act_ife.c:101
tcf_ife_encode net/sched/act_ife.c:841 [inline]
tcf_ife_act+0x1022/0x1de0 net/sched/act_ife.c:877
tc_act include/net/tc_wrapper.h:130 [inline]
tcf_action_exec+0x1c0/0xa20 net/sched/act_api.c:1152
tcf_exts_exec include/net/pkt_cls.h:349 [inline]
mall_classify+0x1a0/0x2a0 net/sched/cls_matchall.c:42
tc_classify include/net/tc_wrapper.h:197 [inline]
__tcf_classify net/sched/cls_api.c:1764 [inline]
tcf_classify+0x7f2/0x1380 net/sched/cls_api.c:1860
multiq_classify net/sched/sch_multiq.c:39 [inline]
multiq_enqueue+0xe0/0x510 net/sched/sch_multiq.c:66
dev_qdisc_enqueue+0x45/0x250 net/core/dev.c:4147
__dev_xmit_skb net/core/dev.c:4262 [inline]
__dev_queue_xmit+0x2998/0x46c0 net/core/dev.c:4798
Fixes: 295a6e06d2 ("net/sched: act_ife: Change to use ife module")
Reported-by: syzbot+5cf914f193dffde3bd3c@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/netdev/6970d61d.050a0220.706b.0010.GAE@google.com/T/#u
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Yotam Gigi <yotam.gi@gmail.com>
Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
Link: https://patch.msgid.link/20260121133724.3400020-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2026-01-22 08:01:44 -08:00
..
2026-01-06 17:27:18 -08:00
2025-11-14 08:56:49 -08:00
2025-11-11 15:00:08 +01:00
2025-09-02 15:51:45 -07:00
2025-11-25 16:10:31 +01:00
2025-09-02 15:51:45 -07:00
2024-02-02 10:57:55 -08:00
2025-02-18 10:35:44 +01:00
2026-01-22 08:01:44 -08:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2026-01-05 16:23:42 -08:00
2025-09-02 15:51:45 -07:00
2025-09-02 15:51:45 -07:00
2025-09-02 15:51:45 -07:00
2025-07-11 16:01:17 -07:00
2024-07-05 17:45:47 -07:00
2025-08-12 17:13:29 -07:00
2025-09-02 15:51:45 -07:00
2025-09-02 15:51:45 -07:00
2025-09-02 15:51:45 -07:00
2025-09-02 15:51:45 -07:00
2025-07-16 18:34:42 -07:00
2025-11-25 16:10:31 +01:00
2024-02-02 10:57:55 -08:00
2025-11-14 08:56:49 -08:00
2024-02-02 10:57:55 -08:00
2025-06-08 09:07:37 +02:00
2025-11-25 16:10:31 +01:00
2024-02-02 10:57:55 -08:00
2025-01-20 09:21:27 +00:00
2024-02-02 10:57:55 -08:00
2025-01-20 09:21:27 +00:00
2025-11-26 16:28:10 +01:00
2025-11-24 18:53:14 -08:00
2020-07-03 14:34:53 -07:00
2020-07-03 14:34:53 -07:00
2025-02-19 19:05:28 -08:00
2025-11-24 18:53:14 -08:00
2025-11-24 18:53:14 -08:00
2024-02-09 14:12:02 -08:00
2022-12-19 09:43:18 +00:00
2025-07-23 17:52:07 -07:00
2025-07-23 17:52:07 -07:00
2025-11-10 16:57:56 -08:00
2020-07-16 16:48:34 -07:00
2025-12-02 15:37:53 -08:00
2024-10-15 18:25:47 -07:00
2024-12-04 12:54:22 +00:00
2025-11-25 16:10:32 +01:00
2025-04-28 15:55:06 -07:00
2025-11-25 16:10:32 +01:00
2024-04-19 11:34:07 +01:00
2025-12-11 01:36:40 -08:00
2025-02-05 18:13:58 -08:00
2025-11-25 16:10:32 +01:00
2025-08-14 17:52:29 -07:00
2025-11-25 16:10:32 +01:00
2025-05-15 15:23:31 +02:00
2025-11-13 12:35:38 -08:00
2025-03-06 16:35:14 -08:00
2025-07-10 11:08:35 +02:00
2025-08-14 17:52:29 -07:00
2025-08-20 19:27:08 -07:00
2024-07-08 14:07:31 -07:00
2023-06-07 10:25:39 +01:00
2023-11-01 21:49:09 -07:00
2023-04-13 22:22:10 -07:00
2025-08-04 17:22:20 -07:00
2024-06-05 10:50:19 +01:00
2025-11-25 16:10:32 +01:00
2025-08-14 17:52:29 -07:00
2024-02-02 10:57:55 -08:00
2025-06-12 08:05:49 -07:00
2026-01-19 12:06:41 -08:00
2025-06-12 09:50:36 -07:00
2024-12-17 13:27:29 +01:00
2025-06-12 09:50:36 -07:00
2025-04-02 16:03:32 -07:00
2025-11-25 16:10:32 +01:00
2025-11-25 16:10:32 +01:00
2026-01-19 12:06:41 -08:00