Bob Peterson 70499cdfeb
gfs2: Never call gfs2_block_zero_range with an open transaction ...
Before this patch, some functions started transactions then they called
gfs2_block_zero_range. However, gfs2_block_zero_range, like writes, can
start transactions, which results in a recursive transaction error.
For example:
do_shrink
trunc_start
gfs2_trans_begin <------------------------------------------------
gfs2_block_zero_range
iomap_zero_range(inode, from, length, NULL, &gfs2_iomap_ops);
iomap_apply ... iomap_zero_range_actor
iomap_begin
gfs2_iomap_begin
gfs2_iomap_begin_write
actor (iomap_zero_range_actor)
iomap_zero
iomap_write_begin
gfs2_iomap_page_prepare
gfs2_trans_begin <------------------------
This patch reorders the callers of gfs2_block_zero_range so that they
only start their transactions after the call. It also adds a BUG_ON to
ensure this doesn't happen again.
Fixes: 2257e468a6stable@vger.kernel.org # v5.5+
Signed-off-by: Bob Peterson <rpeterso@redhat.com >
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com >
2020-08-07 17:22:55 +02:00
2020-03-27 09:29:56 +00:00
2020-04-20 15:45:22 -06:00
2020-04-20 15:45:22 -06:00
2020-06-27 22:04:24 -07:00
2020-07-08 08:27:56 +02:00
2020-04-20 15:45:22 -06:00
2020-07-12 10:58:35 -07:00
2020-07-08 08:27:56 +02:00
2020-06-01 13:22:53 +02:00
2020-07-09 10:07:09 -05:00
2020-05-05 09:22:21 -06:00
2020-06-01 15:45:27 -07:00
2020-04-20 15:45:22 -06:00
2020-06-01 12:10:17 -07:00
2020-04-27 09:34:55 +02:00
2020-06-05 16:43:16 -07:00
2020-06-01 15:45:27 -07:00
2020-06-15 14:38:56 +02:00
2020-06-24 09:47:44 +08:00
2020-06-29 17:11:18 +09:00
2020-06-09 09:39:14 -07:00
2020-06-15 09:32:10 -07:00
2020-06-09 11:28:59 -07:00
2020-06-04 19:06:25 -07:00
2020-06-03 16:27:18 -07:00
2020-06-09 15:48:24 -07:00
2020-08-07 17:22:55 +02:00
2020-06-02 15:29:19 -07:00
2020-05-22 08:45:46 -06:00
2020-03-29 23:23:00 +02:00
2020-06-06 10:08:17 -07:00
2020-06-09 09:39:14 -07:00
2020-06-13 12:44:30 -07:00
2020-06-02 15:29:19 -07:00
2020-06-15 09:32:10 -07:00
2020-06-15 23:08:31 -05:00
2020-06-02 20:11:35 -07:00
2020-06-09 09:39:14 -07:00
2020-02-04 03:05:26 +00:00
2020-06-26 08:43:14 -04:00
2020-06-29 14:48:28 -04:00
2020-06-10 19:14:17 -07:00
2020-06-14 01:57:21 +09:00
2020-06-14 01:57:21 +09:00
2020-06-02 12:21:36 -07:00
2020-06-26 00:27:37 -07:00
2020-06-02 10:59:07 -07:00
2020-06-05 16:44:36 -07:00
2020-06-09 15:40:50 -07:00
2020-07-03 23:20:14 -07:00
2020-06-01 16:18:46 -07:00
2020-06-02 10:59:07 -07:00
2020-04-27 02:07:40 -04:00
2020-02-07 14:48:37 -05:00
2020-06-04 13:53:10 -07:00
2020-06-14 01:57:21 +09:00
2020-06-15 23:08:32 -05:00
2020-06-05 14:05:57 -07:00
2020-04-20 15:45:22 -06:00
2020-06-02 10:59:11 -07:00
2020-06-02 15:29:19 -07:00
2020-03-25 11:50:48 +01:00
2020-05-07 08:45:47 -06:00
2020-05-12 16:44:00 -07:00
2020-06-22 19:22:57 -07:00
2020-06-04 13:50:13 -07:00
2020-06-15 23:08:25 -05:00
2020-06-03 23:16:55 -04:00
2020-05-07 16:55:47 -05:00
2020-06-10 16:02:54 -07:00
2020-06-10 16:02:54 -07:00
2020-06-04 19:18:29 -07:00
2020-06-10 16:02:54 -07:00
2020-06-04 19:18:29 -07:00
2020-06-04 19:18:29 -07:00
2020-06-18 09:24:35 -06:00
2020-06-02 10:59:07 -07:00
2020-05-14 16:44:23 +02:00
2020-06-05 13:45:21 -07:00
2020-06-09 09:39:14 -07:00
2020-04-02 19:15:03 -07:00
2020-06-03 16:27:18 -07:00
2020-06-14 09:47:25 -07:00
2020-04-27 02:07:40 -04:00
2020-05-06 22:33:43 -04:00
2020-05-14 10:00:35 -07:00
2020-06-09 09:39:14 -07:00
2020-03-03 10:55:06 -05:00
2020-06-29 09:40:55 -07:00
2020-05-19 18:29:36 -04:00
2020-04-10 15:36:22 -07:00
2020-05-14 16:44:25 +02:00
2020-04-02 09:35:26 -07:00
2020-06-05 16:19:28 -07:00
2020-02-07 14:48:35 -05:00
2020-06-05 16:26:36 -07:00
2020-06-05 16:19:28 -07:00
2020-07-12 09:40:50 -06:00
2020-06-15 08:51:34 -06:00
2020-06-15 08:51:38 -06:00
2020-06-03 23:16:55 -04:00
2020-06-14 01:57:21 +09:00
2020-06-14 01:57:21 +09:00
2020-05-22 08:45:46 -06:00
2020-06-11 10:33:13 -07:00
2020-03-05 21:00:40 -05:00
2020-05-14 16:44:24 +02:00
2020-06-02 10:59:07 -07:00
2020-06-08 11:04:19 -07:00
2020-06-10 16:09:11 -07:00
2020-05-13 11:41:22 +02:00
2020-06-02 12:21:36 -07:00
2020-06-13 09:56:21 -07:00
2020-04-27 10:37:14 -04:00
2020-06-08 11:04:19 -07:00
2020-06-04 13:54:34 -07:00
2020-07-08 08:27:57 +02:00
2020-05-01 20:29:54 -04:00
2020-05-29 19:10:42 -04:00
2020-06-04 19:06:25 -07:00
2020-06-13 09:56:21 -07:00
2020-06-02 19:45:12 -07:00
2020-06-10 16:09:11 -07:00
2020-06-09 15:40:50 -07:00
2020-06-09 09:39:14 -07:00
2020-05-14 16:44:24 +02:00
2020-04-09 15:33:09 -04:00
70499cdfeb