Maíra Canal 6abe93b621
drm/v3d: Fix race-condition between sysfs/fdinfo and interrupt handler ...
In V3D, the conclusion of a job is indicated by a IRQ. When a job
finishes, then we update the local and the global GPU stats of that
queue. But, while the GPU stats are being updated, a user might be
reading the stats from sysfs or fdinfo.
For example, on `gpu_stats_show()`, we could think about a scenario where
`v3d->queue[queue].start_ns != 0`, then an interrupt happens, we update
the value of `v3d->queue[queue].start_ns` to 0, we come back to
`gpu_stats_show()` to calculate `active_runtime` and now,
`active_runtime = timestamp`.
In this simple example, the user would see a spike in the queue usage,
that didn't match reality.
In order to address this issue properly, use a seqcount to protect read
and write sections of the code.
Fixes: 09a93cc4f7tursulin@igalia.com >
Signed-off-by: Maíra Canal <mcanal@igalia.com >
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20240420213632.339941-7-mcanal@igalia.com
2024-04-23 19:32:49 -03:00
2024-04-22 14:35:52 +10:00
2024-04-11 14:32:53 +02:00
2024-04-08 16:44:14 +02:00
2024-04-11 15:19:12 +02:00
2024-04-13 10:42:28 +09:00
2024-03-07 20:36:32 -08:00
2024-03-12 17:37:54 +02:00
2024-04-05 17:21:16 -07:00
2024-04-02 07:43:24 -06:00
2024-03-29 09:48:37 -04:00
2024-03-21 13:21:31 -07:00
2024-03-28 22:40:56 +00:00
2024-03-07 11:53:30 -07:00
2024-03-07 21:52:03 +00:00
2024-04-17 13:53:18 +02:00
2024-04-10 20:50:26 -07:00
2024-03-23 14:42:45 -07:00
2024-04-11 15:16:23 +02:00
2024-02-16 18:51:00 -05:00
2024-03-22 10:41:13 -07:00
2024-03-22 10:41:13 -07:00
2024-04-04 10:40:30 +02:00
2024-04-11 16:49:11 -07:00
2024-03-15 11:58:32 -07:00
2024-03-07 20:37:04 +00:00
2024-03-15 12:25:13 -07:00
2024-04-15 13:56:32 -03:00
2024-03-25 19:40:23 -07:00
2024-03-11 18:14:06 -07:00
2024-04-06 09:36:46 +09:00
2024-04-09 16:29:48 +02:00
2024-03-21 13:21:31 -07:00
2024-04-12 21:30:58 +02:00
2024-04-23 19:32:49 -03:00
2024-03-21 13:21:31 -07:00
2024-03-14 09:56:15 -07:00
2024-02-25 19:05:45 +01:00
2024-04-11 16:23:56 -07:00
2024-03-14 18:03:09 -07:00
2024-03-05 20:01:14 -08:00
2024-02-27 11:26:45 +00:00
2024-04-04 01:07:57 +02:00
2024-02-19 21:23:28 +01:00
2024-03-05 21:25:18 +01:00
2024-03-21 13:21:31 -07:00
2024-04-08 13:33:10 +03:00
2024-03-21 12:44:10 -07:00
2024-04-11 14:44:49 +02:00
2024-04-19 14:02:21 -07:00
2024-03-07 20:32:47 +00:00
2024-04-09 11:11:18 +02:00
2024-04-09 17:01:01 -07:00
2024-03-14 18:03:09 -07:00
2024-03-15 17:53:48 -07:00
2024-03-13 12:23:36 -07:00
2024-03-07 20:38:15 +00:00
2024-04-08 21:49:27 -06:00
2024-03-26 09:52:59 +01:00
2024-03-21 13:21:31 -07:00
2024-03-13 10:59:28 -07:00
2024-03-21 12:44:10 -07:00
2024-04-11 15:15:53 +02:00
2024-04-09 16:17:37 +02:00
2024-03-07 20:32:38 +00:00
2024-03-27 13:17:15 +01:00
2024-04-18 11:40:54 -07:00
2024-02-16 16:13:38 +05:30
2024-03-15 11:58:32 -07:00
2024-04-04 08:47:56 -07:00
2024-03-07 20:21:53 +00:00
2024-03-27 17:05:07 -05:00
2024-03-11 10:39:24 +05:30
2024-03-08 10:00:07 +01:00
2024-03-07 21:50:06 +00:00
2024-03-29 11:57:12 -05:00
2024-03-10 09:07:00 +01:00
2024-03-26 14:09:18 -07:00
2024-03-21 12:35:20 -07:00
2024-03-31 11:23:51 -07:00
2024-04-18 07:15:33 -07:00
2024-03-13 11:33:10 -07:00
2024-03-14 10:19:48 -07:00
2024-03-13 20:45:54 +01:00
2024-03-07 21:51:39 +00:00
2024-03-12 17:44:08 -07:00
2024-04-15 17:28:13 +02:00
2024-03-26 21:48:21 +01:00
2024-03-25 19:28:27 +00:00
2024-03-21 10:37:39 -07:00
2024-02-21 11:53:25 +01:00
2024-03-21 17:16:46 -07:00
2024-04-19 09:59:15 -07:00
2024-03-15 12:47:21 -07:00
2024-04-08 21:40:29 -04:00
2024-02-15 18:12:01 +01:00
2024-03-21 15:18:18 -07:00
2024-03-07 20:21:39 +00:00
2024-03-21 14:50:39 -07:00
2024-03-15 12:22:52 -07:00
2024-04-03 11:04:58 +01:00
2024-03-25 19:10:01 +01:00
2024-04-05 21:37:54 -04:00
2024-02-20 13:36:34 +01:00
2024-03-12 10:35:24 -07:00
2024-04-19 15:08:19 +02:00
2024-04-10 10:49:58 +03:00
2024-04-17 13:26:45 +02:00
2024-04-08 15:06:56 -04:00
2024-04-11 16:23:56 -07:00
2024-04-19 16:07:18 +02:00
2024-03-19 02:45:51 -04:00
2024-03-15 13:21:13 -07:00
2024-04-08 04:11:04 -04:00
2024-04-02 09:51:30 +02:00
2024-04-18 14:47:23 +02:00
2024-04-08 04:11:04 -04:00
2024-02-20 11:24:34 +01:00
2024-03-17 12:06:10 -07:00
2024-03-19 08:48:09 -07:00
2024-02-19 11:10:55 +01:00
2024-03-07 08:48:10 +00:00
6abe93b621