Jan Kara 66d8fc0539
fs: no need to check source ...
The @source inode must be valid. It is even checked via IS_SWAPFILE()
above making it pretty clear. So no need to check it when we unlock.
What doesn't need to exist is the @target inode. The lock_two_inodes()
helper currently swaps the @inode1 and @inode2 arguments if @inode1 is
NULL to have consistent lock class usage. However, we know that at least
for vfs_rename() that @inode1 is @source and thus is never NULL as per
above. We also know that @source is a different inode than @target as
that is checked right at the beginning of vfs_rename(). So we know that
@source is valid and locked and that @target is locked. So drop the
check whether @source is non-NULL.
Fixes: 28eceeda13lkp@intel.com >
Reported-by: Dan Carpenter <dan.carpenter@linaro.org >
Closes: https://lore.kernel.org/r/202307030026.9sE2pk2x-lkp@intel.com
Message-Id: <20230703-vfs-rename-source-v1-1-37eebb29b65b@kernel.org >
[brauner: use commit message from patch I sent concurrently]
Signed-off-by: Christian Brauner <brauner@kernel.org >
2023-07-04 10:20:29 +02:00
2023-05-24 08:42:16 -06:00
2023-05-24 08:42:17 -06:00
2023-05-24 08:42:17 -06:00
2023-06-28 10:28:11 -07:00
2023-06-15 09:22:24 +02:00
2023-05-30 16:42:00 -07:00
2023-05-24 08:42:17 -06:00
2023-06-28 10:28:11 -07:00
2023-06-26 10:14:36 -07:00
2023-06-28 10:28:11 -07:00
2023-05-24 08:42:16 -06:00
2023-04-03 09:23:54 +02:00
2023-05-24 08:42:17 -06:00
2023-05-23 19:46:09 -07:00
2023-05-31 19:02:14 +01:00
2023-03-13 12:36:34 +01:00
2023-06-29 13:27:50 -07:00
2023-05-24 08:42:17 -06:00
2023-05-17 18:21:34 +02:00
2023-06-26 12:47:20 -07:00
2023-05-24 08:42:17 -06:00
2023-05-22 18:08:37 +02:00
2023-06-29 13:39:51 -07:00
2023-06-29 13:39:51 -07:00
2023-06-28 10:28:11 -07:00
2023-05-24 08:42:17 -06:00
2023-02-23 17:55:40 -08:00
2023-01-30 12:51:54 +00:00
2023-07-01 08:48:02 -07:00
2023-06-28 10:28:11 -07:00
2023-05-24 08:42:17 -06:00
2023-05-24 08:42:17 -06:00
2023-06-27 17:10:27 -07:00
2023-05-24 08:42:17 -06:00
2023-06-23 16:59:32 -07:00
2023-07-02 11:14:54 -07:00
2022-10-12 11:00:22 -07:00
2023-06-29 13:18:36 -07:00
2023-06-26 11:52:12 -07:00
2023-06-29 13:10:32 -07:00
2023-07-03 12:56:23 -07:00
2023-07-01 14:38:25 -07:00
2023-05-24 08:42:17 -06:00
2023-06-08 13:42:33 +02:00
2023-07-01 14:38:25 -07:00
2023-04-13 13:13:52 -07:00
2023-06-30 21:48:44 -07:00
2023-06-26 12:47:20 -07:00
2023-05-25 13:17:04 +02:00
2023-06-28 10:28:11 -07:00
2023-06-28 10:28:11 -07:00
2023-06-28 16:43:10 -07:00
2023-05-24 08:42:17 -06:00
2023-05-24 08:42:16 -06:00
2023-06-29 13:01:27 -07:00
2023-06-30 16:19:47 -07:00
2023-06-27 21:21:32 -07:00
2023-03-14 12:56:30 -06:00
2023-03-14 12:56:30 -06:00
2023-06-05 16:50:30 +02:00
2023-06-28 10:28:11 -07:00
2023-06-28 10:28:11 -07:00
2023-05-24 08:42:17 -06:00
2023-06-30 22:00:28 -07:00
2023-06-09 17:44:14 -07:00
2023-06-15 13:37:53 +02:00
2023-06-26 11:52:12 -07:00
2023-01-19 09:24:26 +01:00
2023-05-24 08:42:17 -06:00
2023-06-29 13:39:51 -07:00
2023-05-24 08:42:17 -06:00
2023-04-13 13:13:54 -07:00
2023-06-27 21:24:18 -07:00
2023-06-20 22:47:55 -07:00
2023-06-29 13:23:32 -07:00
2023-06-28 10:28:11 -07:00
2023-06-15 09:22:23 +02:00
2023-03-30 08:51:48 +02:00
2023-01-19 09:24:28 +01:00
2023-05-30 15:49:46 -07:00
2023-06-28 20:35:21 -07:00
2022-12-02 13:57:04 -08:00
2023-06-29 13:39:51 -07:00
2023-05-15 09:42:01 +02:00
2023-06-26 09:50:21 -07:00
2023-05-17 09:16:59 +02:00
2023-06-26 07:54:23 -06:00
2022-10-10 19:45:17 -07:00
2023-06-28 10:28:11 -07:00
2023-06-15 09:22:23 +02:00
2023-06-26 09:50:21 -07:00
2023-06-29 13:31:44 -07:00
2023-02-20 11:53:11 -08:00
2023-06-12 10:43:45 +02:00
2023-07-02 13:15:49 +02:00
2023-03-09 22:46:21 -05:00
2023-06-07 21:49:55 +02:00
2022-12-01 10:46:54 -05:00
2023-06-09 16:25:14 -07:00
2023-01-19 09:24:28 +01:00
2023-06-26 12:47:20 -07:00
2023-06-26 10:14:36 -07:00
2023-01-19 09:24:29 +01:00
2023-05-24 16:29:21 -05:00
2022-10-10 14:21:11 -07:00
2023-06-09 16:25:53 -07:00
2023-03-09 22:36:12 +01:00
2023-06-26 12:47:20 -07:00
2022-12-08 21:49:25 -05:00
2023-01-19 09:24:30 +01:00
2023-04-18 16:30:02 -07:00
2023-07-04 10:20:29 +02:00
2023-06-26 10:27:04 -07:00
2023-04-20 22:55:35 -04:00
2023-06-29 13:31:44 -07:00
2023-05-12 17:17:27 +02:00
2023-05-19 04:30:22 +02:00
2023-05-19 04:30:22 +02:00
2023-03-06 09:59:20 +01:00
2023-05-24 08:42:16 -06:00
2023-05-24 08:42:17 -06:00
2023-06-21 09:06:59 +02:00
2023-05-24 11:03:59 +02:00
2022-11-25 13:01:55 -05:00
2023-06-28 16:43:10 -07:00
2023-02-20 11:53:11 -08:00
2023-05-17 15:20:17 +02:00
2023-06-29 13:39:51 -07:00
2023-05-23 21:43:26 -07:00
2023-06-23 16:58:19 -07:00
2023-02-20 11:53:11 -08:00
2023-05-17 15:25:20 +02:00
66d8fc0539