mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-02-17 23:00:26 -05:00
07008b9c1c
While tracking down a problem where constant expressions used by BUILD_BUG_ON() suddenly stopped working[1], we found that an added static initializer was convincing the compiler that it couldn't track the state of the prior statically initialized value. Tracing this down found that ffs() was used in the initializer macro, but since it wasn't marked with __attribute__const__, the compiler had to assume the function might change variable states as a side-effect (which is not true for ffs(), which provides deterministic math results). Add missing __attribute_const__ annotations to sparc64's implementations of ffs(), __ffs(), fls(), and __fls() functions. These are pure mathematical functions that always return the same result for the same input with no side effects, making them eligible for compiler optimization. Build tested ARCH=sparc defconfig with GCC sparc64-linux-gnu 14.2.0. Link: https://github.com/KSPP/linux/issues/364 [1] Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lore.kernel.org/r/20250804164417.1612371-16-kees@kernel.org Signed-off-by: Kees Cook <kees@kernel.org>
64 lines
1.7 KiB
C
64 lines
1.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* bitops.h: Bit string operations on the V9.
|
|
*
|
|
* Copyright 1996, 1997 David S. Miller (davem@caip.rutgers.edu)
|
|
*/
|
|
|
|
#ifndef _SPARC64_BITOPS_H
|
|
#define _SPARC64_BITOPS_H
|
|
|
|
#ifndef _LINUX_BITOPS_H
|
|
#error only <linux/bitops.h> can be included directly
|
|
#endif
|
|
|
|
#include <linux/compiler.h>
|
|
#include <asm/byteorder.h>
|
|
#include <asm/barrier.h>
|
|
|
|
int test_and_set_bit(unsigned long nr, volatile unsigned long *addr);
|
|
int test_and_clear_bit(unsigned long nr, volatile unsigned long *addr);
|
|
int test_and_change_bit(unsigned long nr, volatile unsigned long *addr);
|
|
void set_bit(unsigned long nr, volatile unsigned long *addr);
|
|
void clear_bit(unsigned long nr, volatile unsigned long *addr);
|
|
void change_bit(unsigned long nr, volatile unsigned long *addr);
|
|
|
|
int __attribute_const__ fls(unsigned int word);
|
|
int __attribute_const__ __fls(unsigned long word);
|
|
|
|
#include <asm-generic/bitops/non-atomic.h>
|
|
|
|
#include <asm-generic/bitops/fls64.h>
|
|
|
|
#ifdef __KERNEL__
|
|
|
|
int __attribute_const__ ffs(int x);
|
|
unsigned long __attribute_const__ __ffs(unsigned long);
|
|
|
|
#include <asm-generic/bitops/ffz.h>
|
|
#include <asm-generic/bitops/sched.h>
|
|
|
|
/*
|
|
* hweightN: returns the hamming weight (i.e. the number
|
|
* of bits set) of a N-bit word
|
|
*/
|
|
|
|
unsigned long __arch_hweight64(__u64 w);
|
|
unsigned int __arch_hweight32(unsigned int w);
|
|
unsigned int __arch_hweight16(unsigned int w);
|
|
unsigned int __arch_hweight8(unsigned int w);
|
|
|
|
#include <asm-generic/bitops/const_hweight.h>
|
|
#include <asm-generic/bitops/lock.h>
|
|
#endif /* __KERNEL__ */
|
|
|
|
#ifdef __KERNEL__
|
|
|
|
#include <asm-generic/bitops/le.h>
|
|
|
|
#include <asm-generic/bitops/ext2-atomic-setbit.h>
|
|
|
|
#endif /* __KERNEL__ */
|
|
|
|
#endif /* defined(_SPARC64_BITOPS_H) */
|