mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-02-17 17:10:26 -05:00
e67f0bd055
The kexec_buf structure was previously declared without initialization. commitbf454ec31a("kexec_file: allow to place kexec_buf randomly") added a field that is always read but not consistently populated by all architectures. This un-initialized field will contain garbage. This is also triggering a UBSAN warning when the uninitialized data was accessed: ------------[ cut here ]------------ UBSAN: invalid-load in ./include/linux/kexec.h:210:10 load of value 252 is not a valid value for type '_Bool' Zero-initializing kexec_buf at declaration ensures all fields are cleanly set, preventing future instances of uninitialized memory being used. Link: https://lkml.kernel.org/r/20250827-kbuf_all-v1-3-1df9882bb01a@debian.org Fixes:bf454ec31a("kexec_file: allow to place kexec_buf randomly") Signed-off-by: Breno Leitao <leitao@debian.org> Cc: Albert Ou <aou@eecs.berkeley.edu> Cc: Alexander Gordeev <agordeev@linux.ibm.com> Cc: Alexandre Ghiti <alex@ghiti.fr> Cc: Baoquan He <bhe@redhat.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Christian Borntraeger <borntraeger@linux.ibm.com> Cc: Coiby Xu <coxu@redhat.com> Cc: Heiko Carstens <hca@linux.ibm.com> Cc: Palmer Dabbelt <palmer@dabbelt.com> Cc: Paul Walmsley <paul.walmsley@sifive.com> Cc: Sven Schnelle <svens@linux.ibm.com> Cc: Vasily Gorbik <gor@linux.ibm.com> Cc: Will Deacon <will@kernel.org> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
68 lines
1.6 KiB
C
68 lines
1.6 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Image loader for kexec_file_load system call.
|
|
*
|
|
* Copyright IBM Corp. 2018
|
|
*
|
|
* Author(s): Philipp Rudo <prudo@linux.vnet.ibm.com>
|
|
*/
|
|
|
|
#include <linux/errno.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/kexec.h>
|
|
#include <asm/ipl.h>
|
|
#include <asm/setup.h>
|
|
|
|
static int kexec_file_add_kernel_image(struct kimage *image,
|
|
struct s390_load_data *data)
|
|
{
|
|
struct kexec_buf buf = {};
|
|
|
|
buf.image = image;
|
|
|
|
buf.buffer = image->kernel_buf;
|
|
buf.bufsz = image->kernel_buf_len;
|
|
|
|
buf.mem = 0;
|
|
#ifdef CONFIG_CRASH_DUMP
|
|
if (image->type == KEXEC_TYPE_CRASH)
|
|
buf.mem += crashk_res.start;
|
|
#endif
|
|
buf.memsz = buf.bufsz;
|
|
|
|
data->kernel_buf = image->kernel_buf;
|
|
data->kernel_mem = buf.mem;
|
|
data->parm = image->kernel_buf + PARMAREA;
|
|
data->memsz += buf.memsz;
|
|
|
|
ipl_report_add_component(data->report, &buf,
|
|
IPL_RB_COMPONENT_FLAG_SIGNED |
|
|
IPL_RB_COMPONENT_FLAG_VERIFIED,
|
|
IPL_RB_CERT_UNKNOWN);
|
|
return kexec_add_buffer(&buf);
|
|
}
|
|
|
|
static void *s390_image_load(struct kimage *image,
|
|
char *kernel, unsigned long kernel_len,
|
|
char *initrd, unsigned long initrd_len,
|
|
char *cmdline, unsigned long cmdline_len)
|
|
{
|
|
return kexec_file_add_components(image, kexec_file_add_kernel_image);
|
|
}
|
|
|
|
static int s390_image_probe(const char *buf, unsigned long len)
|
|
{
|
|
/* Can't reliably tell if an image is valid. Therefore give the
|
|
* user whatever he wants.
|
|
*/
|
|
return 0;
|
|
}
|
|
|
|
const struct kexec_file_ops s390_kexec_image_ops = {
|
|
.probe = s390_image_probe,
|
|
.load = s390_image_load,
|
|
#ifdef CONFIG_KEXEC_SIG
|
|
.verify_sig = s390_verify_sig,
|
|
#endif /* CONFIG_KEXEC_SIG */
|
|
};
|