Files
linux/include/uapi/linux
Marc Kleine-Budde f5076c6ba0 can: uapi: can.h: mark union inside struct can_frame packed
In commit ea7800565a ("can: add optional DLC element to Classical
CAN frame structure") the struct can_frame::can_dlc was put into an
anonymous union with another u8 variable.

For various reasons some members in struct can_frame and canfd_frame
including the first 8 byes of data are expected to have the same
memory layout. This is enforced by a BUILD_BUG_ON check in af_can.c.

Since the above mentioned commit this check fails on ARM kernels
compiled with the ARM OABI (which means CONFIG_AEABI not set). In this
case -mabi=apcs-gnu is passed to the compiler, which leads to a
structure size boundary of 32, instead of 8 compared to CONFIG_AEABI
enabled. This means the the union in struct can_frame takes 4 bytes
instead of the expected 1.

Rong Chen illustrates the problem with pahole in the ARM OABI case:

| struct can_frame {
|          canid_t                    can_id;               /* 0     4 */
|          union {
|                  __u8               len;                  /* 4     1 */
|                  __u8               can_dlc;              /* 4     1 */
|          };                                               /* 4     4 */
|          __u8                       __pad;                /* 8     1 */
|          __u8                       __res0;               /* 9     1 */
|          __u8                       len8_dlc;             /* 10    1 */
|
|          /* XXX 5 bytes hole, try to pack */
|
|          __u8                       data[8]
| __attribute__((__aligned__(8))); /*    16     8 */
|
|          /* size: 24, cachelines: 1, members: 6 */
|          /* sum members: 19, holes: 1, sum holes: 5 */
|          /* forced alignments: 1, forced holes: 1, sum forced holes: 5 */
|          /* last cacheline: 24 bytes */
| } __attribute__((__aligned__(8)));

Marking the anonymous union as __attribute__((packed)) fixes the
BUILD_BUG_ON problem on these compilers.

Fixes: ea7800565a ("can: add optional DLC element to Classical CAN frame structure")
Reported-by: kernel test robot <lkp@intel.com>
Suggested-by: Rong Chen <rong.a.chen@intel.com>
Link: https://lore.kernel.org/linux-can/2c82ec23-3551-61b5-1bd8-178c3407ee83@hartkopp.net/
Link: https://lore.kernel.org/r/20210325125850.1620-3-socketcan@hartkopp.net
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
2021-03-29 09:51:49 +02:00
..
2020-08-22 10:53:12 +01:00
2021-01-25 18:44:44 +01:00
2020-05-28 11:22:14 +02:00
2020-12-28 14:21:31 +00:00
2021-01-18 18:38:47 +01:00
2019-12-18 18:07:31 +01:00
2021-02-09 10:58:19 +01:00
2020-08-12 10:58:00 -07:00
2019-03-07 18:32:01 -08:00
2020-10-09 12:47:02 -06:00
2020-12-08 15:54:16 +01:00
2019-10-09 22:31:14 -04:00
2019-09-25 17:51:39 -07:00
2019-08-02 14:44:02 +10:00
2020-04-27 16:29:41 +05:30
2020-07-19 19:20:22 -07:00
2020-06-24 21:34:11 +02:00
2020-05-14 16:44:25 +02:00
2019-03-27 13:30:07 -07:00
2020-05-28 22:09:47 -04:00
2018-06-18 15:11:53 +10:00
2021-02-08 13:01:24 +01:00
2020-07-19 19:20:22 -07:00
2018-09-05 22:27:11 -07:00
2020-07-13 15:32:56 -07:00
2020-04-20 12:43:24 -07:00
2020-07-24 17:12:41 -07:00
2020-08-27 07:55:59 -07:00
2021-02-26 09:41:03 -08:00
2019-09-08 15:37:04 +02:00
2020-11-26 14:19:10 +01:00
2020-05-21 08:20:35 -06:00
2017-11-28 16:54:00 +01:00
2020-03-29 22:30:57 -07:00
2020-08-18 15:44:44 +02:00
2021-01-24 14:43:45 +01:00
2018-01-14 23:06:30 -05:00
2018-01-16 16:47:29 +01:00
2019-10-02 20:32:27 -06:00
2019-01-22 10:21:45 +01:00
2019-07-30 20:34:34 +02:00
2021-03-24 16:44:31 -07:00
2018-03-20 03:17:41 +02:00
2020-03-29 22:30:57 -07:00
2021-01-16 23:19:26 +01:00
2017-11-16 10:49:00 +09:00
2019-12-18 18:07:31 +01:00
2021-01-07 16:17:32 +01:00
2018-09-03 13:29:38 +02:00
2019-12-09 09:59:07 +01:00
2020-03-29 23:29:08 +02:00
2018-02-06 18:32:44 -08:00
2021-02-01 13:20:06 -07:00
2020-10-23 11:55:28 -04:00
2020-10-23 11:55:28 -04:00
2019-08-01 21:49:46 +02:00
2020-07-13 15:32:56 -07:00
2020-06-24 07:51:01 +02:00