Davide Caratti
bb2f930d6d
net/sched: fix infinite loop in sch_fq_pie
this command hangs forever:
# tc qdisc add dev eth0 root fq_pie flows 65536
watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [tc:1028]
[...]
CPU: 1 PID: 1028 Comm: tc Not tainted 5.7.0-rc6+ #167
RIP: 0010:fq_pie_init+0x60e/0x8b7 [sch_fq_pie]
Code: 4c 89 65 50 48 89 f8 48 c1 e8 03 42 80 3c 30 00 0f 85 2a 02 00 00 48 8d 7d 10 4c 89 65 58 48 89 f8 48 c1 e8 03 42 80 3c 30 00 <0f> 85 a7 01 00 00 48 8d 7d 18 48 c7 45 10 46 c3 23 00 48 89 f8 48
RSP: 0018:ffff888138d67468 EFLAGS: 00000246 ORIG_RAX: ffffffffffffff13
RAX: 1ffff9200018d2b2 RBX: ffff888139c1c400 RCX: ffffffffffffffff
RDX: 000000000000c5e8 RSI: ffffc900000e5000 RDI: ffffc90000c69590
RBP: ffffc90000c69580 R08: fffffbfff79a9699 R09: fffffbfff79a9699
R10: 0000000000000700 R11: fffffbfff79a9698 R12: ffffc90000c695d0
R13: 0000000000000000 R14: dffffc0000000000 R15: 000000002347c5e8
FS: 00007f01e1850e40(0000) GS:ffff88814c880000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000000067c340 CR3: 000000013864c000 CR4: 0000000000340ee0
Call Trace:
qdisc_create+0x3fd/0xeb0
tc_modify_qdisc+0x3be/0x14a0
rtnetlink_rcv_msg+0x5f3/0x920
netlink_rcv_skb+0x121/0x350
netlink_unicast+0x439/0x630
netlink_sendmsg+0x714/0xbf0
sock_sendmsg+0xe2/0x110
____sys_sendmsg+0x5b4/0x890
___sys_sendmsg+0xe9/0x160
__sys_sendmsg+0xd3/0x170
do_syscall_64+0x9a/0x370
entry_SYSCALL_64_after_hwframe+0x44/0xa9
we can't accept 65536 as a valid number for 'nflows', because the loop on
'idx' in fq_pie_init() will never end. The extack message is correct, but
it doesn't say that 0 is not a valid number for 'flows': while at it, fix
this also. Add a tdc selftest to check correct validation of 'flows'.
CC: Ivan Vecera <ivecera@redhat.com>
Fixes: ec97ecf1eb ("net: sched: add Flow Queue PIE packet scheduler")
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Reviewed-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-05-27 11:11:18 -07:00
..
2020-04-03 13:12:26 -07:00
2020-03-25 11:50:48 +01:00
2020-05-20 20:21:53 -07:00
2020-03-25 11:50:48 +01:00
2020-03-25 11:50:48 +01:00
2020-04-03 13:12:26 -07:00
2020-04-03 13:12:26 -07:00
2019-01-25 14:57:45 -07:00
2018-05-30 15:21:52 -06:00
2020-05-08 09:40:58 -06:00
2020-05-22 16:08:14 -07:00
2020-03-25 11:50:48 +01:00
2020-03-25 11:50:48 +01:00
2020-05-07 19:27:21 -07:00
2020-03-20 14:54:04 +01:00
2020-05-15 12:57:50 -07:00
2020-03-25 11:50:48 +01:00
2020-04-23 17:23:20 -06:00
2020-03-25 11:50:48 +01:00
2020-04-23 17:23:20 -06:00
2020-04-14 10:24:28 -06:00
2020-03-25 11:50:48 +01:00
2020-03-25 11:50:48 +01:00
2019-08-29 12:45:30 -04:00
2020-04-10 15:36:22 -07:00
2020-04-14 09:49:13 -06:00
2020-05-16 13:39:22 -07:00
2019-11-07 14:46:08 -07:00
2020-02-20 08:56:42 -07:00
2020-05-08 09:46:17 -06:00
2018-05-30 15:29:06 -06:00
2020-03-25 11:50:48 +01:00
2020-03-25 11:50:48 +01:00
2020-04-23 17:23:20 -06:00
2018-09-05 10:58:31 -06:00
2020-03-25 11:50:48 +01:00
2020-03-25 11:50:48 +01:00
2020-05-15 10:33:56 -07:00
2020-03-24 20:00:12 +01:00
2020-05-08 09:42:14 -06:00
2019-07-21 09:46:59 -07:00
2020-03-25 11:50:48 +01:00
2020-03-25 13:50:34 +01:00
2020-04-04 10:08:18 -07:00
2020-04-09 11:01:42 -07:00
2020-03-25 11:50:48 +01:00
2020-03-25 11:50:48 +01:00
2020-03-25 11:50:48 +01:00
2020-03-25 11:50:48 +01:00
2020-04-03 13:12:26 -07:00
2020-04-03 13:12:26 -07:00
2020-03-13 13:29:22 -06:00
2020-03-25 11:50:48 +01:00
2020-03-25 11:50:48 +01:00
2020-03-25 11:50:48 +01:00
2020-04-14 09:49:51 -06:00
2020-03-25 11:50:48 +01:00
2020-03-25 11:50:48 +01:00
2020-03-25 11:50:48 +01:00
2020-03-25 11:50:48 +01:00
2019-05-21 10:50:46 +02:00
2020-03-25 11:50:48 +01:00
2019-05-21 10:50:46 +02:00
2020-05-27 11:11:18 -07:00
2020-04-03 13:12:26 -07:00
2020-03-25 11:50:48 +01:00
2020-03-25 11:50:48 +01:00
2020-04-14 10:08:24 -06:00
2018-05-23 15:24:22 -04:00
2019-05-21 10:50:46 +02:00
2020-03-25 11:50:48 +01:00
2020-05-23 10:26:31 -07:00
2020-03-25 11:50:48 +01:00
2020-05-20 20:55:09 -07:00
2020-04-03 13:12:26 -07:00
2019-07-15 11:03:01 -03:00
2020-04-03 13:12:26 -07:00
2019-11-07 14:43:27 -07:00
2020-04-23 17:23:20 -06:00
2020-04-14 09:44:04 -06:00
2019-11-07 14:43:27 -07:00
2019-04-08 16:44:20 -06:00
2019-07-30 15:46:48 -06:00
2020-04-01 16:09:12 -07:00
2020-04-04 10:08:18 -07:00