Vladimir Oltean 59be75db59
net: enetc: fix MAC Merge layer remaining enabled until a link down event ...
Current enetc_set_mm() is designed to set the priv->active_offloads bit
ENETC_F_QBU for enetc_mm_link_state_update() to act on, but if the link
is already up, it modifies the ENETC_MMCSR_ME ("Merge Enable") bit
directly.
The problem is that it only *sets* ENETC_MMCSR_ME if the link is up, it
doesn't *clear* it if needed. So subsequent enetc_get_mm() calls still
see tx-enabled as true, up until a link down event, which is when
enetc_mm_link_state_update() will get called.
This is not a functional issue as far as I can assess. It has only come
up because I'd like to uphold a simple API rule in core ethtool code:
the pMAC cannot be disabled if TX is going to be enabled. Currently,
the fact that TX remains enabled for longer than expected (after the
enetc_set_mm() call that disables it) is going to violate that rule,
which is how it was caught.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com >
Reviewed-by: Simon Horman <simon.horman@corigine.com >
Signed-off-by: Jakub Kicinski <kuba@kernel.org >
2023-04-20 20:03:21 -07:00
2023-04-09 18:59:13 -07:00
2023-01-22 08:37:23 +01:00
2023-04-14 15:15:32 +02:00
2023-01-27 13:45:52 +01:00
2023-02-24 12:47:33 -08:00
2023-03-16 16:54:38 +09:00
2023-03-21 20:19:28 -07:00
2023-03-29 12:04:10 +02:00
2023-03-31 18:04:59 +03:00
2023-04-10 13:35:54 -07:00
2023-04-10 10:23:15 -07:00
2023-04-13 15:21:56 -07:00
2023-03-12 23:28:10 +02:00
2023-03-21 10:47:06 -07:00
2023-02-21 09:45:13 -08:00
2023-01-22 08:37:23 +01:00
2023-03-18 09:26:40 -04:00
2023-04-11 20:44:25 +02:00
2023-03-07 14:04:13 +01:00
2023-03-05 11:32:30 -08:00
2023-04-04 15:37:25 -07:00
2023-02-25 09:19:23 -08:00
2023-03-31 18:17:21 +05:30
2023-02-17 09:16:34 +01:00
2023-02-21 08:10:03 -08:00
2023-01-27 13:45:52 +01:00
2023-02-04 13:05:42 +00:00
2023-02-24 12:58:55 -08:00
2023-04-14 13:48:56 +02:00
2023-02-24 12:58:55 -08:00
2023-01-27 13:45:38 +01:00
2023-04-07 13:53:16 -07:00
2023-04-13 20:47:58 +02:00
2023-01-27 13:45:52 +01:00
2023-04-13 16:43:38 -07:00
2023-02-24 12:58:55 -08:00
2023-03-06 15:28:03 +00:00
2023-04-07 08:45:17 -07:00
2023-03-21 12:31:02 +00:00
2023-04-15 11:06:49 -07:00
2023-02-28 16:05:01 -08:00
2023-02-21 12:13:58 -08:00
2023-03-28 13:30:55 +02:00
2023-04-13 12:17:32 -03:00
2023-04-01 14:09:51 -07:00
2023-03-13 21:13:48 +02:00
2023-04-04 09:10:55 -03:00
2023-02-24 12:58:55 -08:00
2023-02-25 11:30:21 -08:00
2023-03-24 19:09:57 -07:00
2023-02-23 15:09:31 -08:00
2023-02-25 11:00:06 -08:00
2023-02-23 14:47:13 -06:00
2023-01-27 13:45:52 +01:00
2023-03-31 12:35:03 -07:00
2023-04-02 10:47:03 -07:00
2023-03-13 21:13:49 +02:00
2023-04-05 11:43:51 +02:00
2023-03-20 09:08:48 +00:00
2023-03-09 21:58:45 +01:00
2023-03-23 12:02:00 +01:00
2023-01-19 17:16:05 +01:00
2023-04-15 16:55:09 -07:00
2023-04-20 20:03:21 -07:00
2023-03-17 16:29:25 -07:00
2023-02-25 11:48:02 -08:00
2023-04-14 07:13:48 +02:00
2023-03-10 10:55:49 +01:00
2023-04-13 15:21:56 -07:00
2023-02-16 13:48:53 +01:00
2023-02-24 12:47:33 -08:00
2023-04-11 11:59:49 -07:00
2023-02-24 12:58:55 -08:00
2023-03-27 17:31:22 +02:00
2023-03-20 09:08:48 +00:00
2023-04-11 22:45:42 +02:00
2023-04-06 10:13:23 -07:00
2023-03-12 23:28:04 +01:00
2023-03-03 10:30:58 -08:00
2023-01-19 16:04:35 +01:00
2023-03-30 14:43:03 -07:00
2023-03-23 14:44:43 +01:00
2023-01-27 13:45:52 +01:00
2023-04-11 12:41:59 +01:00
2023-02-27 10:04:49 -08:00
2023-02-26 12:10:28 -08:00
2023-03-03 09:15:50 -08:00
2023-03-30 14:43:03 -07:00
2023-02-09 16:51:39 -08:00
2023-04-20 16:29:51 -07:00
2023-03-01 09:44:22 -08:00
2023-01-27 13:45:52 +01:00
2023-03-06 20:13:06 -08:00
2023-02-24 17:29:52 -08:00
2023-04-19 13:49:31 -07:00
2023-01-27 13:45:52 +01:00
2023-01-27 13:45:52 +01:00
2023-03-09 10:06:28 +01:00
2023-03-06 16:50:42 -05:00
2023-04-03 17:54:01 +02:00
2023-04-11 18:12:19 +02:00
2023-03-20 19:00:58 +02:00
2023-04-08 12:17:46 -07:00
2023-04-02 21:12:34 -04:00
2023-02-23 17:09:35 -08:00
2023-04-13 16:04:28 -07:00
2023-04-04 14:22:12 -04:00
2023-03-13 12:50:59 -06:00
2023-04-13 16:04:28 -07:00
2023-04-13 20:47:58 +02:00
2023-03-13 13:29:27 +01:00
2023-02-25 11:48:02 -08:00
2023-03-09 21:58:57 +01:00
2023-03-02 11:12:01 -08:00
2023-03-17 10:45:49 -07:00
2023-01-27 13:45:52 +01:00
2023-02-26 11:53:25 -08:00
59be75db59