Tetsuo Handa
57dcd64c7e
cgroup,freezer: hold cpu_hotplug_lock before freezer_mutex
syzbot is reporting circular locking dependency between cpu_hotplug_lock
and freezer_mutex, for commit f5d39b0208 ("freezer,sched: Rewrite core
freezer logic") replaced atomic_inc() in freezer_apply_state() with
static_branch_inc() which holds cpu_hotplug_lock.
cpu_hotplug_lock => cgroup_threadgroup_rwsem => freezer_mutex
cgroup_file_write() {
cgroup_procs_write() {
__cgroup_procs_write() {
cgroup_procs_write_start() {
cgroup_attach_lock() {
cpus_read_lock() {
percpu_down_read(&cpu_hotplug_lock);
}
percpu_down_write(&cgroup_threadgroup_rwsem);
}
}
cgroup_attach_task() {
cgroup_migrate() {
cgroup_migrate_execute() {
freezer_attach() {
mutex_lock(&freezer_mutex);
(...snipped...)
}
}
}
}
(...snipped...)
}
}
}
freezer_mutex => cpu_hotplug_lock
cgroup_file_write() {
freezer_write() {
freezer_change_state() {
mutex_lock(&freezer_mutex);
freezer_apply_state() {
static_branch_inc(&freezer_active) {
static_key_slow_inc() {
cpus_read_lock();
static_key_slow_inc_cpuslocked();
cpus_read_unlock();
}
}
}
mutex_unlock(&freezer_mutex);
}
}
}
Swap locking order by moving cpus_read_lock() in freezer_apply_state()
to before mutex_lock(&freezer_mutex) in freezer_change_state().
Reported-by: syzbot <syzbot+c39682e86c9d84152f93@syzkaller.appspotmail.com>
Link: https://syzkaller.appspot.com/bug?extid=c39682e86c9d84152f93
Suggested-by: Hillf Danton <hdanton@sina.com>
Fixes: f5d39b0208 ("freezer,sched: Rewrite core freezer logic")
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
2023-04-12 07:30:28 -10:00
..
2023-03-06 20:28:00 -08:00
2023-04-12 07:30:28 -10:00
2022-12-01 00:09:20 +01:00
2022-12-02 11:25:00 +01:00
2023-02-22 06:44:48 -08:00
2022-10-03 14:03:25 -07:00
2023-02-24 12:47:33 -08:00
2023-01-01 11:15:05 -08:00
2022-12-21 14:31:52 -08:00
2023-03-05 11:19:16 -08:00
2023-01-02 08:59:33 -08:00
2023-02-23 14:00:10 -08:00
2023-02-21 10:45:51 -08:00
2023-02-23 14:05:08 -08:00
2023-02-15 20:06:26 +01:00
2023-02-23 13:49:45 -08:00
2023-02-02 16:40:07 -08:00
2023-03-14 19:32:38 -07:00
2023-02-21 09:45:13 -08:00
2023-03-14 17:07:54 -07:00
2022-11-30 16:13:18 -08:00
2022-02-03 11:20:34 -08:00
2022-08-22 18:50:06 -04:00
2022-04-25 14:37:28 +02:00
2022-09-01 17:39:30 -04:00
2022-08-29 19:47:03 -04:00
2022-09-07 11:30:15 -04:00
2022-01-11 13:08:21 -08:00
2023-03-01 10:01:22 -08:00
2022-09-26 19:46:09 -07:00
2023-03-01 10:01:22 -08:00
2022-09-26 10:13:13 -07:00
2023-03-14 19:32:38 -07:00
2023-01-13 11:48:18 +01:00
2023-01-13 11:48:15 +01:00
2022-12-02 12:43:02 +01:00
2023-02-02 22:32:59 -08:00
2022-11-01 10:04:52 -07:00
2022-09-26 19:46:07 -07:00
2023-02-21 15:27:48 -08:00
2022-07-05 13:32:59 -07:00
2023-02-08 13:36:22 +01:00
2023-03-08 12:31:34 +01:00
2022-09-07 21:53:50 +02:00
2023-01-22 23:43:34 +09:00
2022-07-15 18:21:49 +00:00
2023-02-09 17:03:20 -08:00
2022-04-15 14:49:55 -07:00
2022-12-01 15:53:05 -08:00
2022-11-12 18:47:36 -08:00
2023-01-13 15:09:08 -08:00
2022-11-15 00:42:02 -08:00
2022-11-15 00:42:02 -08:00
2022-03-31 10:36:55 +02:00
2023-02-09 16:51:39 -08:00
2023-02-23 17:55:40 -08:00
2023-02-02 22:50:05 -08:00
2022-09-11 21:55:06 -07:00
2023-02-02 22:50:05 -08:00
2023-02-21 08:49:16 +09:00
2023-01-20 14:30:45 +01:00
2023-02-02 22:50:02 -08:00
2022-09-11 21:55:12 -07:00
2022-12-23 12:00:24 -08:00
2023-02-02 16:26:06 -08:00
2022-10-25 15:15:52 -07:00
2022-12-19 12:33:32 -06:00
2023-03-02 21:54:23 -08:00
2023-01-25 14:07:21 -08:00
2023-02-23 17:09:35 -08:00
2023-01-18 17:12:37 -08:00
2022-06-29 13:07:16 +02:00
2022-09-11 21:55:12 -07:00
2022-12-27 12:52:10 +01:00
2022-10-04 15:59:36 +02:00
2023-02-09 16:51:39 -08:00
2023-02-17 14:58:01 -08:00
2022-12-27 12:52:12 +01:00
2022-04-11 17:07:29 -07:00
2022-11-09 18:06:35 +00:00
2023-01-13 17:01:06 -08:00
2022-12-27 12:52:11 +01:00
2022-10-10 12:49:34 -07:00
2022-09-11 21:55:10 -07:00
2022-07-05 13:32:59 -07:00
2022-05-08 01:33:09 -07:00
2022-02-25 09:36:06 +01:00
2022-10-17 16:41:16 +02:00
2022-04-05 09:59:38 +02:00
2022-05-24 11:11:13 -07:00
2022-08-20 15:17:45 -07:00
2023-02-23 17:09:35 -08:00
2022-09-08 16:56:45 -07:00
2023-02-21 13:34:07 -08:00
2022-09-11 21:55:10 -07:00
2022-08-29 12:47:15 +01:00
2023-01-05 12:10:35 -08:00
2023-02-18 14:34:36 -05:00
2022-04-29 14:38:03 -07:00
2022-05-18 18:24:57 -05:00
2023-03-03 16:18:19 -08:00
2023-02-02 22:50:04 -08:00
2022-11-30 20:16:49 -04:00
2022-05-19 23:25:47 -04:00
2022-10-23 12:01:01 -07:00
2023-03-08 11:44:45 +01:00
2022-06-23 18:41:40 +02:00
2022-08-06 16:38:17 -07:00
2023-01-13 07:50:40 -10:00