Shay Drory
53d737dfd3
net/mlx5: Unregister devlink params in case interface is down
Currently, in case an interface is down, mlx5 driver doesn't
unregister its devlink params, which leads to this WARN[1].
Fix it by unregistering devlink params in that case as well.
[1]
[ 295.244769 ] WARNING: CPU: 15 PID: 1 at net/core/devlink.c:9042 devlink_free+0x174/0x1fc
[ 295.488379 ] CPU: 15 PID: 1 Comm: shutdown Tainted: G S OE 5.15.0-1017.19.3.g0677e61-bluefield #g0677e61
[ 295.509330 ] Hardware name: https://www.mellanox.com BlueField SoC/BlueField SoC, BIOS 4.2.0.12761 Jun 6 2023
[ 295.543096 ] pc : devlink_free+0x174/0x1fc
[ 295.551104 ] lr : mlx5_devlink_free+0x18/0x2c [mlx5_core]
[ 295.561816 ] sp : ffff80000809b850
[ 295.711155 ] Call trace:
[ 295.716030 ] devlink_free+0x174/0x1fc
[ 295.723346 ] mlx5_devlink_free+0x18/0x2c [mlx5_core]
[ 295.733351 ] mlx5_sf_dev_remove+0x98/0xb0 [mlx5_core]
[ 295.743534 ] auxiliary_bus_remove+0x2c/0x50
[ 295.751893 ] __device_release_driver+0x19c/0x280
[ 295.761120 ] device_release_driver+0x34/0x50
[ 295.769649 ] bus_remove_device+0xdc/0x170
[ 295.777656 ] device_del+0x17c/0x3a4
[ 295.784620 ] mlx5_sf_dev_remove+0x28/0xf0 [mlx5_core]
[ 295.794800 ] mlx5_sf_dev_table_destroy+0x98/0x110 [mlx5_core]
[ 295.806375 ] mlx5_unload+0x34/0xd0 [mlx5_core]
[ 295.815339 ] mlx5_unload_one+0x70/0xe4 [mlx5_core]
[ 295.824998 ] shutdown+0xb0/0xd8 [mlx5_core]
[ 295.833439 ] pci_device_shutdown+0x3c/0xa0
[ 295.841651 ] device_shutdown+0x170/0x340
[ 295.849486 ] __do_sys_reboot+0x1f4/0x2a0
[ 295.857322 ] __arm64_sys_reboot+0x2c/0x40
[ 295.865329 ] invoke_syscall+0x78/0x100
[ 295.872817 ] el0_svc_common.constprop.0+0x54/0x184
[ 295.882392 ] do_el0_svc+0x30/0xac
[ 295.889008 ] el0_svc+0x48/0x160
[ 295.895278 ] el0t_64_sync_handler+0xa4/0x130
[ 295.903807 ] el0t_64_sync+0x1a4/0x1a8
[ 295.911120 ] ---[ end trace 4f1d2381d00d9dce ]---
Fixes: fe578cbb2f ("net/mlx5: Move devlink registration before mlx5_load")
Signed-off-by: Shay Drory <shayd@nvidia.com>
Reviewed-by: Maher Sanalla <msanalla@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
2023-07-26 14:31:05 -07:00
..
2023-07-11 09:23:20 +02:00
2023-07-06 22:25:06 -07:00
2023-07-03 12:56:23 -07:00
2023-06-29 11:00:17 -07:00
2023-07-12 12:05:10 +01:00
2023-07-11 12:15:15 -04:00
2023-07-20 11:26:56 -07:00
2023-07-06 09:56:53 -07:00
2023-06-29 08:09:31 -06:00
2023-07-17 19:40:27 +00:00
2023-07-04 11:07:45 -07:00
2023-06-30 09:37:26 -07:00
2023-06-23 10:29:02 +02:00
2023-07-12 12:45:18 +02:00
2023-07-06 13:18:30 -07:00
2023-06-29 16:03:58 -07:00
2023-06-26 07:54:23 -06:00
2023-07-06 09:48:31 -07:00
2023-07-11 09:23:20 +02:00
2023-06-26 15:09:18 -07:00
2023-06-24 14:03:46 +09:00
2023-07-03 12:46:47 -07:00
2023-07-03 12:46:47 -07:00
2023-06-30 14:57:19 -07:00
2023-07-14 13:19:54 +10:00
2023-07-12 11:56:22 -07:00
2023-06-17 23:09:47 +00:00
2023-07-03 12:56:23 -07:00
2023-07-03 12:46:47 -07:00
2023-07-08 12:28:00 -07:00
2023-06-28 19:09:55 +02:00
2023-07-03 12:56:23 -07:00
2023-06-29 21:01:17 -07:00
2023-06-29 15:28:33 -07:00
2023-07-14 14:53:19 +02:00
2023-06-30 09:37:26 -07:00
2023-07-03 11:26:05 -07:00
2023-06-21 14:08:54 +10:00
2023-06-30 17:35:45 -05:00
2023-07-08 12:08:39 -07:00
2023-07-05 10:42:32 -07:00
2023-07-06 10:06:04 -07:00
2023-07-03 10:55:04 -07:00
2023-07-03 12:46:47 -07:00
2023-06-30 14:06:51 +02:00
2023-06-28 14:02:03 -07:00
2023-07-26 14:31:05 -07:00
2023-06-22 18:40:38 -07:00
2023-07-08 13:55:44 -04:00
2023-06-26 07:54:23 -06:00
2023-07-14 19:57:29 -07:00
2023-06-29 14:58:26 -07:00
2023-06-27 07:35:14 +05:30
2023-06-30 17:14:15 +02:00
2023-07-03 12:46:47 -07:00
2023-07-09 09:35:51 -07:00
2023-07-12 07:41:23 -07:00
2023-07-05 21:38:13 -07:00
2023-07-13 00:05:52 +02:00
2023-07-11 12:15:30 +02:00
2023-07-03 17:23:16 -07:00
2023-06-29 15:22:19 -07:00
2023-07-03 13:17:25 -07:00
2023-07-05 12:55:06 -07:00
2023-07-17 06:15:18 +01:00
2023-07-03 17:03:05 -07:00
2023-06-29 15:22:19 -07:00
2023-07-03 10:43:10 -07:00
2023-07-13 14:21:22 -07:00
2023-06-23 10:27:02 +02:00
2023-07-11 12:38:49 -04:00
2023-07-03 13:23:10 -07:00
2023-06-21 16:31:45 +05:30
2023-07-15 08:51:02 -07:00
2023-07-05 10:42:32 -07:00
2023-07-08 12:35:18 -07:00
2023-06-29 15:22:19 -07:00
2023-06-26 19:41:26 -07:00
2023-06-16 09:53:29 +03:00
2023-07-03 13:14:58 -07:00
2023-07-11 12:15:15 -04:00
2023-07-03 13:23:10 -07:00
2023-07-03 15:38:26 -07:00
2023-06-30 15:22:09 -07:00
2023-07-03 15:38:26 -07:00
2023-07-03 11:31:01 -07:00
2023-06-27 16:46:06 -07:00
2023-06-27 10:47:08 -04:00
2023-06-26 14:30:07 +02:00
2023-07-13 13:39:36 -07:00