Dan Carpenter 49379e6d1e
ataflop: fix error handling in atari_floppy_init() ...
Smatch complains that there is an off by one if the allocation fails in:
DMABuffer = atari_stram_alloc(BUFFER_SIZE+512, "ataflop");
In that situation, "i" would be point to one element beyond the end of
the unit[] array.
There is a second bug because the error handling calls
blk_mq_free_tag_set(&unit[i].tag_set); regardless of whether
"disk->queue" is NULL or non-NULL. So if blk_mq_init_sq_queue() fails,
then that means unit[i].tag_set->tags is NULL and it leads to an Oops.
It's easiest to call put_disk() before the goto to clean up the partial
iteration. Then the earlier unit[] elements are fully allocated so we
can remove the checks whether "disk->queue" is NULL and the code is
simpler.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com >
Signed-off-by: Jens Axboe <axboe@kernel.dk >
2018-11-29 08:16:06 -07:00
2018-11-18 12:21:09 -08:00
2018-11-18 15:46:03 -07:00
2018-10-18 15:39:10 -07:00
2018-11-01 18:34:46 -07:00
2018-10-31 08:54:17 -07:00
2018-11-29 08:16:06 -07:00
2018-10-24 14:43:41 +01:00
2018-10-29 15:16:01 -07:00
2018-10-25 11:17:40 -06:00
2018-10-27 09:24:24 -07:00
2018-11-09 14:13:55 -08:00
2018-11-11 16:41:50 -06:00
2018-11-07 13:31:07 +01:00
2018-11-08 18:53:00 +01:00
2018-11-09 17:35:43 +08:00
2018-10-25 06:50:48 -07:00
2018-11-02 11:17:22 -07:00
2018-11-15 10:04:47 +01:00
2018-10-16 11:13:50 +02:00
2018-10-24 00:41:07 +01:00
2018-10-25 06:50:48 -07:00
2018-11-16 08:52:14 +10:00
2018-11-06 13:57:42 +01:00
2018-10-15 20:54:17 +02:00
2018-11-04 15:55:12 -08:00
2018-10-11 12:12:55 +02:00
2018-11-09 17:56:44 +01:00
2018-11-16 09:17:02 -07:00
2018-10-23 13:32:18 +01:00
2018-10-29 10:38:10 -07:00
2018-10-26 16:25:19 -07:00
2018-10-28 11:35:40 -07:00
2018-10-31 08:54:16 -07:00
2018-11-01 12:38:48 +01:00
2018-11-01 19:58:52 -07:00
2018-11-08 17:49:04 -06:00
2018-11-15 12:13:35 -07:00
2018-10-31 08:54:16 -07:00
2018-10-29 10:30:44 -07:00
2018-11-16 08:34:06 -07:00
2018-10-31 10:53:29 -07:00
2018-11-08 06:17:26 -07:00
2018-10-31 16:47:55 -07:00
2018-11-01 19:58:52 -07:00
2018-11-17 07:20:45 -07:00
2018-11-06 10:38:17 +01:00
2018-10-23 08:45:05 +01:00
2018-11-11 10:19:10 -08:00
2018-10-23 13:28:53 -05:00
2018-11-01 10:33:12 -04:00
2018-11-15 12:13:35 -07:00
2018-11-26 08:25:53 -07:00
2018-10-15 15:56:15 +02:00
2018-11-09 16:41:58 -06:00
2018-10-17 17:22:26 +02:00
2018-11-18 15:46:03 -07:00
2018-10-26 14:36:21 -07:00
2018-10-22 17:30:06 +01:00
2018-10-26 08:14:13 -07:00
2018-11-05 09:33:22 +01:00
2018-11-01 08:42:21 -07:00
2018-10-26 12:09:58 -07:00
2018-10-23 13:32:18 +01:00
2018-10-28 19:20:06 -07:00
2018-10-16 13:16:15 +02:00
2018-10-23 01:54:44 +01:00
2018-10-19 12:54:03 -07:00
2018-10-29 15:16:01 -07:00
2018-11-07 17:13:56 +01:00
2018-11-07 13:42:32 -07:00
2018-11-26 10:34:26 -07:00
2018-10-31 08:54:16 -07:00
2018-11-02 11:22:09 -07:00
2018-10-25 06:19:15 -07:00
2018-10-31 10:53:29 -07:00
2018-11-18 15:46:03 -07:00
2018-10-11 09:16:44 -07:00
2018-10-31 11:28:12 -07:00
2018-11-10 13:32:14 -06:00
2018-11-09 18:49:59 +01:00
2018-10-31 11:01:38 -07:00
2018-11-01 14:42:49 -07:00
2018-10-31 11:41:37 -07:00
2018-10-24 20:57:55 -04:00
2018-10-15 20:50:32 +02:00
2018-10-22 10:16:28 +02:00
2018-11-10 08:58:48 -06:00
49379e6d1e