mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-03-16 07:58:35 -04:00
The drm_exec tests where crashing[0] because of a null dereference. This
is caused by a new access of the `driver` attribute of `struct
drm_driver` on drm_gem_private_object_init(). Alloc the drm_device to
fix that.
[0]
[15:05:24] ================== drm_exec (6 subtests) ===================
[15:05:24] [PASSED] sanitycheck
^CERROR:root:Build interruption occurred. Cleaning console.
[15:05:50] [ERROR] Test: drm_exec: missing expected subtest!
[15:05:50] BUG: kernel NULL pointer dereference, address: 00000000000000b0
[15:05:50] #PF: supervisor read access in kernel mode
[15:05:50] #PF: error_code(0x0000) - not-present page
[15:05:50] PGD 0 P4D 0
[15:05:50] Oops: 0000 [#1] PREEMPT NOPTI
[15:05:50] CPU: 0 PID: 23 Comm: kunit_try_catch Tainted: G N 6.4.0-rc7-02032-ge6303f323b1a #69
[15:05:50] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.2-1.fc37 04/01/2014
[15:05:50] RIP: 0010:drm_gem_private_object_init+0x60/0xc0
Fixes: e6303f323b ("drm: manager to keep track of GPUs VA mappings")
Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net>
Tested-by: Danilo Krummrich <dakr@redhat.com>
Acked-by: Danilo Krummrich <dakr@redhat.com>
Reviewed-by: Maíra Canal <mcanal@igalia.com>
Signed-off-by: Maxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230731182241.240556-1-arthurgrillo@riseup.net
190 lines
4.3 KiB
C
190 lines
4.3 KiB
C
// SPDX-License-Identifier: MIT
|
|
/*
|
|
* Copyright 2022 Advanced Micro Devices, Inc.
|
|
*/
|
|
|
|
#define pr_fmt(fmt) "drm_exec: " fmt
|
|
|
|
#include <kunit/test.h>
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/prime_numbers.h>
|
|
|
|
#include <drm/drm_exec.h>
|
|
#include <drm/drm_device.h>
|
|
#include <drm/drm_drv.h>
|
|
#include <drm/drm_gem.h>
|
|
#include <drm/drm_kunit_helpers.h>
|
|
|
|
#include "../lib/drm_random.h"
|
|
|
|
struct drm_exec_priv {
|
|
struct device *dev;
|
|
struct drm_device *drm;
|
|
};
|
|
|
|
static int drm_exec_test_init(struct kunit *test)
|
|
{
|
|
struct drm_exec_priv *priv;
|
|
|
|
priv = kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL);
|
|
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv);
|
|
|
|
test->priv = priv;
|
|
|
|
priv->dev = drm_kunit_helper_alloc_device(test);
|
|
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv->dev);
|
|
|
|
priv->drm = __drm_kunit_helper_alloc_drm_device(test, priv->dev, sizeof(*priv->drm), 0,
|
|
DRIVER_MODESET);
|
|
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv->drm);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void sanitycheck(struct kunit *test)
|
|
{
|
|
struct drm_exec exec;
|
|
|
|
drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);
|
|
drm_exec_fini(&exec);
|
|
KUNIT_SUCCEED(test);
|
|
}
|
|
|
|
static void test_lock(struct kunit *test)
|
|
{
|
|
struct drm_exec_priv *priv = test->priv;
|
|
struct drm_gem_object gobj = { };
|
|
struct drm_exec exec;
|
|
int ret;
|
|
|
|
drm_gem_private_object_init(priv->drm, &gobj, PAGE_SIZE);
|
|
|
|
drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);
|
|
drm_exec_until_all_locked(&exec) {
|
|
ret = drm_exec_lock_obj(&exec, &gobj);
|
|
drm_exec_retry_on_contention(&exec);
|
|
KUNIT_EXPECT_EQ(test, ret, 0);
|
|
if (ret)
|
|
break;
|
|
}
|
|
drm_exec_fini(&exec);
|
|
}
|
|
|
|
static void test_lock_unlock(struct kunit *test)
|
|
{
|
|
struct drm_exec_priv *priv = test->priv;
|
|
struct drm_gem_object gobj = { };
|
|
struct drm_exec exec;
|
|
int ret;
|
|
|
|
drm_gem_private_object_init(priv->drm, &gobj, PAGE_SIZE);
|
|
|
|
drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);
|
|
drm_exec_until_all_locked(&exec) {
|
|
ret = drm_exec_lock_obj(&exec, &gobj);
|
|
drm_exec_retry_on_contention(&exec);
|
|
KUNIT_EXPECT_EQ(test, ret, 0);
|
|
if (ret)
|
|
break;
|
|
|
|
drm_exec_unlock_obj(&exec, &gobj);
|
|
ret = drm_exec_lock_obj(&exec, &gobj);
|
|
drm_exec_retry_on_contention(&exec);
|
|
KUNIT_EXPECT_EQ(test, ret, 0);
|
|
if (ret)
|
|
break;
|
|
}
|
|
drm_exec_fini(&exec);
|
|
}
|
|
|
|
static void test_duplicates(struct kunit *test)
|
|
{
|
|
struct drm_exec_priv *priv = test->priv;
|
|
struct drm_gem_object gobj = { };
|
|
struct drm_exec exec;
|
|
int ret;
|
|
|
|
drm_gem_private_object_init(priv->drm, &gobj, PAGE_SIZE);
|
|
|
|
drm_exec_init(&exec, DRM_EXEC_IGNORE_DUPLICATES);
|
|
drm_exec_until_all_locked(&exec) {
|
|
ret = drm_exec_lock_obj(&exec, &gobj);
|
|
drm_exec_retry_on_contention(&exec);
|
|
KUNIT_EXPECT_EQ(test, ret, 0);
|
|
if (ret)
|
|
break;
|
|
|
|
ret = drm_exec_lock_obj(&exec, &gobj);
|
|
drm_exec_retry_on_contention(&exec);
|
|
KUNIT_EXPECT_EQ(test, ret, 0);
|
|
if (ret)
|
|
break;
|
|
}
|
|
drm_exec_unlock_obj(&exec, &gobj);
|
|
drm_exec_fini(&exec);
|
|
}
|
|
|
|
|
|
|
|
static void test_prepare(struct kunit *test)
|
|
{
|
|
struct drm_exec_priv *priv = test->priv;
|
|
struct drm_gem_object gobj = { };
|
|
struct drm_exec exec;
|
|
int ret;
|
|
|
|
drm_gem_private_object_init(priv->drm, &gobj, PAGE_SIZE);
|
|
|
|
drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);
|
|
drm_exec_until_all_locked(&exec) {
|
|
ret = drm_exec_prepare_obj(&exec, &gobj, 1);
|
|
drm_exec_retry_on_contention(&exec);
|
|
KUNIT_EXPECT_EQ(test, ret, 0);
|
|
if (ret)
|
|
break;
|
|
}
|
|
drm_exec_fini(&exec);
|
|
}
|
|
|
|
static void test_prepare_array(struct kunit *test)
|
|
{
|
|
struct drm_exec_priv *priv = test->priv;
|
|
struct drm_gem_object gobj1 = { };
|
|
struct drm_gem_object gobj2 = { };
|
|
struct drm_gem_object *array[] = { &gobj1, &gobj2 };
|
|
struct drm_exec exec;
|
|
int ret;
|
|
|
|
drm_gem_private_object_init(priv->drm, &gobj1, PAGE_SIZE);
|
|
drm_gem_private_object_init(priv->drm, &gobj2, PAGE_SIZE);
|
|
|
|
drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT);
|
|
drm_exec_until_all_locked(&exec)
|
|
ret = drm_exec_prepare_array(&exec, array, ARRAY_SIZE(array),
|
|
1);
|
|
KUNIT_EXPECT_EQ(test, ret, 0);
|
|
drm_exec_fini(&exec);
|
|
}
|
|
|
|
static struct kunit_case drm_exec_tests[] = {
|
|
KUNIT_CASE(sanitycheck),
|
|
KUNIT_CASE(test_lock),
|
|
KUNIT_CASE(test_lock_unlock),
|
|
KUNIT_CASE(test_duplicates),
|
|
KUNIT_CASE(test_prepare),
|
|
KUNIT_CASE(test_prepare_array),
|
|
{}
|
|
};
|
|
|
|
static struct kunit_suite drm_exec_test_suite = {
|
|
.name = "drm_exec",
|
|
.init = drm_exec_test_init,
|
|
.test_cases = drm_exec_tests,
|
|
};
|
|
|
|
kunit_test_suite(drm_exec_test_suite);
|
|
|
|
MODULE_AUTHOR("AMD");
|
|
MODULE_LICENSE("GPL and additional rights");
|