Files
linux/include/linux
Kees Cook 4a6f18f286 net/mlx4_core: Avoid impossible mlx4_db_alloc() order value
GCC can see that the value range for "order" is capped, but this leads
it to consider that it might be negative, leading to a false positive
warning (with GCC 15 with -Warray-bounds -fdiagnostics-details):

../drivers/net/ethernet/mellanox/mlx4/alloc.c:691:47: error: array subscript -1 is below array bounds of 'long unsigned int *[2]' [-Werror=array-bounds=]
  691 |                 i = find_first_bit(pgdir->bits[o], MLX4_DB_PER_PAGE >> o);
      |                                    ~~~~~~~~~~~^~~
  'mlx4_alloc_db_from_pgdir': events 1-2
  691 |                 i = find_first_bit(pgdir->bits[o], MLX4_DB_PER_PAGE >> o);                        |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                     |                         |                                                   |                     |                         (2) out of array bounds here
      |                     (1) when the condition is evaluated to true                             In file included from ../drivers/net/ethernet/mellanox/mlx4/mlx4.h:53,
                 from ../drivers/net/ethernet/mellanox/mlx4/alloc.c:42:
../include/linux/mlx4/device.h:664:33: note: while referencing 'bits'
  664 |         unsigned long          *bits[2];
      |                                 ^~~~

Switch the argument to unsigned int, which removes the compiler needing
to consider negative values.

Signed-off-by: Kees Cook <kees@kernel.org>
Link: https://patch.msgid.link/20250210174504.work.075-kees@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2025-02-14 19:47:35 -08:00
..
2024-10-22 15:54:11 +02:00
2024-10-11 14:34:11 -04:00
2024-10-13 17:16:57 +02:00
2024-10-11 14:37:29 +05:30
2024-10-14 23:27:57 +05:30
2024-11-11 10:45:03 +01:00
2024-10-09 15:42:48 +01:00
2025-01-04 15:27:35 -07:00
2024-11-07 14:38:07 -08:00
2024-10-14 18:33:04 -07:00
2025-01-06 07:36:39 -07:00
2024-09-03 21:15:36 -07:00
2024-06-24 18:29:20 +02:00
2024-12-02 12:01:43 +01:00
2025-01-18 12:33:39 -08:00
2024-06-11 12:57:49 -05:00
2024-11-05 13:32:21 +01:00
2024-10-22 11:16:56 +02:00
2024-12-17 09:16:11 +01:00
2024-10-19 14:16:45 +02:00
2024-05-19 14:36:17 -07:00
2025-01-25 20:22:31 -08:00
2024-11-09 14:55:33 +01:00
2024-11-28 14:49:28 +01:00
2025-01-09 10:06:14 +01:00
2024-08-29 10:39:37 +02:00
2025-01-07 18:06:51 -08:00
2024-11-24 17:05:27 -08:00
2024-12-18 09:39:37 +01:00
2024-07-31 13:49:48 +01:00
2024-10-16 21:56:59 +02:00
2024-06-24 22:24:56 -07:00
2025-01-25 08:22:26 +00:00
2024-09-03 21:15:46 -07:00
2024-09-20 18:28:26 +03:00
2024-09-01 20:26:03 -07:00
2024-11-05 16:56:26 -08:00
2024-07-03 19:30:23 -07:00
2025-01-14 19:45:35 +01:00
2024-12-13 08:49:31 -07:00
2024-12-09 13:48:23 -08:00
2025-02-04 11:27:45 -05:00
2024-10-14 16:33:24 -05:00
2024-08-11 17:04:29 +01:00
2025-01-15 15:07:23 -08:00
2024-09-23 15:03:30 -04:00
2024-06-24 22:25:02 -07:00
2024-11-05 16:56:26 -08:00
2025-01-25 20:22:42 -08:00
2024-08-30 08:22:38 +02:00
2024-11-16 10:09:30 -06:00
2024-10-02 16:23:10 -05:00
2025-02-14 17:07:46 -08:00
2024-12-22 11:03:10 +01:00
2025-01-10 11:59:00 +01:00
2025-01-07 15:16:48 +01:00
2024-11-05 12:55:38 +01:00
2025-01-02 10:37:14 -06:00
2024-12-09 14:44:59 -08:00
2025-02-13 08:33:49 -08:00
2025-01-08 14:50:11 -08:00
2024-09-11 20:44:31 -07:00
2024-12-19 19:51:13 -08:00
2025-01-11 20:39:43 +01:00
2024-09-11 20:44:32 -07:00
2025-01-29 09:04:28 -08:00
2024-11-11 00:26:44 -08:00
2024-07-10 07:59:03 +02:00
2024-11-06 12:59:44 -05:00
2024-10-02 16:53:38 +02:00
2024-08-06 13:42:40 +02:00
2024-11-18 11:56:21 +00:00
2024-12-23 08:17:16 -07:00
2024-06-24 18:16:44 +01:00
2024-12-09 14:44:59 -08:00
2024-11-06 12:59:44 -05:00