Files
linux/include/linux
Linus Torvalds 77e02cf57b memblock: introduce saner 'memblock_free_ptr()' interface
The boot-time allocation interface for memblock is a mess, with
'memblock_alloc()' returning a virtual pointer, but then you are
supposed to free it with 'memblock_free()' that takes a _physical_
address.

Not only is that all kinds of strange and illogical, but it actually
causes bugs, when people then use it like a normal allocation function,
and it fails spectacularly on a NULL pointer:

   https://lore.kernel.org/all/20210912140820.GD25450@xsang-OptiPlex-9020/

or just random memory corruption if the debug checks don't catch it:

   https://lore.kernel.org/all/61ab2d0c-3313-aaab-514c-e15b7aa054a0@suse.cz/

I really don't want to apply patches that treat the symptoms, when the
fundamental cause is this horribly confusing interface.

I started out looking at just automating a sane replacement sequence,
but because of this mix or virtual and physical addresses, and because
people have used the "__pa()" macro that can take either a regular
kernel pointer, or just the raw "unsigned long" address, it's all quite
messy.

So this just introduces a new saner interface for freeing a virtual
address that was allocated using 'memblock_alloc()', and that was kept
as a regular kernel pointer.  And then it converts a couple of users
that are obvious and easy to test, including the 'xbc_nodes' case in
lib/bootconfig.c that caused problems.

Reported-by: kernel test robot <oliver.sang@intel.com>
Fixes: 40caa127f3 ("init: bootconfig: Remove all bootconfig data when the init memory is removed")
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2021-09-14 13:23:22 -07:00
..
2021-09-02 22:49:16 +02:00
2021-07-21 19:54:21 -07:00
2021-06-03 14:04:18 -07:00
2021-08-29 14:47:42 +03:00
2021-05-06 19:24:11 -07:00
2021-04-14 16:30:30 +03:00
2021-05-24 21:13:05 -07:00
2021-08-16 10:50:32 -06:00
2021-02-26 09:41:03 -08:00
2021-04-08 16:04:20 -07:00
2021-09-08 15:32:35 -07:00
2021-08-26 16:52:03 -07:00
2021-07-20 09:20:49 -07:00
2021-09-07 21:17:28 +02:00
2021-03-22 03:57:39 +01:00
2021-08-26 15:32:28 -04:00
2021-07-27 11:00:36 +02:00
2021-09-06 07:20:56 -04:00
2021-04-12 15:04:23 +02:00
2021-06-25 19:57:01 -04:00
2021-07-26 15:09:44 +02:00
2021-07-27 20:11:45 +01:00
2021-07-27 20:11:44 +01:00
2021-09-03 09:58:13 -07:00
2021-08-05 11:46:42 +01:00
2021-04-30 11:20:40 -07:00
2021-08-16 21:26:33 -07:00
2021-07-15 10:13:49 -07:00
2021-07-27 17:05:06 +01:00
2021-08-19 09:02:55 +09:00
2021-07-27 09:29:15 +02:00
2021-06-01 10:29:21 +01:00
2021-02-26 09:41:03 -08:00
2021-05-12 20:11:17 +02:00
2021-06-17 13:09:27 -04:00
2021-06-15 17:46:57 +02:00
2021-07-01 11:06:02 -07:00
2021-06-29 10:53:53 -07:00
2021-07-01 11:06:05 -07:00
2021-08-23 13:19:12 +02:00
2021-02-26 09:40:59 -08:00
2021-06-16 17:20:40 -05:00
2021-07-06 10:37:46 -05:00
2021-07-20 06:55:20 -07:00
2021-06-07 14:11:47 -07:00
2021-08-18 22:08:24 +02:00
2021-03-06 12:40:22 +01:00
2021-02-26 09:41:03 -08:00
2021-09-02 21:38:56 +02:00
2021-03-17 14:16:15 -05:00
2021-08-17 17:50:51 +02:00
2021-03-18 12:58:27 -04:00
2021-05-10 16:03:35 -07:00
2021-08-06 13:41:48 -07:00
2021-08-19 09:02:55 +09:00
2021-06-24 15:49:32 +02:00
2021-08-19 09:02:55 +09:00
2021-07-01 11:06:03 -07:00
2021-07-27 12:17:21 +02:00
2021-07-27 12:12:08 +02:00
2021-09-08 15:32:35 -07:00
2021-03-30 17:06:49 -07:00
2021-09-03 19:31:33 -04:00
2021-08-10 11:50:55 -04:00
2021-08-11 06:44:24 -04:00
2021-03-30 13:42:33 -04:00