mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-08-31 08:15:07 -04:00
5329647dad
Since BIG TCP for UDP tunnels will start using len=0 in the UDP header as an indicator of a GSO packet bigger than 65535 bytes, this commit introduces the following getter and setters to use tree-wide, in order to explicitly mark places where len=0 may be expected, and handle them properly: 1. udp_set_len() sets uh->len to its real value if it's not bigger than 65535, and to 0 otherwise: to be used in GSO context with aggregated packets. 2. udp_set_len_short() is to be used when the length is known to fit 16 bits. It WARNs when the caller tries to assign a bigger value if CONFIG_DEBUG_NET=y. 3. udp_get_len_short() returns len in host byte order: to be used on the RX side to deal with non-aggregated packets, or to access the raw value of the len field. 4. udp_get_len() decodes uh->len set by udp_set_len(). It checks whether the packet is GSO to guard from malformed packets. At the moment udp_set_len() is not used, a following commit will start using it after enabling len>65535 for GSO. Raw uh->len (in network byte order) is still accessed in a few places for checksum calculation purposes, and to decode len=0 in udpv6_rcv for jumbograms. udp_rcv and udpv6_rcv will be addressed by the commit that starts using udp_set_len() to set UDP len=0 for BIG TCP packets in UDP tunnels. Signed-off-by: Alice Mikityanska <alice@isovalent.com> Reviewed-by: Willem de Bruijn <willemb@google.com> Acked-by: Jason A. Donenfeld <Jason@zx2c4.com> Link: https://patch.msgid.link/20260710134242.216538-2-alice.kernel@fastmail.im Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
68 lines
1.6 KiB
C
68 lines
1.6 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#undef TRACE_SYSTEM
|
|
#define TRACE_SYSTEM icmp
|
|
|
|
#if !defined(_TRACE_ICMP_H) || defined(TRACE_HEADER_MULTI_READ)
|
|
#define _TRACE_ICMP_H
|
|
|
|
#include <linux/icmp.h>
|
|
#include <linux/tracepoint.h>
|
|
|
|
TRACE_EVENT(icmp_send,
|
|
|
|
TP_PROTO(const struct sk_buff *skb, int type, int code),
|
|
|
|
TP_ARGS(skb, type, code),
|
|
|
|
TP_STRUCT__entry(
|
|
__field(const void *, skbaddr)
|
|
__field(int, type)
|
|
__field(int, code)
|
|
__array(__u8, saddr, 4)
|
|
__array(__u8, daddr, 4)
|
|
__field(__u16, sport)
|
|
__field(__u16, dport)
|
|
__field(unsigned short, ulen)
|
|
),
|
|
|
|
TP_fast_assign(
|
|
struct iphdr *iph = ip_hdr(skb);
|
|
struct udphdr *uh = udp_hdr(skb);
|
|
int proto_4 = iph->protocol;
|
|
__be32 *p32;
|
|
|
|
__entry->skbaddr = skb;
|
|
__entry->type = type;
|
|
__entry->code = code;
|
|
|
|
if (proto_4 != IPPROTO_UDP || (u8 *)uh < skb->head ||
|
|
(u8 *)uh + sizeof(struct udphdr)
|
|
> skb_tail_pointer(skb)) {
|
|
__entry->sport = 0;
|
|
__entry->dport = 0;
|
|
__entry->ulen = 0;
|
|
} else {
|
|
__entry->sport = ntohs(uh->source);
|
|
__entry->dport = ntohs(uh->dest);
|
|
__entry->ulen = udp_get_len_short(uh);
|
|
}
|
|
|
|
p32 = (__be32 *) __entry->saddr;
|
|
*p32 = iph->saddr;
|
|
|
|
p32 = (__be32 *) __entry->daddr;
|
|
*p32 = iph->daddr;
|
|
),
|
|
|
|
TP_printk("icmp_send: type=%d, code=%d. From %pI4:%u to %pI4:%u ulen=%d skbaddr=%p",
|
|
__entry->type, __entry->code,
|
|
__entry->saddr, __entry->sport, __entry->daddr,
|
|
__entry->dport, __entry->ulen, __entry->skbaddr)
|
|
);
|
|
|
|
#endif /* _TRACE_ICMP_H */
|
|
|
|
/* This part must be outside protection */
|
|
#include <trace/define_trace.h>
|
|
|