mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-05-26 23:32:26 -04:00
The refactoring done in commit5c57b1ccec("comedi: comedi_8255: Rework subdevice initialization functions") to the initialization of the io field of struct subdev_8255_private broke all cards using the drivers/comedi/drivers/comedi_8255.c module. Prior to5c57b1ccec, __subdev_8255_init() initialized the io field in the newly allocated struct subdev_8255_private to the non-NULL callback given to the function, otherwise it used a flag parameter to select between subdev_8255_mmio and subdev_8255_io. The refactoring removed that logic and the flag, as subdev_8255_mm_init() and subdev_8255_io_init() now explicitly pass subdev_8255_mmio and subdev_8255_io respectively to __subdev_8255_init(), only __subdev_8255_init() never sets spriv->io to the supplied callback. That spriv->io is NULL leads to a later BUG: BUG: kernel NULL pointer dereference, address: 0000000000000000 PGD 0 P4D 0 Oops: 0010 [#1] SMP PTI CPU: 1 PID: 1210 Comm: systemd-udevd Not tainted 6.7.3-x86_64 #1 Hardware name: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX RIP: 0010:0x0 Code: Unable to access opcode bytes at 0xffffffffffffffd6. RSP: 0018:ffffa3f1c02d7b78 EFLAGS: 00010202 RAX: 0000000000000000 RBX: ffff91f847aefd00 RCX: 000000000000009b RDX: 0000000000000003 RSI: 0000000000000001 RDI: ffff91f840f6fc00 RBP: ffff91f840f6fc00 R08: 0000000000000000 R09: 0000000000000001 R10: 0000000000000000 R11: 000000000000005f R12: 0000000000000000 R13: 0000000000000000 R14: ffffffffc0102498 R15: ffff91f847ce6ba8 FS: 00007f72f4e8f500(0000) GS:ffff91f8d5c80000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffffffffffffd6 CR3: 000000010540e000 CR4: 00000000000406f0 Call Trace: <TASK> ? __die_body+0x15/0x57 ? page_fault_oops+0x2ef/0x33c ? insert_vmap_area.constprop.0+0xb6/0xd5 ? alloc_vmap_area+0x529/0x5ee ? exc_page_fault+0x15a/0x489 ? asm_exc_page_fault+0x22/0x30 __subdev_8255_init+0x79/0x8d [comedi_8255] pci_8255_auto_attach+0x11a/0x139 [8255_pci] comedi_auto_config+0xac/0x117 [comedi] ? __pfx___driver_attach+0x10/0x10 pci_device_probe+0x88/0xf9 really_probe+0x101/0x248 __driver_probe_device+0xbb/0xed driver_probe_device+0x1a/0x72 __driver_attach+0xd4/0xed bus_for_each_dev+0x76/0xb8 bus_add_driver+0xbe/0x1be driver_register+0x9a/0xd8 comedi_pci_driver_register+0x28/0x48 [comedi_pci] ? __pfx_pci_8255_driver_init+0x10/0x10 [8255_pci] do_one_initcall+0x72/0x183 do_init_module+0x5b/0x1e8 init_module_from_file+0x86/0xac __do_sys_finit_module+0x151/0x218 do_syscall_64+0x72/0xdb entry_SYSCALL_64_after_hwframe+0x6e/0x76 RIP: 0033:0x7f72f50a0cb9 Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 47 71 0c 00 f7 d8 64 89 01 48 RSP: 002b:00007ffd47e512d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 RAX: ffffffffffffffda RBX: 0000562dd06ae070 RCX: 00007f72f50a0cb9 RDX: 0000000000000000 RSI: 00007f72f52d32df RDI: 000000000000000e RBP: 0000000000000000 R08: 00007f72f5168b20 R09: 0000000000000000 R10: 0000000000000050 R11: 0000000000000246 R12: 00007f72f52d32df R13: 0000000000020000 R14: 0000562dd06785c0 R15: 0000562dcfd0e9a8 </TASK> Modules linked in: 8255_pci(+) comedi_8255 comedi_pci comedi intel_gtt e100(+) acpi_cpufreq rtc_cmos usbhid CR2: 0000000000000000 ---[ end trace 0000000000000000 ]--- RIP: 0010:0x0 Code: Unable to access opcode bytes at 0xffffffffffffffd6. RSP: 0018:ffffa3f1c02d7b78 EFLAGS: 00010202 RAX: 0000000000000000 RBX: ffff91f847aefd00 RCX: 000000000000009b RDX: 0000000000000003 RSI: 0000000000000001 RDI: ffff91f840f6fc00 RBP: ffff91f840f6fc00 R08: 0000000000000000 R09: 0000000000000001 R10: 0000000000000000 R11: 000000000000005f R12: 0000000000000000 R13: 0000000000000000 R14: ffffffffc0102498 R15: ffff91f847ce6ba8 FS: 00007f72f4e8f500(0000) GS:ffff91f8d5c80000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffffffffffffffd6 CR3: 000000010540e000 CR4: 00000000000406f0 This patch simply corrects the above mistake by initializing spriv->io to the given io callback. Fixes:5c57b1ccec("comedi: comedi_8255: Rework subdevice initialization functions") Signed-off-by: Frej Drejhammar <frej.drejhammar@gmail.com> Cc: stable@vger.kernel.org Acked-by: Ian Abbott <abbotti@mev.co.uk> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Link: https://lore.kernel.org/r/20240211175822.1357-1-frej.drejhammar@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
276 lines
7.5 KiB
C
276 lines
7.5 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* comedi_8255.c
|
|
* Generic 8255 digital I/O support
|
|
*
|
|
* Split from the Comedi "8255" driver module.
|
|
*
|
|
* COMEDI - Linux Control and Measurement Device Interface
|
|
* Copyright (C) 1998 David A. Schleef <ds@schleef.org>
|
|
*/
|
|
|
|
/*
|
|
* Module: comedi_8255
|
|
* Description: Generic 8255 support
|
|
* Author: ds
|
|
* Updated: Fri, 22 May 2015 12:14:17 +0000
|
|
* Status: works
|
|
*
|
|
* This module is not used directly by end-users. Rather, it is used by
|
|
* other drivers to provide support for an 8255 "Programmable Peripheral
|
|
* Interface" (PPI) chip.
|
|
*
|
|
* The classic in digital I/O. The 8255 appears in Comedi as a single
|
|
* digital I/O subdevice with 24 channels. The channel 0 corresponds to
|
|
* the 8255's port A, bit 0; channel 23 corresponds to port C, bit 7.
|
|
* Direction configuration is done in blocks, with channels 0-7, 8-15,
|
|
* 16-19, and 20-23 making up the 4 blocks. The only 8255 mode
|
|
* supported is mode 0.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/comedi/comedidev.h>
|
|
#include <linux/comedi/comedi_8255.h>
|
|
|
|
struct subdev_8255_private {
|
|
unsigned long context;
|
|
int (*io)(struct comedi_device *dev, int dir, int port, int data,
|
|
unsigned long context);
|
|
};
|
|
|
|
#ifdef CONFIG_HAS_IOPORT
|
|
|
|
static int subdev_8255_io(struct comedi_device *dev,
|
|
int dir, int port, int data, unsigned long regbase)
|
|
{
|
|
if (dir) {
|
|
outb(data, dev->iobase + regbase + port);
|
|
return 0;
|
|
}
|
|
return inb(dev->iobase + regbase + port);
|
|
}
|
|
|
|
#endif /* CONFIG_HAS_IOPORT */
|
|
|
|
static int subdev_8255_mmio(struct comedi_device *dev,
|
|
int dir, int port, int data, unsigned long regbase)
|
|
{
|
|
if (dir) {
|
|
writeb(data, dev->mmio + regbase + port);
|
|
return 0;
|
|
}
|
|
return readb(dev->mmio + regbase + port);
|
|
}
|
|
|
|
static int subdev_8255_insn(struct comedi_device *dev,
|
|
struct comedi_subdevice *s,
|
|
struct comedi_insn *insn,
|
|
unsigned int *data)
|
|
{
|
|
struct subdev_8255_private *spriv = s->private;
|
|
unsigned long context = spriv->context;
|
|
unsigned int mask;
|
|
unsigned int v;
|
|
|
|
mask = comedi_dio_update_state(s, data);
|
|
if (mask) {
|
|
if (mask & 0xff)
|
|
spriv->io(dev, 1, I8255_DATA_A_REG,
|
|
s->state & 0xff, context);
|
|
if (mask & 0xff00)
|
|
spriv->io(dev, 1, I8255_DATA_B_REG,
|
|
(s->state >> 8) & 0xff, context);
|
|
if (mask & 0xff0000)
|
|
spriv->io(dev, 1, I8255_DATA_C_REG,
|
|
(s->state >> 16) & 0xff, context);
|
|
}
|
|
|
|
v = spriv->io(dev, 0, I8255_DATA_A_REG, 0, context);
|
|
v |= (spriv->io(dev, 0, I8255_DATA_B_REG, 0, context) << 8);
|
|
v |= (spriv->io(dev, 0, I8255_DATA_C_REG, 0, context) << 16);
|
|
|
|
data[1] = v;
|
|
|
|
return insn->n;
|
|
}
|
|
|
|
static void subdev_8255_do_config(struct comedi_device *dev,
|
|
struct comedi_subdevice *s)
|
|
{
|
|
struct subdev_8255_private *spriv = s->private;
|
|
unsigned long context = spriv->context;
|
|
int config;
|
|
|
|
config = I8255_CTRL_CW;
|
|
/* 1 in io_bits indicates output, 1 in config indicates input */
|
|
if (!(s->io_bits & 0x0000ff))
|
|
config |= I8255_CTRL_A_IO;
|
|
if (!(s->io_bits & 0x00ff00))
|
|
config |= I8255_CTRL_B_IO;
|
|
if (!(s->io_bits & 0x0f0000))
|
|
config |= I8255_CTRL_C_LO_IO;
|
|
if (!(s->io_bits & 0xf00000))
|
|
config |= I8255_CTRL_C_HI_IO;
|
|
|
|
spriv->io(dev, 1, I8255_CTRL_REG, config, context);
|
|
}
|
|
|
|
static int subdev_8255_insn_config(struct comedi_device *dev,
|
|
struct comedi_subdevice *s,
|
|
struct comedi_insn *insn,
|
|
unsigned int *data)
|
|
{
|
|
unsigned int chan = CR_CHAN(insn->chanspec);
|
|
unsigned int mask;
|
|
int ret;
|
|
|
|
if (chan < 8)
|
|
mask = 0x0000ff;
|
|
else if (chan < 16)
|
|
mask = 0x00ff00;
|
|
else if (chan < 20)
|
|
mask = 0x0f0000;
|
|
else
|
|
mask = 0xf00000;
|
|
|
|
ret = comedi_dio_insn_config(dev, s, insn, data, mask);
|
|
if (ret)
|
|
return ret;
|
|
|
|
subdev_8255_do_config(dev, s);
|
|
|
|
return insn->n;
|
|
}
|
|
|
|
static int __subdev_8255_init(struct comedi_device *dev,
|
|
struct comedi_subdevice *s,
|
|
int (*io)(struct comedi_device *dev,
|
|
int dir, int port, int data,
|
|
unsigned long context),
|
|
unsigned long context)
|
|
{
|
|
struct subdev_8255_private *spriv;
|
|
|
|
if (!io)
|
|
return -EINVAL;
|
|
|
|
spriv = comedi_alloc_spriv(s, sizeof(*spriv));
|
|
if (!spriv)
|
|
return -ENOMEM;
|
|
|
|
spriv->context = context;
|
|
spriv->io = io;
|
|
|
|
s->type = COMEDI_SUBD_DIO;
|
|
s->subdev_flags = SDF_READABLE | SDF_WRITABLE;
|
|
s->n_chan = 24;
|
|
s->range_table = &range_digital;
|
|
s->maxdata = 1;
|
|
s->insn_bits = subdev_8255_insn;
|
|
s->insn_config = subdev_8255_insn_config;
|
|
|
|
subdev_8255_do_config(dev, s);
|
|
|
|
return 0;
|
|
}
|
|
|
|
#ifdef CONFIG_HAS_IOPORT
|
|
|
|
/**
|
|
* subdev_8255_io_init - initialize DIO subdevice for driving I/O mapped 8255
|
|
* @dev: comedi device owning subdevice
|
|
* @s: comedi subdevice to initialize
|
|
* @regbase: offset of 8255 registers from dev->iobase
|
|
*
|
|
* Initializes a comedi subdevice as a DIO subdevice driving an 8255 chip.
|
|
*
|
|
* Return: -ENOMEM if failed to allocate memory, zero on success.
|
|
*/
|
|
int subdev_8255_io_init(struct comedi_device *dev, struct comedi_subdevice *s,
|
|
unsigned long regbase)
|
|
{
|
|
return __subdev_8255_init(dev, s, subdev_8255_io, regbase);
|
|
}
|
|
EXPORT_SYMBOL_GPL(subdev_8255_io_init);
|
|
|
|
#endif /* CONFIG_HAS_IOPORT */
|
|
|
|
/**
|
|
* subdev_8255_mm_init - initialize DIO subdevice for driving mmio-mapped 8255
|
|
* @dev: comedi device owning subdevice
|
|
* @s: comedi subdevice to initialize
|
|
* @regbase: offset of 8255 registers from dev->mmio
|
|
*
|
|
* Initializes a comedi subdevice as a DIO subdevice driving an 8255 chip.
|
|
*
|
|
* Return: -ENOMEM if failed to allocate memory, zero on success.
|
|
*/
|
|
int subdev_8255_mm_init(struct comedi_device *dev, struct comedi_subdevice *s,
|
|
unsigned long regbase)
|
|
{
|
|
return __subdev_8255_init(dev, s, subdev_8255_mmio, regbase);
|
|
}
|
|
EXPORT_SYMBOL_GPL(subdev_8255_mm_init);
|
|
|
|
/**
|
|
* subdev_8255_cb_init - initialize DIO subdevice for driving callback-mapped 8255
|
|
* @dev: comedi device owning subdevice
|
|
* @s: comedi subdevice to initialize
|
|
* @io: register I/O call-back function
|
|
* @context: call-back context
|
|
*
|
|
* Initializes a comedi subdevice as a DIO subdevice driving an 8255 chip.
|
|
*
|
|
* The prototype of the I/O call-back function is of the following form:
|
|
*
|
|
* int my_8255_callback(struct comedi_device *dev, int dir, int port,
|
|
* int data, unsigned long context);
|
|
*
|
|
* where 'dev', and 'context' match the values passed to this function,
|
|
* 'port' is the 8255 port number 0 to 3 (including the control port), 'dir'
|
|
* is the direction (0 for read, 1 for write) and 'data' is the value to be
|
|
* written. It should return 0 if writing or the value read if reading.
|
|
*
|
|
*
|
|
* Return: -ENOMEM if failed to allocate memory, zero on success.
|
|
*/
|
|
int subdev_8255_cb_init(struct comedi_device *dev, struct comedi_subdevice *s,
|
|
int (*io)(struct comedi_device *dev, int dir, int port,
|
|
int data, unsigned long context),
|
|
unsigned long context)
|
|
{
|
|
return __subdev_8255_init(dev, s, io, context);
|
|
}
|
|
EXPORT_SYMBOL_GPL(subdev_8255_cb_init);
|
|
|
|
/**
|
|
* subdev_8255_regbase - get offset of 8255 registers or call-back context
|
|
* @s: comedi subdevice
|
|
*
|
|
* Returns the 'regbase' or 'context' parameter that was previously passed to
|
|
* subdev_8255_io_init(), subdev_8255_mm_init(), or subdev_8255_cb_init() to
|
|
* set up the subdevice. Only valid if the subdevice was set up successfully.
|
|
*/
|
|
unsigned long subdev_8255_regbase(struct comedi_subdevice *s)
|
|
{
|
|
struct subdev_8255_private *spriv = s->private;
|
|
|
|
return spriv->context;
|
|
}
|
|
EXPORT_SYMBOL_GPL(subdev_8255_regbase);
|
|
|
|
static int __init comedi_8255_module_init(void)
|
|
{
|
|
return 0;
|
|
}
|
|
module_init(comedi_8255_module_init);
|
|
|
|
static void __exit comedi_8255_module_exit(void)
|
|
{
|
|
}
|
|
module_exit(comedi_8255_module_exit);
|
|
|
|
MODULE_AUTHOR("Comedi https://www.comedi.org");
|
|
MODULE_DESCRIPTION("Comedi: Generic 8255 digital I/O support");
|
|
MODULE_LICENSE("GPL");
|