Chris Wilson 331bf90591
drm/i915/gt: Mark the execlists->active as the primary volatile access ...
Since we want to do a lockless read of the current active request, and
that request is written to by process_csb also without serialisation, we
need to instruct gcc to take care in reading the pointer itself.
Otherwise, we have observed execlists_active() to report 0x40.
[ 2400.760381] igt/para-4098 1..s. 2376479300us : process_csb: rcs0 cs-irq head=3, tail=4
[ 2400.760826] igt/para-4098 1..s. 2376479303us : process_csb: rcs0 csb[4]: status=0x00000001:0x00000000
[ 2400.761271] igt/para-4098 1..s. 2376479306us : trace_ports: rcs0: promote { b9c59:2622, b9c55:2624 }
[ 2400.761726] igt/para-4097 0d... 2376479311us : __i915_schedule: rcs0: -2147483648->3, inflight:0000000000000040, rq:ffff888208c1e940
which is impossible!
The answer is that as we keep the existing execlists->active pointing
into the array as we copy over that array, the unserialised read may see
a partial pointer value.
Fixes: df40306902chris@chris-wilson.co.uk >
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20191125094318.1630806-1-chris@chris-wilson.co.uk
2019-11-25 09:45:37 +00:00
2019-11-14 08:43:07 +10:00
2019-11-14 09:28:46 +10:00
2019-11-14 05:53:10 +10:00
2019-08-14 18:31:10 +02:00
2019-08-14 19:27:26 +02:00
2019-10-17 13:59:16 +02:00
2019-10-11 18:22:50 +03:00
2019-10-24 16:12:30 +02:00
2019-10-23 18:20:05 +02:00
2019-10-24 13:55:56 +02:00
2019-11-14 05:53:10 +10:00
2019-10-28 21:12:27 +09:00
2019-08-28 22:11:03 +02:00
2019-10-24 17:59:45 +02:00
2019-10-24 16:12:36 +02:00
2019-10-21 14:23:25 +02:00
2019-10-04 17:04:05 +01:00
2019-11-25 09:45:37 +00:00
2019-10-03 16:38:50 +02:00
2019-09-19 16:24:24 -07:00
2019-10-17 23:42:02 +08:00
2019-10-03 16:38:50 +02:00
2019-11-08 13:19:55 +10:00
2019-10-10 12:50:02 +02:00
2019-06-30 09:48:05 +02:00
2019-10-17 13:59:16 +02:00
2019-11-13 15:34:15 -05:00
2019-10-14 22:19:32 +02:00
2019-10-24 14:29:48 -04:00
2019-10-23 11:14:11 -04:00
2019-10-23 12:10:05 +02:00
2019-11-14 05:53:10 +10:00
2019-10-24 13:55:56 +02:00
2019-10-25 11:40:51 +02:00
2019-07-17 12:52:55 +02:00
2019-11-14 05:53:10 +10:00
2019-10-16 00:28:32 +03:00
2019-10-23 18:21:01 +02:00
2019-06-05 20:31:04 +02:00
2019-11-07 18:08:07 -05:00
2019-10-04 13:42:33 +01:00
2019-07-15 18:11:31 +02:00
2019-06-05 20:29:57 +02:00
2019-09-16 15:14:43 +02:00
2019-09-16 15:14:10 +02:00
2019-10-10 12:50:03 +02:00
2019-07-17 12:52:55 +02:00
2019-11-01 10:49:29 +01:00
2019-10-11 09:30:53 +10:00
2019-11-20 15:54:38 +02:00
2019-11-14 08:41:23 +01:00
2019-09-08 19:04:23 +02:00
2019-09-16 15:13:02 -07:00
2019-11-14 05:53:10 +10:00
2019-10-29 13:10:07 +01:00
2019-10-23 11:14:11 -04:00
2019-08-13 09:09:30 +02:00
2019-09-24 15:54:08 -07:00
2019-10-22 11:34:03 +02:00
2019-10-10 15:45:35 +02:00
2019-11-14 08:41:36 +01:00
2019-10-24 13:55:56 +02:00
2019-07-22 21:24:10 +02:00
2019-07-19 23:24:16 +02:00
2019-07-16 11:25:02 +02:00
2019-11-14 05:53:10 +10:00
2019-09-18 18:43:36 +02:00
2019-10-03 16:38:50 +02:00
2019-09-23 15:31:53 +08:00
2019-05-27 18:07:03 +02:00
2019-10-09 20:04:55 +02:00
2019-06-13 13:00:29 -04:00
2019-07-15 19:04:27 -07:00
2019-10-25 09:35:06 +02:00
2019-10-03 16:38:50 +02:00
2019-08-01 15:01:29 +02:00
2019-05-27 18:07:03 +02:00
2019-09-20 18:46:18 +03:00
2019-05-27 18:07:03 +02:00
2019-09-16 15:13:02 -07:00
2019-10-03 16:38:50 +02:00
2019-06-08 16:46:37 +02:00
2019-06-13 16:39:16 +02:00
2019-10-08 09:41:06 -04:00
2019-09-30 20:17:31 +03:00
2019-06-14 16:59:51 +02:00
2019-07-16 11:25:02 +02:00
2019-07-25 16:39:35 -04:00
2019-10-08 18:29:00 +02:00
2019-05-06 16:00:48 +03:00
2019-10-23 18:22:10 +02:00
2019-09-03 19:30:06 -04:00
2019-11-06 15:20:37 -05:00
2019-10-03 16:38:50 +02:00
2019-09-30 20:15:53 +03:00
2019-08-07 11:56:48 -04:00
2019-10-02 16:28:55 +03:00
2019-10-23 11:14:11 -04:00
2019-08-28 22:11:03 +02:00
2019-05-30 11:26:37 -07:00
2019-10-28 10:07:54 +01:00
2019-11-07 21:22:15 +00:00
2019-05-27 18:07:03 +02:00
2019-05-20 13:35:56 +02:00
2019-05-27 18:07:03 +02:00
2019-07-22 16:04:53 -04:00
2019-06-19 12:07:29 +02:00
2019-08-13 09:09:30 +02:00
2019-10-29 13:29:21 -05:00
2019-10-17 13:59:16 +02:00
2019-10-25 11:40:51 +02:00
2019-10-29 13:29:21 -05:00
2019-05-27 18:07:03 +02:00
2019-08-06 13:18:42 +05:30
2019-06-17 17:37:01 +02:00
2019-07-22 21:24:10 +02:00
2019-09-18 18:42:21 +02:00
2019-05-27 18:07:03 +02:00
2019-08-22 10:41:06 +03:00
2019-06-19 12:07:29 +02:00
2019-07-16 11:25:02 +02:00
2019-05-27 18:06:47 +02:00
2019-07-16 11:25:02 +02:00
2019-09-30 20:16:28 +03:00
2019-10-22 15:09:15 +02:00
2019-11-07 15:00:16 +02:00
2019-10-04 13:43:43 +01:00
2019-10-23 11:00:41 +02:00
2019-09-18 11:27:18 +02:00
2019-09-19 16:24:24 -07:00
2019-07-16 12:21:41 -07:00
2019-09-20 15:03:42 -04:00
2019-07-01 16:58:09 +02:00
2019-09-08 19:04:01 +02:00
2019-05-27 18:07:03 +02:00
2019-05-27 18:07:03 +02:00
2019-10-17 13:59:16 +02:00
2019-10-02 16:28:55 +03:00
2019-09-16 15:13:53 -07:00
2019-05-27 18:07:03 +02:00
2019-05-27 18:07:03 +02:00
2019-07-16 11:25:02 +02:00
2019-05-27 18:07:03 +02:00
2019-11-06 13:00:21 -05:00
2019-10-24 13:55:56 +02:00
2019-10-18 12:24:56 +02:00
2019-08-06 13:16:54 +05:30
2019-05-27 18:07:03 +02:00
2019-09-03 09:46:18 +02:00
2019-10-08 18:43:26 -04:00
2019-07-16 11:25:02 +02:00
2019-05-27 18:07:03 +02:00
2019-09-12 19:54:42 +02:00
2019-09-23 15:32:53 +08:00
2019-11-15 13:17:39 +02:00
2019-10-03 16:38:50 +02:00
331bf90591