mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-07-27 14:29:59 -04:00
Apply two cleanups suggested by Stanislav and bobby on the original
selftest series:
- Reorder local variable declarations into reverse christmas-tree
order (longest line first). Because that ordering puts socklen_t
optlen before the variable whose size it stores, the
"optlen = sizeof(...)" initializer is moved out of the declaration
to a plain assignment in the test body, as Stanislav suggested.
- Add ASSERT_EQ(optlen, ...) on every error path so the value the
kernel writes back to the userspace optlen is pinned down even
when the syscall returns -1. With do_sock_getsockopt() now writing
opt->optlen back to userspace unconditionally, asserting that the
netlink/vsock error paths leave the original input length untouched
guards against future regressions.
Bobby Eshleman pointed out that
SO_VM_SOCKETS_CONNECT_TIMEOUT_NEW/OLD return a sock_timeval-shaped
payload (16 bytes on 64-bit), which is wider than the u64 case
already covered. Add four tests that exercise this path:
- connect_timeout_new_exact exact-size buffer
- connect_timeout_new_oversize_clamped oversize buffer, clamped
- connect_timeout_new_undersize undersize -> -EINVAL, optlen
untouched
- connect_timeout_old_exact exact-size buffer for OLD optname
Suggested-by: Stanislav Fomichev <sdf@fomichev.me>
Suggested-by: Bobby Eshleman <bobbyeshleman@meta.com>
Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20260507-getsock_two-v2-5-5873111d9c12@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
301 lines
6.1 KiB
C
301 lines
6.1 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Quick test for getsockopt{_iter} tests.
|
|
*
|
|
* Each fixture targets one converted protocol and pins down the
|
|
* returned-length / errno semantics across buffer-size variations,
|
|
* an unknown optname and a bogus level.
|
|
*
|
|
* - netlink: NETLINK_PKTINFO covers the flag-style int path; the
|
|
* NETLINK_LIST_MEMBERSHIPS cases cover the size-discovery path
|
|
* that always reports the required buffer length back via optlen,
|
|
* even when the user buffer is too small to receive any group bits.
|
|
* - vsock: SO_VM_SOCKETS_BUFFER_SIZE covers the u64 path.
|
|
*
|
|
* Author: Breno Leitao <leitao@debian.org>
|
|
*/
|
|
|
|
#include <errno.h>
|
|
#include <stdint.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
#include <linux/netlink.h>
|
|
#include <linux/rtnetlink.h>
|
|
#include <linux/time_types.h>
|
|
#include <linux/vm_sockets.h>
|
|
#include <sys/socket.h>
|
|
#include "kselftest_harness.h"
|
|
|
|
#ifndef AF_VSOCK
|
|
#define AF_VSOCK 40
|
|
#endif
|
|
|
|
/* ---------- netlink ---------- */
|
|
|
|
FIXTURE(netlink)
|
|
{
|
|
int fd;
|
|
};
|
|
|
|
FIXTURE_SETUP(netlink)
|
|
{
|
|
int group = RTNLGRP_LINK;
|
|
|
|
self->fd = socket(AF_NETLINK, SOCK_RAW, NETLINK_ROUTE);
|
|
if (self->fd < 0)
|
|
SKIP(return, "AF_NETLINK socket: %s", strerror(errno));
|
|
|
|
/* Joining a multicast group grows nlk->ngroups so the
|
|
* NETLINK_LIST_MEMBERSHIPS path has a non-zero size to report.
|
|
*/
|
|
if (setsockopt(self->fd, SOL_NETLINK, NETLINK_ADD_MEMBERSHIP,
|
|
&group, sizeof(group)) < 0)
|
|
SKIP(return, "NETLINK_ADD_MEMBERSHIP: %s", strerror(errno));
|
|
}
|
|
|
|
FIXTURE_TEARDOWN(netlink)
|
|
{
|
|
if (self->fd >= 0)
|
|
close(self->fd);
|
|
}
|
|
|
|
TEST_F(netlink, pktinfo_exact)
|
|
{
|
|
socklen_t optlen;
|
|
int val = -1;
|
|
|
|
optlen = sizeof(val);
|
|
|
|
ASSERT_EQ(0, getsockopt(self->fd, SOL_NETLINK, NETLINK_PKTINFO,
|
|
&val, &optlen));
|
|
ASSERT_EQ(sizeof(int), optlen);
|
|
ASSERT_TRUE(val == 0 || val == 1);
|
|
}
|
|
|
|
TEST_F(netlink, pktinfo_oversize_clamped)
|
|
{
|
|
char buf[16] = {};
|
|
socklen_t optlen;
|
|
|
|
optlen = sizeof(buf);
|
|
|
|
ASSERT_EQ(0, getsockopt(self->fd, SOL_NETLINK, NETLINK_PKTINFO,
|
|
buf, &optlen));
|
|
ASSERT_EQ(sizeof(int), optlen);
|
|
}
|
|
|
|
TEST_F(netlink, pktinfo_undersize)
|
|
{
|
|
char buf[2] = {};
|
|
socklen_t optlen;
|
|
|
|
optlen = sizeof(buf);
|
|
|
|
ASSERT_EQ(-1, getsockopt(self->fd, SOL_NETLINK, NETLINK_PKTINFO,
|
|
buf, &optlen));
|
|
ASSERT_EQ(EINVAL, errno);
|
|
ASSERT_EQ(sizeof(buf), optlen);
|
|
}
|
|
|
|
TEST_F(netlink, list_memberships_size_discovery)
|
|
{
|
|
socklen_t optlen = 0;
|
|
char dummy;
|
|
|
|
ASSERT_EQ(0, getsockopt(self->fd, SOL_NETLINK,
|
|
NETLINK_LIST_MEMBERSHIPS,
|
|
&dummy, &optlen));
|
|
ASSERT_GT(optlen, 0);
|
|
ASSERT_EQ(0, optlen % sizeof(__u32));
|
|
}
|
|
|
|
TEST_F(netlink, list_memberships_full_read)
|
|
{
|
|
__u32 buf[64] = {};
|
|
socklen_t optlen;
|
|
|
|
optlen = sizeof(buf);
|
|
|
|
ASSERT_EQ(0, getsockopt(self->fd, SOL_NETLINK,
|
|
NETLINK_LIST_MEMBERSHIPS,
|
|
buf, &optlen));
|
|
ASSERT_GT(optlen, 0);
|
|
ASSERT_LE(optlen, sizeof(buf));
|
|
ASSERT_EQ(0, optlen % sizeof(__u32));
|
|
}
|
|
|
|
TEST_F(netlink, bad_level)
|
|
{
|
|
socklen_t optlen;
|
|
int val;
|
|
|
|
optlen = sizeof(val);
|
|
|
|
ASSERT_EQ(-1, getsockopt(self->fd, SOL_SOCKET + 1, NETLINK_PKTINFO,
|
|
&val, &optlen));
|
|
ASSERT_EQ(ENOPROTOOPT, errno);
|
|
ASSERT_EQ(sizeof(val), optlen);
|
|
}
|
|
|
|
TEST_F(netlink, bad_optname)
|
|
{
|
|
socklen_t optlen;
|
|
int val;
|
|
|
|
optlen = sizeof(val);
|
|
|
|
ASSERT_EQ(-1, getsockopt(self->fd, SOL_NETLINK, 0x7fff,
|
|
&val, &optlen));
|
|
ASSERT_EQ(ENOPROTOOPT, errno);
|
|
ASSERT_EQ(sizeof(val), optlen);
|
|
}
|
|
|
|
/* ---------- vsock ---------- */
|
|
|
|
FIXTURE(vsock)
|
|
{
|
|
int fd;
|
|
};
|
|
|
|
FIXTURE_SETUP(vsock)
|
|
{
|
|
self->fd = socket(AF_VSOCK, SOCK_STREAM, 0);
|
|
if (self->fd < 0)
|
|
SKIP(return, "AF_VSOCK socket: %s", strerror(errno));
|
|
}
|
|
|
|
FIXTURE_TEARDOWN(vsock)
|
|
{
|
|
if (self->fd >= 0)
|
|
close(self->fd);
|
|
}
|
|
|
|
TEST_F(vsock, buffer_size_exact)
|
|
{
|
|
socklen_t optlen;
|
|
uint64_t val = 0;
|
|
|
|
optlen = sizeof(val);
|
|
|
|
ASSERT_EQ(0, getsockopt(self->fd, AF_VSOCK,
|
|
SO_VM_SOCKETS_BUFFER_SIZE,
|
|
&val, &optlen));
|
|
ASSERT_EQ(sizeof(uint64_t), optlen);
|
|
ASSERT_GT(val, 0);
|
|
}
|
|
|
|
TEST_F(vsock, buffer_size_oversize_clamped)
|
|
{
|
|
char buf[16] = {};
|
|
socklen_t optlen;
|
|
|
|
optlen = sizeof(buf);
|
|
|
|
ASSERT_EQ(0, getsockopt(self->fd, AF_VSOCK,
|
|
SO_VM_SOCKETS_BUFFER_SIZE,
|
|
buf, &optlen));
|
|
ASSERT_EQ(sizeof(uint64_t), optlen);
|
|
}
|
|
|
|
TEST_F(vsock, buffer_size_undersize)
|
|
{
|
|
char buf[4] = {};
|
|
socklen_t optlen;
|
|
|
|
optlen = sizeof(buf);
|
|
|
|
ASSERT_EQ(-1, getsockopt(self->fd, AF_VSOCK,
|
|
SO_VM_SOCKETS_BUFFER_SIZE,
|
|
buf, &optlen));
|
|
ASSERT_EQ(EINVAL, errno);
|
|
ASSERT_EQ(sizeof(buf), optlen);
|
|
}
|
|
|
|
TEST_F(vsock, bad_level)
|
|
{
|
|
socklen_t optlen;
|
|
uint64_t val;
|
|
|
|
optlen = sizeof(val);
|
|
|
|
ASSERT_EQ(-1, getsockopt(self->fd, SOL_SOCKET + 1,
|
|
SO_VM_SOCKETS_BUFFER_SIZE,
|
|
&val, &optlen));
|
|
ASSERT_EQ(ENOPROTOOPT, errno);
|
|
ASSERT_EQ(sizeof(val), optlen);
|
|
}
|
|
|
|
TEST_F(vsock, bad_optname)
|
|
{
|
|
socklen_t optlen;
|
|
uint64_t val;
|
|
|
|
optlen = sizeof(val);
|
|
|
|
ASSERT_EQ(-1, getsockopt(self->fd, AF_VSOCK, 0x7fff,
|
|
&val, &optlen));
|
|
ASSERT_EQ(ENOPROTOOPT, errno);
|
|
ASSERT_EQ(sizeof(val), optlen);
|
|
}
|
|
|
|
/* SO_VM_SOCKETS_CONNECT_TIMEOUT_{NEW,OLD} return a sock_timeval-shaped
|
|
* payload, which is wider than u64 on 64-bit. They exercise the path
|
|
* where the protocol's reported lv (16 bytes) is larger than the
|
|
* common 8-byte u64 case covered above.
|
|
*/
|
|
TEST_F(vsock, connect_timeout_new_exact)
|
|
{
|
|
struct __kernel_sock_timeval tv = {};
|
|
socklen_t optlen;
|
|
|
|
optlen = sizeof(tv);
|
|
|
|
ASSERT_EQ(0, getsockopt(self->fd, AF_VSOCK,
|
|
SO_VM_SOCKETS_CONNECT_TIMEOUT_NEW,
|
|
&tv, &optlen));
|
|
ASSERT_EQ(sizeof(tv), optlen);
|
|
}
|
|
|
|
TEST_F(vsock, connect_timeout_new_oversize_clamped)
|
|
{
|
|
char buf[sizeof(struct __kernel_sock_timeval) * 2] = {};
|
|
socklen_t optlen;
|
|
|
|
optlen = sizeof(buf);
|
|
|
|
ASSERT_EQ(0, getsockopt(self->fd, AF_VSOCK,
|
|
SO_VM_SOCKETS_CONNECT_TIMEOUT_NEW,
|
|
buf, &optlen));
|
|
ASSERT_EQ(sizeof(struct __kernel_sock_timeval), optlen);
|
|
}
|
|
|
|
TEST_F(vsock, connect_timeout_new_undersize)
|
|
{
|
|
socklen_t optlen;
|
|
uint64_t val;
|
|
|
|
optlen = sizeof(val);
|
|
|
|
ASSERT_EQ(-1, getsockopt(self->fd, AF_VSOCK,
|
|
SO_VM_SOCKETS_CONNECT_TIMEOUT_NEW,
|
|
&val, &optlen));
|
|
ASSERT_EQ(EINVAL, errno);
|
|
ASSERT_EQ(sizeof(val), optlen);
|
|
}
|
|
|
|
TEST_F(vsock, connect_timeout_old_exact)
|
|
{
|
|
struct __kernel_old_timeval tv = {};
|
|
socklen_t optlen;
|
|
|
|
optlen = sizeof(tv);
|
|
|
|
ASSERT_EQ(0, getsockopt(self->fd, AF_VSOCK,
|
|
SO_VM_SOCKETS_CONNECT_TIMEOUT_OLD,
|
|
&tv, &optlen));
|
|
ASSERT_EQ(sizeof(tv), optlen);
|
|
}
|
|
|
|
TEST_HARNESS_MAIN
|