Arnd Bergmann
2af47c10e8
floppy: fix harmless clang build warning
...
clang warns about unusual code in floppy.c that looks like it
was intended to be a bit mask operation, checking for a specific
bit in the UDP->cmos variable (FLOPPY1_TYPE expands to '4' on
ARM):
drivers/block/floppy.c:3902:17: error: use of logical '&&' with constant operand [-Werror,-Wconstant-logical-operand]
if (!UDP->cmos && FLOPPY1_TYPE)
^ ~~~~~~~~~~~~
drivers/block/floppy.c:3902:17: note: use '&' for a bitwise operation
if (!UDP->cmos && FLOPPY1_TYPE)
The check here is redundant anyway, if FLOPPY1_TYPE is zero, then
assigning it to a zero UDP->cmos field does not change anything,
so removing the extra check here has no effect other than shutting
up the warning.
On x86, this will no longer read a hardware register, as the
FLOPPY1_TYPE macro is not expanded if UDP->cmos is already
zero, but the result is the same.
Cc: Robert Elliott <elliott@hpe.com >
Cc: Keith Busch <kbusch@kernel.org >
Link: https://patchwork.kernel.org/patch/10851841/
Signed-off-by: Arnd Bergmann <arnd@arndb.de >
Signed-off-by: Jens Axboe <axboe@kernel.dk >
2019-06-20 01:36:21 -06:00
..
2019-05-24 17:36:47 +02:00
2019-06-05 17:37:17 +02:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2019-06-13 03:17:11 -06:00
2019-05-30 11:26:41 -07:00
2019-05-30 11:26:32 -07:00
2019-06-13 17:34:56 -10:00
2019-06-20 01:36:21 -06:00
2019-06-05 17:37:06 +02:00
2019-05-30 11:26:41 -07:00
2019-05-21 11:28:39 +02:00
2019-06-05 17:37:18 +02:00
2019-06-05 17:37:18 +02:00
2019-06-05 17:37:07 +02:00
2019-05-30 11:26:35 -07:00
2019-05-21 10:50:46 +02:00
2019-06-05 17:37:17 +02:00
2019-06-05 17:37:16 +02:00
2019-06-05 17:37:17 +02:00
2019-06-13 17:34:56 -10:00
2019-05-24 17:27:11 +02:00
2019-06-05 17:36:37 +02:00
2019-05-21 10:50:46 +02:00
2019-06-08 12:52:42 -07:00
2019-06-08 12:52:42 -07:00
2019-06-05 17:37:17 +02:00
2019-05-30 11:29:53 -07:00
2019-06-05 17:36:37 +02:00
2019-05-30 11:26:35 -07:00
2019-06-05 17:37:18 +02:00
2019-05-24 17:36:45 +02:00
2019-06-08 12:52:42 -07:00
2019-05-30 11:26:41 -07:00
2019-05-21 10:50:46 +02:00
2019-06-14 05:48:29 -10:00
2019-06-08 12:52:42 -07:00
2019-06-13 05:59:05 -10:00
2019-06-05 17:37:07 +02:00
2019-06-05 17:37:05 +02:00
2019-06-08 12:52:42 -07:00
2019-05-21 10:50:46 +02:00
2019-06-12 12:54:06 +02:00
2019-05-21 10:50:46 +02:00
2019-06-05 17:37:06 +02:00
2019-06-05 17:37:06 +02:00
2019-06-05 17:37:18 +02:00
2019-06-08 12:52:42 -07:00
2019-06-05 17:37:17 +02:00
2019-05-21 10:50:46 +02:00
2019-06-14 05:49:35 -10:00
2019-06-05 17:37:17 +02:00
2019-06-05 17:37:06 +02:00
2019-05-31 08:34:32 -07:00
2019-06-05 17:37:17 +02:00
2019-06-05 17:37:14 +02:00
2019-06-05 17:37:10 +02:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:37:17 +02:00
2019-06-15 01:37:35 -06:00
2019-06-12 05:57:05 -10:00
2019-06-05 17:37:07 +02:00
2019-05-28 09:53:54 +02:00
2019-05-21 10:50:46 +02:00
2019-06-05 17:37:18 +02:00
2019-06-08 12:52:42 -07:00
2019-06-08 12:52:42 -07:00
2019-06-05 17:37:17 +02:00
2019-06-08 12:52:42 -07:00
2019-06-05 17:37:15 +02:00
2019-06-05 17:36:37 +02:00
2019-05-21 10:50:46 +02:00
2019-06-13 17:34:56 -10:00
2019-06-07 14:04:28 -06:00
2019-06-05 17:36:38 +02:00
2019-06-05 17:37:16 +02:00
2019-05-21 10:50:46 +02:00
2019-06-08 12:52:42 -07:00
2019-06-08 12:50:36 -07:00
2019-06-13 17:34:56 -10:00
2019-06-05 17:30:27 +02:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:37:18 +02:00
2019-06-05 17:37:18 +02:00
2019-06-05 17:37:17 +02:00
2019-05-30 11:25:19 -07:00
2019-06-05 17:37:18 +02:00
2019-06-05 17:37:04 +02:00
2019-05-24 17:36:45 +02:00
2019-05-30 11:26:39 -07:00
2019-05-30 11:26:39 -07:00
2019-06-05 17:37:10 +02:00
2019-05-30 11:26:37 -07:00
2019-05-21 10:50:46 +02:00
2019-06-10 07:35:55 -10:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:37:15 +02:00
2019-06-05 17:37:17 +02:00
2019-06-07 09:29:14 -07:00
2019-05-24 17:36:45 +02:00
2019-06-08 12:52:42 -07:00
2019-05-21 10:50:46 +02:00
2019-05-21 10:50:46 +02:00
2019-05-21 10:50:46 +02:00
2019-04-25 22:23:06 +02:00
2019-05-21 10:50:46 +02:00
2019-06-05 17:37:14 +02:00
2019-05-21 10:50:46 +02:00
2019-06-10 07:19:56 -10:00
2019-06-05 17:36:37 +02:00
2019-05-21 10:50:46 +02:00
2019-05-31 08:31:45 -07:00
2019-06-05 17:37:06 +02:00
2019-05-21 10:50:46 +02:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:37:15 +02:00
2019-05-21 10:50:46 +02:00
2019-05-24 17:08:18 +02:00
2019-06-05 17:37:06 +02:00
2019-05-29 13:26:32 -07:00
2019-06-05 17:30:29 +02:00
2019-06-06 12:32:37 -06:00
2019-05-27 11:08:23 -04:00
2019-06-05 17:37:18 +02:00
2019-05-21 10:50:46 +02:00
2019-05-27 11:08:22 -04:00
2019-05-21 10:50:46 +02:00
2019-05-24 17:39:00 +02:00
2019-05-30 11:26:32 -07:00
2019-06-08 12:52:42 -07:00
2019-06-05 17:37:18 +02:00
2019-06-11 15:38:34 -10:00
2019-05-21 10:50:46 +02:00
2019-04-25 21:33:37 +02:00
2019-04-25 21:33:37 +02:00