mirrors/linux
2
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git synced 2026-06-05 04:27:04 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
2c6b640ea08bff1a192bf87fa45246ff1e40767c
linux/drivers
History
Or Har-Toov 2c6b640ea0 RDMA/mlx5: Fix unsafe xarray access in implicit ODP handling 
__xa_store() and __xa_erase() were used without holding the proper lock,
which led to a lockdep warning due to unsafe RCU usage.  This patch
replaces them with xa_store() and xa_erase(), which perform the necessary
locking internally.

  =============================
  WARNING: suspicious RCPU usage
  6.14.0-rc7_for_upstream_debug_2025_03_18_15_01 #1 Not tainted
  -----------------------------
  ./include/linux/xarray.h:1211 suspicious rcu_dereference_protected() usage!

  other info that might help us debug this:

  rcu_scheduler_active = 2, debug_locks = 1
  3 locks held by kworker/u136:0/219:
      at: process_one_work+0xbe4/0x15f0
      process_one_work+0x75c/0x15f0
      pagefault_mr+0x9a5/0x1390 [mlx5_ib]

  stack backtrace:
  CPU: 14 UID: 0 PID: 219 Comm: kworker/u136:0 Not tainted
  6.14.0-rc7_for_upstream_debug_2025_03_18_15_01 #1
  Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS
  rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014
  Workqueue: mlx5_ib_page_fault mlx5_ib_eqe_pf_action [mlx5_ib]
  Call Trace:
   dump_stack_lvl+0xa8/0xc0
   lockdep_rcu_suspicious+0x1e6/0x260
   xas_create+0xb8a/0xee0
   xas_store+0x73/0x14c0
   __xa_store+0x13c/0x220
   ? xa_store_range+0x390/0x390
   ? spin_bug+0x1d0/0x1d0
   pagefault_mr+0xcb5/0x1390 [mlx5_ib]
   ? _raw_spin_unlock+0x1f/0x30
   mlx5_ib_eqe_pf_action+0x3be/0x2620 [mlx5_ib]
   ? lockdep_hardirqs_on_prepare+0x400/0x400
   ? mlx5_ib_invalidate_range+0xcb0/0xcb0 [mlx5_ib]
   process_one_work+0x7db/0x15f0
   ? pwq_dec_nr_in_flight+0xda0/0xda0
   ? assign_work+0x168/0x240
   worker_thread+0x57d/0xcd0
   ? rescuer_thread+0xc40/0xc40
   kthread+0x3b3/0x800
   ? kthread_is_per_cpu+0xb0/0xb0
   ? lock_downgrade+0x680/0x680
   ? do_raw_spin_lock+0x12d/0x270
   ? spin_bug+0x1d0/0x1d0
   ? finish_task_switch.isra.0+0x284/0x9e0
   ? lockdep_hardirqs_on_prepare+0x284/0x400
   ? kthread_is_per_cpu+0xb0/0xb0
   ret_from_fork+0x2d/0x70
   ? kthread_is_per_cpu+0xb0/0xb0
   ret_from_fork_asm+0x11/0x20

Fixes: d3d930411c ("RDMA/mlx5: Fix implicit ODP use after free")
Link: https://patch.msgid.link/r/a85ddd16f45c8cb2bc0a188c2b0fcedfce975eb8.1750061791.git.leon@kernel.org
Signed-off-by: Or Har-Toov <ohartoov@nvidia.com>
Reviewed-by: Patrisious Haddad <phaddad@nvidia.com>
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
2025-06-17 14:13:10 -03:00
..
accel
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
accessibility
…
acpi
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
amba
…
android
Merge tag 'char-misc-6.16-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2025-06-06 11:50:47 -07:00
ata
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
atm
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
auxdisplay
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
base
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
bcma
…
block
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
bluetooth
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
bus
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
cache
…
cdrom
cdrom: Remove unnecessary NULL check before unregister_sysctl_table()
2025-05-15 16:25:20 -06:00
cdx
…
char
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
clk
Merge tag 'clk-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux
2025-05-30 09:15:40 -07:00
clocksource
Merge tag 'mfd-next-6.16' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd
2025-06-03 11:53:55 -07:00
comedi
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
connector
…
counter
Merge tag 'counter-updates-for-6.16b' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/wbg/counter into char-misc-next
2025-05-24 08:29:32 +02:00
cpufreq
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
cpuidle
Merge branch 'pm-cpuidle'
2025-05-30 20:21:36 +02:00
crypto
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
cxl
Merge branch 'for-6.16/cxl-features-ras' into cxl-for-next
2025-05-23 13:26:24 -07:00
dax
DAX: warn when kmem regions are truncated for memory block alignment
2025-05-12 23:50:49 -07:00
dca
…
devfreq
…
dio
…
dma
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
dma-buf
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
dpll
…
edac
Merge tag 'cxl-for-6.16' of git://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl
2025-06-03 13:24:14 -07:00
eisa
…
extcon
…
firewire
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
firmware
Merge tag 'kbuild-v6.16' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2025-06-07 10:05:35 -07:00
fpga
Merge tag 'fpga-for-6.16-rc1' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/fpga/linux-fpga into char-misc-next
2025-05-21 14:08:44 +02:00
fsi
…
fwctl
…
gnss
…
gpio
Merge tag 'gpio-updates-for-v6.16-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux
2025-05-27 15:22:01 -07:00
gpu
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
greybus
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
hid
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
hsi
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
hte
…
hv
Merge tag 'hyperv-next-signed-20250602' of git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux
2025-06-03 08:39:20 -07:00
hwmon
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
hwspinlock
…
hwtracing
Merge tag 'coresight-next-v6.16' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/coresight/linux into char-misc-next
2025-05-22 18:04:43 +02:00
i2c
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
i3c
i3c: controllers do not need to depend on I3C
2025-05-24 22:49:07 +02:00
idle
Merge tag 'pm-6.16-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
2025-05-27 16:48:47 -07:00
iio
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
infiniband
RDMA/mlx5: Fix unsafe xarray access in implicit ODP handling
2025-06-17 14:13:10 -03:00
input
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
interconnect
Merge branch 'icc-sa8775p' into icc-next
2025-05-19 17:09:50 +03:00
iommu
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
ipack
…
irqchip
Merge tag 'dmaengine-6.16-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine
2025-06-05 08:49:30 -07:00
isdn
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
leds
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
macintosh
…
mailbox
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
mcb
…
md
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
media
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
memory
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
memstick
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
message
…
mfd
Merge tag 'mfd-next-6.16' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd
2025-06-03 11:53:55 -07:00
misc
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
mmc
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
most
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
mtd
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
mux
…
net
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
nfc
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
ntb
…
nubus
…
nvdimm
…
nvme
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
nvmem
Merge tag 'char-misc-6.16-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2025-06-06 11:50:47 -07:00
of
Merge tag 'mm-stable-2025-05-31-14-50' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2025-05-31 15:44:16 -07:00
opp
OPP: switch to use kmemdup_array()
2025-05-19 15:37:53 +05:30
parisc
…
parport
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
pci
Merge tag 'timers-cleanups-2025-06-08' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2025-06-08 11:33:00 -07:00
pcmcia
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
peci
…
perf
Merge tag 'arm64-upstream' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux
2025-05-28 14:55:35 -07:00
phy
Merge tag 'phy-for-6.16' of git://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy
2025-06-05 08:20:21 -07:00
pinctrl
Merge tag 'pinctrl-v6.16-1' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl
2025-05-30 09:46:28 -07:00
platform
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
pmdomain
pmdomain: ti: Fix STANDBY handling of PER power domain
2025-05-19 16:11:05 +02:00
pnp
…
power
Merge tag 'mm-nonmm-stable-2025-05-31-15-28' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2025-05-31 19:12:53 -07:00
powercap
…
pps
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
ps3
…
ptp
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
pwm
Merge tag 'pwm/for-6.16-rc1-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux
2025-06-06 13:16:50 -07:00
rapidio
…
ras
…
regulator
Merge tag 'regulator-fix-v6.16-merge-window' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator
2025-06-06 13:20:26 -07:00
remoteproc
Merge tag 'rproc-v6.16' of git://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux
2025-06-02 11:04:29 -07:00
reset
…
rpmsg
rpmsg: qcom_smd: Fix uninitialized return variable in __qcom_smd_send()
2025-05-20 21:46:10 -05:00
rtc
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
s390
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
sbus
…
scsi
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
sh
sh: Switch to irq_domain_create_*()
2025-05-16 21:06:11 +02:00
siox
…
slimbus
…
soc
Merge tag 'soc-drivers-6.16' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc
2025-05-31 07:53:30 -07:00
soundwire
Merge tag 'soundwire-6.16-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/soundwire
2025-06-05 08:07:24 -07:00
spi
Merge tag 'spi-v6.16-merge-window' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi
2025-06-06 13:22:31 -07:00
spmi
irqdomain: spmi: Switch to irq_domain_create_tree()
2025-05-21 14:53:17 +02:00
ssb
…
staging
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
target
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
tc
…
tee
…
thermal
Merge tag 'thermal-6.16-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
2025-05-27 16:28:02 -07:00
thunderbolt
Merge tag 'thunderbolt-for-v6.16-rc1' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt into usb-next
2025-05-21 12:26:51 +02:00
tty
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
ufs
Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
2025-06-06 20:02:51 -07:00
uio
Merge tag 'char-misc-6.16-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2025-06-06 11:50:47 -07:00
usb
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
vdpa
vdpa/octeon_ep: Control PCI dev enabling manually
2025-05-27 10:27:53 -04:00
vfio
Merge tag 'pci-v6.16-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci
2025-06-04 11:26:17 -07:00
vhost
Merge tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost
2025-05-29 08:15:35 -07:00
video
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
virt
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
virtio
virtio_rtc: Add RTC class driver
2025-05-27 10:27:54 -04:00
w1
Merge tag 'char-misc-6.16-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2025-06-06 11:50:47 -07:00
watchdog
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
xen
xen/x86: fix initial memory balloon target
2025-05-23 07:09:00 +02:00
zorro
…
Kconfig
…
Makefile
…