Eric Dumazet
27880b0b0d
net/sched: act_ife: avoid possible NULL deref
tcf_ife_encode() must make sure ife_encode() does not return NULL.
syzbot reported:
Oops: general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] SMP KASAN NOPTI
KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007]
RIP: 0010:ife_tlv_meta_encode+0x41/0xa0 net/ife/ife.c:166
CPU: 3 UID: 0 PID: 8990 Comm: syz.0.696 Not tainted syzkaller #0 PREEMPT(full)
Call Trace:
<TASK>
ife_encode_meta_u32+0x153/0x180 net/sched/act_ife.c:101
tcf_ife_encode net/sched/act_ife.c:841 [inline]
tcf_ife_act+0x1022/0x1de0 net/sched/act_ife.c:877
tc_act include/net/tc_wrapper.h:130 [inline]
tcf_action_exec+0x1c0/0xa20 net/sched/act_api.c:1152
tcf_exts_exec include/net/pkt_cls.h:349 [inline]
mall_classify+0x1a0/0x2a0 net/sched/cls_matchall.c:42
tc_classify include/net/tc_wrapper.h:197 [inline]
__tcf_classify net/sched/cls_api.c:1764 [inline]
tcf_classify+0x7f2/0x1380 net/sched/cls_api.c:1860
multiq_classify net/sched/sch_multiq.c:39 [inline]
multiq_enqueue+0xe0/0x510 net/sched/sch_multiq.c:66
dev_qdisc_enqueue+0x45/0x250 net/core/dev.c:4147
__dev_xmit_skb net/core/dev.c:4262 [inline]
__dev_queue_xmit+0x2998/0x46c0 net/core/dev.c:4798
Fixes: 295a6e06d2 ("net/sched: act_ife: Change to use ife module")
Reported-by: syzbot+5cf914f193dffde3bd3c@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/netdev/6970d61d.050a0220.706b.0010.GAE@google.com/T/#u
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Yotam Gigi <yotam.gi@gmail.com>
Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
Link: https://patch.msgid.link/20260121133724.3400020-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2026-01-22 08:01:44 -08:00
..
2025-07-10 15:27:32 -07:00
2025-12-07 08:29:09 -08:00
2025-06-08 09:07:37 +02:00
2025-10-31 17:42:35 -07:00
2025-11-04 19:10:32 -08:00
2025-11-27 12:19:08 -08:00
2025-11-04 19:10:32 -08:00
2025-10-31 06:46:03 -07:00
2026-01-09 16:03:57 -05:00
2026-01-12 16:37:40 -08:00
2026-01-09 17:36:21 -08:00
2025-12-11 01:35:41 -08:00
2026-01-15 09:52:39 +01:00
2026-01-06 00:39:43 +01:00
2026-01-15 19:49:47 -08:00
2025-10-01 09:48:21 +02:00
2025-11-25 19:20:42 -08:00
2025-11-04 12:36:51 +01:00
2026-01-21 19:52:29 -08:00
2025-11-24 19:27:31 -08:00
2025-12-18 12:24:25 +01:00
2025-12-22 12:36:40 +01:00
2025-12-04 11:15:13 +01:00
2025-11-04 19:10:33 -08:00
2026-01-17 16:00:24 -08:00
2026-01-20 18:37:45 -08:00
2025-11-28 19:20:27 -08:00
2025-12-03 17:24:33 -08:00
2025-10-30 09:03:12 +01:00
2026-01-19 09:55:41 -08:00
2025-04-15 17:54:56 -07:00
2025-06-08 09:07:37 +02:00
2025-11-04 19:10:32 -08:00
2026-01-20 10:02:01 +01:00
2025-02-18 10:35:44 +01:00
2025-12-01 13:52:13 -08:00
2025-11-03 17:40:54 -08:00
2025-12-23 09:12:25 +01:00
2025-06-12 18:21:59 -07:00
2026-01-02 10:44:28 +01:00
2025-08-30 10:15:30 -04:00
2025-11-04 19:10:32 -08:00
2026-01-20 19:15:40 -08:00
2025-12-28 09:15:42 +01:00
2026-01-22 12:55:22 +01:00
2025-11-04 19:10:33 -08:00
2025-11-04 19:10:33 -08:00
2024-12-18 19:23:04 -08:00
2025-11-25 19:20:42 -08:00
2025-11-04 19:10:32 -08:00
2025-11-04 19:10:32 -08:00
2025-09-22 17:40:30 -07:00
2025-12-30 11:45:51 +01:00
2026-01-21 19:59:29 -08:00
2026-01-22 08:01:44 -08:00
2026-01-17 15:10:34 -08:00
2025-11-25 19:20:42 -08:00
2025-12-04 11:07:18 -08:00
2025-11-13 12:35:38 -08:00
2025-12-24 09:23:04 -08:00
2025-03-11 11:30:28 +01:00
2025-11-13 12:35:38 -08:00
2025-10-31 06:46:03 -07:00
2026-01-08 08:45:13 -08:00
2026-01-22 15:41:33 +01:00
2026-01-20 10:02:01 +01:00
2025-11-04 19:10:32 -08:00
2025-11-27 12:19:08 -08:00
2025-12-15 11:06:25 +01:00
2025-11-26 13:45:23 -07:00
2025-10-17 16:29:26 -07:00
2024-10-08 15:16:59 +02:00
2025-09-18 12:32:06 +02:00
2025-12-05 15:52:30 -08:00