mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-05-18 06:37:39 -04:00
2b14660c1c
UBSAN reports shift-out-of-bounds in jedec_read_mfr() and jedec_read_id(): UBSAN: shift-out-of-bounds in drivers/mtd/chips/jedec_probe.c:1924:13 shift exponent 32 is too large for 32-bit type 'int' UBSAN: shift-out-of-bounds in drivers/mtd/chips/jedec_probe.c:1940:12 shift exponent 32 is too large for 32-bit type 'int' The JEDEC manufacturer/device ID masking uses: (1 << (cfi->device_type * 8)) - 1 When cfi->device_type is 4, this evaluates to 1 << 32. Since the literal '1' has type int, this is a 32-bit shift and is undefined behavior. Fix it by using a 64-bit literal (1ULL) so the shift is performed in a 64-bit type. Co-developed-by: Hui Peng <benquike@gmail.com> Signed-off-by: Hui Peng <benquike@gmail.com> Co-developed-by: Zhihao Yao (Zephyr) <zhihao.yao@njit.edu> Signed-off-by: Zhihao Yao (Zephyr) <zhihao.yao@njit.edu> Signed-off-by: Chenxi Hou <ch395@njit.edu> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>