Johannes Berg 1d8dc3d3c8
rhashtable: don't attempt to grow when at max_size ...
The conversion of mac80211's station table to rhashtable had a bug
that I found by accident in code review, that hadn't been found as
rhashtable apparently managed to have a maximum hash chain length
of one (!) in all our testing.
In order to test the bug and verify the fix I set my rhashtable's
max_size very low (4) in order to force getting hash collisions.
At that point, rhashtable WARNed in rhashtable_insert_rehash() but
didn't actually reject the hash table insertion. This caused it to
lose insertions - my master list of stations would have 9 entries,
but the rhashtable only had 5. This may warrant a deeper look, but
that WARN_ON() just shouldn't happen.
Fix this by not returning true from rht_grow_above_100() when the
rhashtable's max_size has been reached - in this case the user is
explicitly configuring it to be at most that big, so even if it's
now above 100% it shouldn't attempt to resize.
This fixes the "lost insertion" issue and consequently allows my
code to display its error (and verify my fix for it.)
Signed-off-by: Johannes Berg <johannes.berg@intel.com >
Acked-by: Thomas Graf <tgraf@suug.ch >
Signed-off-by: David S. Miller <davem@davemloft.net >
2015-04-24 11:38:12 -04:00
2015-04-22 09:24:55 -07:00
2015-03-29 16:17:10 +01:00
2015-04-17 15:50:54 -04:00
2015-04-22 09:18:17 -07:00
2015-04-02 16:25:04 -04:00
2015-04-02 16:33:43 -04:00
2015-04-17 11:48:01 +02:00
2015-03-31 13:58:35 -04:00
2015-04-04 13:26:52 -04:00
2015-04-13 20:08:38 +02:00
2015-04-04 12:47:04 -04:00
2015-04-04 12:52:06 -04:00
2015-04-22 09:04:39 -07:00
2015-04-06 17:46:27 +02:00
2015-04-10 19:16:03 +01:00
2015-04-15 09:00:47 -07:00
2015-03-31 14:15:08 -04:00
2015-04-07 11:17:34 +02:00
2015-04-15 16:35:22 -07:00
2015-04-03 23:23:37 +02:00
2015-03-25 20:28:11 -04:00
2015-03-27 13:44:43 +00:00
2015-03-27 11:59:22 -04:00
2015-04-01 17:22:00 +02:00
2015-04-17 09:03:56 -04:00
2015-04-17 09:03:53 -04:00
2015-04-08 09:41:41 -07:00
2015-04-17 08:31:12 -06:00
2015-04-02 13:25:49 +02:00
2015-04-14 15:44:14 -04:00
2015-04-15 16:35:22 -07:00
2015-04-14 16:49:03 -07:00
2015-04-10 17:45:30 -07:00
2015-04-03 08:44:37 +02:00
2015-04-14 16:49:04 -07:00
2015-04-15 16:35:17 -07:00
2015-03-27 09:42:01 +01:00
2015-03-26 16:16:20 +01:00
2015-04-13 10:19:30 +02:00
2015-04-03 13:15:50 +02:00
2015-04-16 12:33:51 +09:30
2015-04-15 16:35:22 -07:00
2015-03-31 21:21:03 +08:00
2015-04-15 15:05:28 -04:00
2015-03-23 16:52:26 -04:00
2015-03-30 17:09:41 +09:00
2015-03-31 12:03:49 -04:00
2015-04-14 20:21:54 -07:00
2015-04-07 16:45:33 -07:00
2015-04-01 12:46:22 +01:00
2015-04-14 16:49:05 -07:00
2015-04-10 15:08:57 -07:00
2015-03-24 15:25:15 -04:00
2015-04-09 11:39:55 -05:00
2015-04-17 09:04:38 -04:00
2015-04-14 14:37:47 -07:00
2015-04-03 23:23:51 +02:00
2015-04-14 16:49:04 -07:00
2015-04-13 23:43:34 +02:00
2015-04-14 09:25:26 -07:00
2015-04-02 18:46:20 +02:00
2015-04-15 16:35:19 -07:00
2015-04-03 16:18:02 +02:00
2015-04-14 20:21:54 -07:00
2015-04-10 21:57:22 -07:00
2015-03-29 13:33:22 -07:00
2015-04-08 23:28:28 +02:00
2015-04-21 09:42:58 -07:00
2015-04-18 12:32:59 -07:00
2015-03-31 15:32:16 +02:00
2015-04-15 16:35:22 -07:00
2015-03-23 22:12:08 -04:00
2015-04-11 11:17:28 +02:00
2015-04-03 12:52:29 -04:00
2015-04-09 09:40:24 +02:00
2015-03-26 23:51:36 +01:00
2015-04-15 16:35:20 -07:00
2015-04-21 09:44:55 -03:00
2015-04-17 09:03:55 -04:00
2015-04-15 16:35:17 -07:00
2015-04-14 13:58:48 -07:00
2015-03-31 09:45:50 -06:00
2015-03-30 11:55:48 -07:00
2015-04-13 16:42:16 -07:00
2015-04-14 16:49:06 -07:00
2015-04-14 16:49:00 -07:00
2015-04-15 16:35:18 -07:00
2015-04-14 16:49:05 -07:00
2015-03-25 11:44:52 +01:00
2015-04-17 09:04:07 -04:00
2015-04-15 16:35:20 -07:00
2015-04-15 16:35:16 -07:00
2015-03-31 12:04:12 +02:00
2015-04-14 10:49:03 -07:00
2015-04-18 11:20:31 -04:00
2015-04-11 15:27:37 -04:00
2015-04-23 11:38:14 -04:00
2015-04-08 18:30:21 +02:00
2015-04-07 15:25:55 -04:00
2015-04-13 16:35:16 -04:00
2015-04-15 15:04:27 -04:00
2015-04-14 16:48:59 -07:00
2015-04-07 19:11:06 -06:00
2015-03-26 12:14:56 -05:00
2015-04-18 08:30:10 -04:00
2015-04-14 16:49:05 -07:00
2015-04-15 16:35:19 -07:00
2015-04-08 16:25:25 -05:00
2015-04-09 14:20:11 -05:00
2015-04-16 13:53:32 -05:00
2015-04-02 17:14:17 +02:00
2015-04-12 21:03:31 +02:00
2015-04-03 15:08:20 -04:00
2015-04-15 16:35:23 -07:00
2015-04-03 23:23:51 +02:00
2015-03-31 12:01:19 -04:00
2015-04-15 16:35:23 -07:00
2015-04-24 11:38:12 -04:00
2015-04-15 16:35:19 -07:00
2015-04-03 08:18:24 +02:00
2015-04-13 13:34:40 -04:00
2015-04-15 13:53:55 -07:00
2015-04-15 09:00:47 -07:00
2015-03-26 18:18:20 +01:00
2015-04-10 14:39:53 +02:00
2015-04-20 21:57:26 -04:00
2015-04-14 16:48:59 -07:00
2015-04-20 09:08:49 -07:00
2015-04-11 15:53:35 -04:00
2015-04-14 09:50:27 -07:00
2015-04-16 13:58:42 -04:00
2015-04-16 19:02:04 -04:00
2015-04-15 16:35:17 -07:00
2015-04-17 09:04:07 -04:00
2015-03-25 13:28:58 +01:00
2015-04-07 18:36:39 -04:00
2015-04-03 08:44:37 +02:00
2015-03-27 09:45:07 +01:00
2015-04-03 08:18:34 +02:00
2015-04-08 09:39:56 -04:00
2015-04-15 16:35:22 -07:00
2015-04-15 16:35:22 -07:00
2015-04-11 22:29:44 -04:00
2015-04-07 12:58:35 -05:00
2015-04-17 09:03:54 -04:00
2015-04-14 18:06:47 -07:00
2015-04-07 11:14:38 -06:00
2015-04-02 17:33:15 +02:00
2015-03-24 09:48:14 -07:00
2015-04-15 16:35:20 -07:00
1d8dc3d3c8