Arnaldo Carvalho de Melo 52b1f96784 tools lib api: Fix missing null termination in filename__read_int/ull() ...

filename__read_int() passes a stack buffer to read() using the full
sizeof(line) and then hands it to atoi() without null-terminating.
If a sysfs file fills the 64-byte buffer exactly, atoi() reads past
the array into uninitialized stack memory.

filename__read_ull_base() has the same issue with strtoull().

Fix both by reading sizeof(line) - 1 bytes and explicitly
null-terminating after a successful read.

Fixes: 3a351127cb ("tools lib fs: Adopt filename__read_int from tools/perf/")
Reported-by: sashiko-bot <sashiko-bot@kernel.org>
Assisted-by: Claude:claude-opus-4.6
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

2026-06-10 18:56:01 -03:00

..

Build

tools lib api fs: Move cgroupsfs_find_mountpoint()

2020-03-04 10:34:09 -03:00

cgroup.c

tools api fs: Dynamically allocate cgroupfs mount point cache, removing 4128 bytes from .bss

2023-05-28 10:25:25 -03:00

fs.c

tools lib api: Fix missing null termination in filename__read_int/ull()

2026-06-10 18:56:01 -03:00

fs.h

tools api fs: Make xxx__mountpoint() more scalable

2020-04-16 12:19:12 -03:00

tracing_path.c

perf list: Give clues if failed to open tracing events directory

2024-08-01 12:11:33 -03:00

tracing_path.h

tools lib api fs tracing_path: Add scandir alphasort

2022-11-15 10:24:09 -03:00