Files
linux/fs
Al Viro 1a88b5364b Fix incomplete __mntput locking
Getting this wrong caused

	WARNING: at fs/namespace.c:636 mntput_no_expire+0xac/0xf2()

due to optimistically checking cpu_writer->mnt outside the spinlock.

Here's what we really want:
 * we know that nobody will set cpu_writer->mnt to mnt from now on
 * all changes to that sucker are done under cpu_writer->lock
 * we want the laziest equivalent of
	spin_lock(&cpu_writer->lock);
	if (likely(cpu_writer->mnt != mnt)) {
		spin_unlock(&cpu_writer->lock);
		continue;
	}
	/* do stuff */
  that would make sure we won't miss earlier setting of ->mnt done by
  another CPU.

Anyway, for now we just move the spin_lock() earlier and move the test
into the properly locked region.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Reported-and-tested-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-02-17 14:02:08 -08:00
..
2009-01-22 13:16:01 +03:00
2009-01-22 13:15:56 +03:00
2009-01-22 13:15:56 +03:00
2009-01-22 13:16:01 +03:00
2009-01-22 13:15:57 +03:00
2009-01-22 13:15:57 +03:00
2009-02-09 16:22:03 -05:00
2009-01-22 13:16:01 +03:00
2009-01-22 13:15:58 +03:00
2009-01-22 13:15:57 +03:00
2009-01-22 13:15:55 +03:00
2009-01-22 13:15:58 +03:00
2009-01-22 13:15:57 +03:00
2009-01-22 13:15:57 +03:00
2009-01-22 13:15:59 +03:00
2008-11-14 10:39:25 +11:00
2009-01-22 13:15:55 +03:00
2009-01-11 22:34:01 -05:00
2009-01-09 21:05:21 +00:00
2009-01-22 13:15:54 +03:00
2009-01-22 13:15:58 +03:00
2009-01-22 13:16:00 +03:00
2008-10-17 02:38:36 +11:00
2009-01-22 13:15:55 +03:00
2009-01-22 13:15:58 +03:00
2009-01-22 13:15:59 +03:00
2009-01-22 13:15:53 +03:00
2009-01-22 13:15:59 +03:00
2009-01-22 13:16:01 +03:00
2009-01-22 13:15:58 +03:00
2009-01-22 13:15:59 +03:00
2009-01-29 16:34:30 +02:00
2009-01-22 13:15:55 +03:00
2009-01-22 13:16:00 +03:00
2008-12-31 18:07:43 -05:00
2009-01-03 11:45:54 -08:00
2009-02-06 17:34:07 -08:00
2009-01-30 12:34:36 +01:00
2008-01-30 13:31:46 +01:00
2009-02-05 16:35:52 -08:00
2009-02-07 08:46:18 +11:00
2009-01-16 18:02:10 +01:00
2009-02-07 08:46:18 +11:00
2009-01-06 15:59:09 -08:00
2009-02-07 08:46:18 +11:00
2009-01-22 13:16:01 +03:00
2009-02-17 14:02:08 -08:00