Benjamin Poirier 19110cfbb3
e1000e: Separate signaling for link check/link up ...
Lennart reported the following race condition:
\ e1000_watchdog_task
\ e1000e_has_link
\ hw->mac.ops.check_for_link() === e1000e_check_for_copper_link
/* link is up */
mac->get_link_status = false;
/* interrupt */
\ e1000_msix_other
hw->mac.get_link_status = true;
link_active = !hw->mac.get_link_status
/* link_active is false, wrongly */
This problem arises because the single flag get_link_status is used to
signal two different states: link status needs checking and link status is
down.
Avoid the problem by using the return value of .check_for_link to signal
the link status to e1000e_has_link().
Reported-by: Lennart Sorensen <lsorense@csclub.uwaterloo.ca >
Signed-off-by: Benjamin Poirier <bpoirier@suse.com >
Tested-by: Aaron Brown <aaron.f.brown@intel.com >
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com >
2017-10-10 08:35:01 -07:00
2017-10-04 17:34:41 +01:00
2017-10-03 17:54:24 -07:00
2017-10-02 12:21:30 -07:00
2017-09-18 16:06:00 +02:00
2017-10-03 08:57:07 -07:00
2017-10-06 12:13:50 -07:00
2017-09-10 20:40:00 -07:00
2017-09-24 11:34:28 -07:00
2017-10-04 09:19:13 -07:00
2017-09-25 09:36:15 +02:00
2017-09-26 01:10:08 +02:00
2017-09-19 23:10:51 +02:00
2017-09-20 17:42:42 +08:00
2017-09-14 13:43:16 -07:00
2017-08-28 10:31:08 +09:00
2017-09-07 14:03:05 -07:00
2017-08-21 17:59:38 +02:00
2017-08-25 09:32:27 +09:00
2017-09-14 11:59:30 +02:00
2017-08-28 16:24:22 +02:00
2017-09-19 09:20:33 +02:00
2017-08-28 17:15:16 +02:00
2017-09-07 13:51:13 -07:00
2017-10-06 11:09:47 +10:00
2017-10-05 10:28:12 -07:00
2017-09-22 10:29:54 +02:00
2017-10-01 08:46:54 -07:00
2017-09-22 10:28:00 +02:00
2017-10-07 10:07:51 -07:00
2017-10-03 14:03:31 -05:00
2017-09-05 12:19:08 -07:00
2017-09-25 10:58:22 +02:00
2017-10-04 15:28:49 -04:00
2017-09-22 17:23:41 -10:00
2017-09-27 17:01:35 +02:00
2017-09-25 21:23:44 +02:00
2017-09-20 16:01:36 -07:00
2017-09-23 21:17:43 +02:00
2017-09-01 16:42:54 +10:00
2017-09-07 13:23:37 -07:00
2017-09-05 11:08:17 -07:00
2017-10-06 12:13:50 -07:00
2017-10-04 17:11:53 -07:00
2017-09-10 20:40:00 -07:00
2017-08-29 21:51:45 -04:00
2017-09-14 11:59:30 +02:00
2017-09-29 14:19:44 +10:00
2017-10-04 10:50:36 +02:00
2017-09-27 17:33:28 +02:00
2017-08-29 13:46:35 +02:00
2017-10-10 08:35:01 -07:00
2017-09-18 17:29:01 -07:00
2017-10-04 11:42:53 +02:00
2017-09-18 16:12:26 +02:00
2017-09-12 13:30:06 -07:00
2017-08-24 18:46:44 +02:00
2017-09-05 11:08:17 -07:00
2017-09-25 18:34:54 -05:00
2017-08-29 15:21:53 +02:00
2017-09-22 15:11:46 +01:00
2017-09-15 20:43:33 -07:00
2017-09-12 15:58:45 +02:00
2017-09-27 00:04:43 -07:00
2017-09-14 11:59:30 +02:00
2017-09-09 14:44:39 -07:00
2017-09-08 18:26:51 -07:00
2017-08-22 11:04:51 -07:00
2017-09-11 13:04:32 -07:00
2017-10-03 17:54:24 -07:00
2017-09-07 13:51:13 -07:00
2017-09-09 14:34:38 -07:00
2017-09-21 12:44:01 +02:00
2017-09-04 10:52:30 -07:00
2017-09-13 10:56:00 -07:00
2017-09-23 10:16:53 -07:00
2017-10-07 12:34:16 -07:00
2017-09-15 20:43:33 -07:00
2017-09-05 12:45:03 -07:00
2017-08-28 13:52:22 +02:00
2017-09-25 10:58:22 +02:00
2017-09-14 18:13:32 -07:00
2017-09-08 11:20:04 +08:00
2017-10-09 10:30:41 -07:00
2017-09-18 18:19:21 +02:00
2017-09-28 12:41:56 +03:00
2017-09-18 11:28:23 +02:00
2017-08-30 14:03:42 -06:00
2017-10-09 20:46:39 -07:00
2017-09-14 13:33:33 -07:00
2017-08-29 08:52:51 -05:00
2017-09-07 21:11:05 -07:00
2017-09-09 14:44:39 -07:00
2017-09-15 20:43:33 -07:00
2017-09-29 12:24:28 -07:00
2017-08-24 09:57:28 +02:00
19110cfbb3