mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-08-29 13:57:58 -04:00
The test asserted that the X86_FEATURE_SEV CPUID bit exactly matches whether KVM offers KVM_X86_SEV_VM. That is not an invariant: when all SEV ASIDs are assigned to SEV-SNP, KVM does not offer the SEV VM type even though CPUID reports SEV, so the test aborts on an SNP-only host. Derive SEV availability from KVM_CAP_VM_TYPES (as already done for SEV-ES and SNP), assert only the one-way implication that a type offered by KVM is also reported in CPUID, and TEST_REQUIRE() the SEV VM type so the test skips cleanly when it is unavailable. Reviewed-by: Tycho Andersen (AMD) <tycho@kernel.org> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk> Message-ID: <5d3c345113748f39b7982e365d241abaf3e11086.1784545391.git.dwmw@amazon.co.uk> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
170 lines
4.4 KiB
C
170 lines
4.4 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
#include <linux/kvm.h>
|
|
#include <linux/psp-sev.h>
|
|
#include <stdio.h>
|
|
#include <sys/ioctl.h>
|
|
#include <stdlib.h>
|
|
#include <errno.h>
|
|
#include <pthread.h>
|
|
|
|
#include "test_util.h"
|
|
#include "kvm_util.h"
|
|
#include "processor.h"
|
|
#include "svm_util.h"
|
|
#include "kselftest.h"
|
|
|
|
#define SVM_SEV_FEAT_DEBUG_SWAP 32u
|
|
|
|
/*
|
|
* Some features may have hidden dependencies, or may only work
|
|
* for certain VM types. Err on the side of safety and don't
|
|
* expect that all supported features can be passed one by one
|
|
* to KVM_SEV_INIT2.
|
|
*
|
|
* (Well, right now there's only one...)
|
|
*/
|
|
#define KNOWN_FEATURES SVM_SEV_FEAT_DEBUG_SWAP
|
|
|
|
int kvm_fd;
|
|
u64 supported_vmsa_features;
|
|
bool have_sev_es;
|
|
bool have_snp;
|
|
|
|
static int __sev_ioctl(int vm_fd, int cmd_id, void *data)
|
|
{
|
|
struct kvm_sev_cmd cmd = {
|
|
.id = cmd_id,
|
|
.data = (u64)data,
|
|
.sev_fd = open_sev_dev_path_or_exit(),
|
|
};
|
|
int ret;
|
|
|
|
ret = ioctl(vm_fd, KVM_MEMORY_ENCRYPT_OP, &cmd);
|
|
TEST_ASSERT(ret < 0 || cmd.error == SEV_RET_SUCCESS,
|
|
"%d failed: fw error: %d\n",
|
|
cmd_id, cmd.error);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static void test_init2(unsigned long vm_type, struct kvm_sev_init *init)
|
|
{
|
|
struct kvm_vm *vm;
|
|
int ret;
|
|
|
|
vm = vm_create_barebones_type(vm_type);
|
|
ret = __sev_ioctl(vm->fd, KVM_SEV_INIT2, init);
|
|
TEST_ASSERT(ret == 0,
|
|
"KVM_SEV_INIT2 return code is %d (expected 0), errno: %d",
|
|
ret, errno);
|
|
kvm_vm_free(vm);
|
|
}
|
|
|
|
static void test_init2_invalid(unsigned long vm_type, struct kvm_sev_init *init, const char *msg)
|
|
{
|
|
struct kvm_vm *vm;
|
|
int ret;
|
|
|
|
vm = vm_create_barebones_type(vm_type);
|
|
ret = __sev_ioctl(vm->fd, KVM_SEV_INIT2, init);
|
|
TEST_ASSERT(ret == -1 && errno == EINVAL,
|
|
"KVM_SEV_INIT2 should fail, %s.",
|
|
msg);
|
|
kvm_vm_free(vm);
|
|
}
|
|
|
|
void test_vm_types(void)
|
|
{
|
|
test_init2(KVM_X86_SEV_VM, &(struct kvm_sev_init){});
|
|
|
|
/*
|
|
* TODO: check that unsupported types cannot be created. Probably
|
|
* a separate selftest.
|
|
*/
|
|
if (have_sev_es)
|
|
test_init2(KVM_X86_SEV_ES_VM, &(struct kvm_sev_init){});
|
|
|
|
if (have_snp)
|
|
test_init2(KVM_X86_SNP_VM, &(struct kvm_sev_init){});
|
|
|
|
test_init2_invalid(0, &(struct kvm_sev_init){},
|
|
"VM type is KVM_X86_DEFAULT_VM");
|
|
if (kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(KVM_X86_SW_PROTECTED_VM))
|
|
test_init2_invalid(KVM_X86_SW_PROTECTED_VM, &(struct kvm_sev_init){},
|
|
"VM type is KVM_X86_SW_PROTECTED_VM");
|
|
}
|
|
|
|
void test_flags(u32 vm_type)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < 32; i++)
|
|
test_init2_invalid(vm_type,
|
|
&(struct kvm_sev_init){ .flags = BIT(i) },
|
|
"invalid flag");
|
|
}
|
|
|
|
void test_features(u32 vm_type, u64 supported_features)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < 64; i++) {
|
|
if (!(supported_features & BIT_ULL(i)))
|
|
test_init2_invalid(vm_type,
|
|
&(struct kvm_sev_init){ .vmsa_features = BIT_ULL(i) },
|
|
"unknown feature");
|
|
else if (KNOWN_FEATURES & BIT_ULL(i))
|
|
test_init2(vm_type,
|
|
&(struct kvm_sev_init){ .vmsa_features = BIT_ULL(i) });
|
|
}
|
|
}
|
|
|
|
int main(int argc, char *argv[])
|
|
{
|
|
int kvm_fd = open_kvm_dev_path_or_exit();
|
|
bool have_sev;
|
|
|
|
TEST_REQUIRE(__kvm_has_device_attr(kvm_fd, KVM_X86_GRP_SEV,
|
|
KVM_X86_SEV_VMSA_FEATURES) == 0);
|
|
kvm_device_attr_get(kvm_fd, KVM_X86_GRP_SEV,
|
|
KVM_X86_SEV_VMSA_FEATURES,
|
|
&supported_vmsa_features);
|
|
|
|
/*
|
|
* Whether a VM type is available depends on KVM, not just CPUID: e.g.
|
|
* when all SEV ASIDs are assigned to SEV-SNP, KVM does not offer the
|
|
* SEV VM type even though X86_FEATURE_SEV is set. Derive availability
|
|
* from KVM_CAP_VM_TYPES and only assert the one-way implication that a
|
|
* type offered by KVM must also be reported in CPUID.
|
|
*/
|
|
have_sev = kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(KVM_X86_SEV_VM);
|
|
TEST_ASSERT(!have_sev || kvm_cpu_has(X86_FEATURE_SEV),
|
|
"sev: SEV_VM supported without SEV in CPUID");
|
|
|
|
TEST_REQUIRE(have_sev);
|
|
have_sev_es = kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(KVM_X86_SEV_ES_VM);
|
|
|
|
TEST_ASSERT(!have_sev_es || kvm_cpu_has(X86_FEATURE_SEV_ES),
|
|
"sev-es: SEV_ES_VM supported without SEV_ES in CPUID");
|
|
|
|
have_snp = kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(KVM_X86_SNP_VM);
|
|
TEST_ASSERT(!have_snp || kvm_cpu_has(X86_FEATURE_SEV_SNP),
|
|
"sev-snp: SNP_VM supported without SEV_SNP in CPUID");
|
|
|
|
test_vm_types();
|
|
|
|
test_flags(KVM_X86_SEV_VM);
|
|
if (have_sev_es)
|
|
test_flags(KVM_X86_SEV_ES_VM);
|
|
if (have_snp)
|
|
test_flags(KVM_X86_SNP_VM);
|
|
|
|
test_features(KVM_X86_SEV_VM, 0);
|
|
if (have_sev_es)
|
|
test_features(KVM_X86_SEV_ES_VM, supported_vmsa_features);
|
|
if (have_snp)
|
|
test_features(KVM_X86_SNP_VM, supported_vmsa_features);
|
|
|
|
return 0;
|
|
}
|