mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-08-29 05:46:18 -04:00
IBS on pre-Zen6 platforms lacked a hardware privilege filter, so the kernel enabled swfilt=1. Zen6 and newer platforms provides privilege filtering via the RIP[63] bit, making swfilt redundant. Skip the perf unit test that assumes IBS has no hardware-assisted privilege filter on Zen6 and newer platforms. swfilt is ignored by kernel on platforms that support RIP[63] bit filter i.e. all amd-ibs-swfilt.sh tests will test hardware assisted privilege filter. Without the patch on Zen6: # sudo ./perf test -vv 77 77: AMD IBS software filtering: --- start --- test child forked, pid 30813 check availability of IBS swfilt run perf record with modifier and swfilt [FAIL] IBS PMU should not accept exclude_kernel ---- end(-1) ---- 77: AMD IBS software filtering : FAILED! With the patch: # ./perf test -vv 77 77: AMD IBS software filtering: --- start --- test child forked, pid 30903 check availability of IBS swfilt run perf record with modifier and swfilt [ perf record: Woken up 2 times to write data ] [ perf record: Captured and wrote 0.000 MB /dev/null ] [ perf record: Woken up 3 times to write data ] [ perf record: Captured and wrote 0.000 MB /dev/null ] [ perf record: Woken up 3 times to write data ] [ perf record: Captured and wrote 0.000 MB /dev/null ] [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.000 MB /dev/null ] check number of samples with swfilt [ perf record: Woken up 4 times to write data ] [ perf record: Captured and wrote 0.051 MB - ] [ perf record: Woken up 4 times to write data ] [ perf record: Captured and wrote 0.063 MB - ] ---- end(0) ---- 77: AMD IBS software filtering : Ok Signed-off-by: Ravi Bangoria <ravi.bangoria@amd.com> Acked-by: Namhyung Kim <namhyung@kernel.org> Cc: Ananth Narayan <ananth.narayan@amd.com> Cc: Dapeng Mi <dapeng1.mi@linux.intel.com> Cc: Ian Rogers <irogers@google.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: James Clark <james.clark@linaro.org> Cc: Manali Shukla <manali.shukla@amd.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Sandipan Das <sandipan.das@amd.com> Cc: Santosh Shukla <santosh.shukla@amd.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
122 lines
3.2 KiB
Bash
Executable File
122 lines
3.2 KiB
Bash
Executable File
#!/bin/bash
|
|
# AMD IBS software filtering
|
|
|
|
cpu_family() {
|
|
grep -m1 '^cpu family[[:space:]]*:' /proc/cpuinfo \
|
|
| awk -F: '{gsub(/^[ \t]+/, "", $2); print $2}'
|
|
}
|
|
|
|
cpu_model() {
|
|
grep -m1 '^model[[:space:]]*:' /proc/cpuinfo \
|
|
| awk -F: '{gsub(/^[ \t]+/, "", $2); print $2}'
|
|
}
|
|
|
|
# IBS PMUs does not advertize privilege filtering capability. Rely
|
|
# on Family / Model check.
|
|
hw_priv_filter_supported() {
|
|
family=$(cpu_family)
|
|
model=$(cpu_model)
|
|
|
|
if (( family > 0x1a )) ||
|
|
{ (( family == 0x1a )) &&
|
|
{ { (( model >= 0x50 && model <= 0x5f )) ||
|
|
(( model >= 0x80 && model <= 0xaf )) ||
|
|
(( model >= 0xc0 && model <= 0xcf )); }; }; }; then
|
|
return 0 # True
|
|
else
|
|
return 1 # False
|
|
fi
|
|
}
|
|
|
|
ParanoidAndNotRoot() {
|
|
[ "$(id -u)" != 0 ] && [ "$(cat /proc/sys/kernel/perf_event_paranoid)" -gt $1 ]
|
|
}
|
|
|
|
echo "check availability of IBS swfilt"
|
|
|
|
# check if IBS PMU is available
|
|
if [ ! -d /sys/bus/event_source/devices/ibs_op ]; then
|
|
echo "[SKIP] IBS PMU does not exist"
|
|
exit 2
|
|
fi
|
|
|
|
# check if IBS PMU has swfilt format
|
|
if [ ! -f /sys/bus/event_source/devices/ibs_op/format/swfilt ]; then
|
|
echo "[SKIP] IBS PMU does not have swfilt"
|
|
exit 2
|
|
fi
|
|
|
|
echo "run perf record with modifier and swfilt"
|
|
err=0
|
|
|
|
# setting any modifiers should fail
|
|
if ! hw_priv_filter_supported; then
|
|
perf record -B -e ibs_op//u -o /dev/null true 2> /dev/null
|
|
if [ $? -eq 0 ]; then
|
|
echo "[FAIL] IBS PMU should not accept exclude_kernel"
|
|
exit 1
|
|
fi
|
|
fi
|
|
|
|
# setting it with swfilt should be fine
|
|
perf record -B -e ibs_op/swfilt/u -o /dev/null true
|
|
if [ $? -ne 0 ]; then
|
|
echo "[FAIL] IBS op PMU cannot handle swfilt for exclude_kernel"
|
|
exit 1
|
|
fi
|
|
|
|
if ! ParanoidAndNotRoot 1
|
|
then
|
|
# setting it with swfilt=1 should be fine
|
|
perf record -B -e ibs_op/swfilt=1/k -o /dev/null true
|
|
if [ $? -ne 0 ]; then
|
|
echo "[FAIL] IBS op PMU cannot handle swfilt for exclude_user"
|
|
exit 1
|
|
fi
|
|
else
|
|
echo "[SKIP] not root and perf_event_paranoid too high for exclude_user"
|
|
err=2
|
|
fi
|
|
|
|
# check ibs_fetch PMU as well
|
|
perf record -B -e ibs_fetch/swfilt/u -o /dev/null true
|
|
if [ $? -ne 0 ]; then
|
|
echo "[FAIL] IBS fetch PMU cannot handle swfilt for exclude_kernel"
|
|
exit 1
|
|
fi
|
|
|
|
# check system wide recording
|
|
if ! ParanoidAndNotRoot 0
|
|
then
|
|
perf record -aB --synth=no -e ibs_op/swfilt/k -o /dev/null true
|
|
if [ $? -ne 0 ]; then
|
|
echo "[FAIL] IBS op PMU cannot handle swfilt in system-wide mode"
|
|
exit 1
|
|
fi
|
|
else
|
|
echo "[SKIP] not root and perf_event_paranoid too high for system-wide/exclude_user"
|
|
err=2
|
|
fi
|
|
|
|
echo "check number of samples with swfilt"
|
|
|
|
kernel_sample=$(perf record -e ibs_op/swfilt/u -o- true | perf script -i- -F misc | grep -c ^K)
|
|
if [ ${kernel_sample} -ne 0 ]; then
|
|
echo "[FAIL] unexpected kernel samples: " ${kernel_sample}
|
|
exit 1
|
|
fi
|
|
|
|
if ! ParanoidAndNotRoot 1
|
|
then
|
|
user_sample=$(perf record -e ibs_fetch/swfilt/k -o- true | perf script -i- -F misc | grep -c ^U)
|
|
if [ ${user_sample} -ne 0 ]; then
|
|
echo "[FAIL] unexpected user samples: " ${user_sample}
|
|
exit 1
|
|
fi
|
|
else
|
|
echo "[SKIP] not root and perf_event_paranoid too high for exclude_user"
|
|
err=2
|
|
fi
|
|
|
|
exit $err
|