mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-08-28 20:24:02 -04:00
8d5806c600
net_shaper_parse_handle() reads the user-supplied handle ID via
nla_get_u32(), accepting the full u32 range. However, the xarray key
is built by net_shaper_handle_to_index() using
FIELD_PREP(NET_SHAPER_ID_MASK, handle->id), where NET_SHAPER_ID_MASK
is GENMASK(25, 0) - only 26 bits wide. FIELD_PREP silently masks off
the upper bits at runtime. A user-supplied NODE id like 0x04000123
becomes id 0x123.
Additionally, a user-supplied id equal to NET_SHAPER_ID_UNSPEC
(0x03FFFFFF, which is NET_SHAPER_ID_MASK itself) would collide with
the sentinel used internally by the group operation to signal
"allocate a new NODE id".
Reject user-supplied IDs >= NET_SHAPER_ID_MASK (i.e., >= 0x03FFFFFF)
in the policy.
Fixes: 4b623f9f0f ("net-shapers: implement NL get operation")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Link: https://patch.msgid.link/20260510192904.3987113-9-kuba@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
161 lines
5.6 KiB
C
161 lines
5.6 KiB
C
// SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause)
|
|
/* Do not edit directly, auto-generated from: */
|
|
/* Documentation/netlink/specs/net_shaper.yaml */
|
|
/* YNL-GEN kernel source */
|
|
/* To regenerate run: tools/net/ynl/ynl-regen.sh */
|
|
|
|
#include <net/netlink.h>
|
|
#include <net/genetlink.h>
|
|
|
|
#include "shaper_nl_gen.h"
|
|
|
|
#include <uapi/linux/net_shaper.h>
|
|
|
|
/* Integer value ranges */
|
|
static const struct netlink_range_validation net_shaper_a_handle_id_range = {
|
|
.max = NET_SHAPER_MAX_HANDLE_ID,
|
|
};
|
|
|
|
/* Common nested types */
|
|
const struct nla_policy net_shaper_handle_nl_policy[NET_SHAPER_A_HANDLE_ID + 1] = {
|
|
[NET_SHAPER_A_HANDLE_SCOPE] = NLA_POLICY_MAX(NLA_U32, 3),
|
|
[NET_SHAPER_A_HANDLE_ID] = NLA_POLICY_FULL_RANGE(NLA_U32, &net_shaper_a_handle_id_range),
|
|
};
|
|
|
|
const struct nla_policy net_shaper_leaf_info_nl_policy[NET_SHAPER_A_WEIGHT + 1] = {
|
|
[NET_SHAPER_A_HANDLE] = NLA_POLICY_NESTED(net_shaper_handle_nl_policy),
|
|
[NET_SHAPER_A_PRIORITY] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_WEIGHT] = { .type = NLA_U32, },
|
|
};
|
|
|
|
/* NET_SHAPER_CMD_GET - do */
|
|
static const struct nla_policy net_shaper_get_do_nl_policy[NET_SHAPER_A_IFINDEX + 1] = {
|
|
[NET_SHAPER_A_IFINDEX] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_HANDLE] = NLA_POLICY_NESTED(net_shaper_handle_nl_policy),
|
|
};
|
|
|
|
/* NET_SHAPER_CMD_GET - dump */
|
|
static const struct nla_policy net_shaper_get_dump_nl_policy[NET_SHAPER_A_IFINDEX + 1] = {
|
|
[NET_SHAPER_A_IFINDEX] = { .type = NLA_U32, },
|
|
};
|
|
|
|
/* NET_SHAPER_CMD_SET - do */
|
|
static const struct nla_policy net_shaper_set_nl_policy[NET_SHAPER_A_IFINDEX + 1] = {
|
|
[NET_SHAPER_A_IFINDEX] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_HANDLE] = NLA_POLICY_NESTED(net_shaper_handle_nl_policy),
|
|
[NET_SHAPER_A_METRIC] = NLA_POLICY_MAX(NLA_U32, 1),
|
|
[NET_SHAPER_A_BW_MIN] = { .type = NLA_UINT, },
|
|
[NET_SHAPER_A_BW_MAX] = { .type = NLA_UINT, },
|
|
[NET_SHAPER_A_BURST] = { .type = NLA_UINT, },
|
|
[NET_SHAPER_A_PRIORITY] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_WEIGHT] = { .type = NLA_U32, },
|
|
};
|
|
|
|
/* NET_SHAPER_CMD_DELETE - do */
|
|
static const struct nla_policy net_shaper_delete_nl_policy[NET_SHAPER_A_IFINDEX + 1] = {
|
|
[NET_SHAPER_A_IFINDEX] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_HANDLE] = NLA_POLICY_NESTED(net_shaper_handle_nl_policy),
|
|
};
|
|
|
|
/* NET_SHAPER_CMD_GROUP - do */
|
|
static const struct nla_policy net_shaper_group_nl_policy[NET_SHAPER_A_LEAVES + 1] = {
|
|
[NET_SHAPER_A_IFINDEX] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_PARENT] = NLA_POLICY_NESTED(net_shaper_handle_nl_policy),
|
|
[NET_SHAPER_A_HANDLE] = NLA_POLICY_NESTED(net_shaper_handle_nl_policy),
|
|
[NET_SHAPER_A_METRIC] = NLA_POLICY_MAX(NLA_U32, 1),
|
|
[NET_SHAPER_A_BW_MIN] = { .type = NLA_UINT, },
|
|
[NET_SHAPER_A_BW_MAX] = { .type = NLA_UINT, },
|
|
[NET_SHAPER_A_BURST] = { .type = NLA_UINT, },
|
|
[NET_SHAPER_A_PRIORITY] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_WEIGHT] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_LEAVES] = NLA_POLICY_NESTED(net_shaper_leaf_info_nl_policy),
|
|
};
|
|
|
|
/* NET_SHAPER_CMD_CAP_GET - do */
|
|
static const struct nla_policy net_shaper_cap_get_do_nl_policy[NET_SHAPER_A_CAPS_SCOPE + 1] = {
|
|
[NET_SHAPER_A_CAPS_IFINDEX] = { .type = NLA_U32, },
|
|
[NET_SHAPER_A_CAPS_SCOPE] = NLA_POLICY_MAX(NLA_U32, 3),
|
|
};
|
|
|
|
/* NET_SHAPER_CMD_CAP_GET - dump */
|
|
static const struct nla_policy net_shaper_cap_get_dump_nl_policy[NET_SHAPER_A_CAPS_IFINDEX + 1] = {
|
|
[NET_SHAPER_A_CAPS_IFINDEX] = { .type = NLA_U32, },
|
|
};
|
|
|
|
/* Ops table for net_shaper */
|
|
static const struct genl_split_ops net_shaper_nl_ops[] = {
|
|
{
|
|
.cmd = NET_SHAPER_CMD_GET,
|
|
.pre_doit = net_shaper_nl_pre_doit,
|
|
.doit = net_shaper_nl_get_doit,
|
|
.post_doit = net_shaper_nl_post_doit,
|
|
.policy = net_shaper_get_do_nl_policy,
|
|
.maxattr = NET_SHAPER_A_IFINDEX,
|
|
.flags = GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = NET_SHAPER_CMD_GET,
|
|
.start = net_shaper_nl_pre_dumpit,
|
|
.dumpit = net_shaper_nl_get_dumpit,
|
|
.done = net_shaper_nl_post_dumpit,
|
|
.policy = net_shaper_get_dump_nl_policy,
|
|
.maxattr = NET_SHAPER_A_IFINDEX,
|
|
.flags = GENL_CMD_CAP_DUMP,
|
|
},
|
|
{
|
|
.cmd = NET_SHAPER_CMD_SET,
|
|
.pre_doit = net_shaper_nl_pre_doit_write,
|
|
.doit = net_shaper_nl_set_doit,
|
|
.post_doit = net_shaper_nl_post_doit_write,
|
|
.policy = net_shaper_set_nl_policy,
|
|
.maxattr = NET_SHAPER_A_IFINDEX,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = NET_SHAPER_CMD_DELETE,
|
|
.pre_doit = net_shaper_nl_pre_doit_write,
|
|
.doit = net_shaper_nl_delete_doit,
|
|
.post_doit = net_shaper_nl_post_doit_write,
|
|
.policy = net_shaper_delete_nl_policy,
|
|
.maxattr = NET_SHAPER_A_IFINDEX,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = NET_SHAPER_CMD_GROUP,
|
|
.pre_doit = net_shaper_nl_pre_doit_write,
|
|
.doit = net_shaper_nl_group_doit,
|
|
.post_doit = net_shaper_nl_post_doit_write,
|
|
.policy = net_shaper_group_nl_policy,
|
|
.maxattr = NET_SHAPER_A_LEAVES,
|
|
.flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = NET_SHAPER_CMD_CAP_GET,
|
|
.pre_doit = net_shaper_nl_cap_pre_doit,
|
|
.doit = net_shaper_nl_cap_get_doit,
|
|
.post_doit = net_shaper_nl_cap_post_doit,
|
|
.policy = net_shaper_cap_get_do_nl_policy,
|
|
.maxattr = NET_SHAPER_A_CAPS_SCOPE,
|
|
.flags = GENL_CMD_CAP_DO,
|
|
},
|
|
{
|
|
.cmd = NET_SHAPER_CMD_CAP_GET,
|
|
.start = net_shaper_nl_cap_pre_dumpit,
|
|
.dumpit = net_shaper_nl_cap_get_dumpit,
|
|
.done = net_shaper_nl_cap_post_dumpit,
|
|
.policy = net_shaper_cap_get_dump_nl_policy,
|
|
.maxattr = NET_SHAPER_A_CAPS_IFINDEX,
|
|
.flags = GENL_CMD_CAP_DUMP,
|
|
},
|
|
};
|
|
|
|
struct genl_family net_shaper_nl_family __ro_after_init = {
|
|
.name = NET_SHAPER_FAMILY_NAME,
|
|
.version = NET_SHAPER_FAMILY_VERSION,
|
|
.netnsok = true,
|
|
.parallel_ops = true,
|
|
.module = THIS_MODULE,
|
|
.split_ops = net_shaper_nl_ops,
|
|
.n_split_ops = ARRAY_SIZE(net_shaper_nl_ops),
|
|
};
|