mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-08-30 06:29:06 -04:00
4a9e6a9230
While being less compact, using named initializers allows to more easily see which members of the structs are assigned which value without having to lookup the declaration of the struct. And it's also more robust against changes to the struct definition. The mentioned robustness is relevant for a planned change to struct i2c_device_id that replaces .driver_data by an anonymous union. While touching all these arrays, unify indention and usage of commas. This patch doesn't modify the compiled arrays, only their representation in source form benefits. The former was confirmed with x86 and arm64 builds. Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com> Link: https://lore.kernel.org/r/65b77bcd452752c36d866069cc5790b26d2bf8dc.1778688803.git.u.kleine-koenig@baylibre.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
115 lines
2.7 KiB
C
115 lines
2.7 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Hardware monitoring driver for Maxim MAX16064
|
|
*
|
|
* Copyright (c) 2011 Ericsson AB.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/init.h>
|
|
#include <linux/err.h>
|
|
#include <linux/i2c.h>
|
|
#include "pmbus.h"
|
|
|
|
#define MAX16064_MFR_VOUT_PEAK 0xd4
|
|
#define MAX16064_MFR_TEMPERATURE_PEAK 0xd6
|
|
|
|
static int max16064_read_word_data(struct i2c_client *client, int page,
|
|
int phase, int reg)
|
|
{
|
|
int ret;
|
|
|
|
switch (reg) {
|
|
case PMBUS_VIRT_READ_VOUT_MAX:
|
|
ret = pmbus_read_word_data(client, page, phase,
|
|
MAX16064_MFR_VOUT_PEAK);
|
|
break;
|
|
case PMBUS_VIRT_READ_TEMP_MAX:
|
|
ret = pmbus_read_word_data(client, page, phase,
|
|
MAX16064_MFR_TEMPERATURE_PEAK);
|
|
break;
|
|
case PMBUS_VIRT_RESET_VOUT_HISTORY:
|
|
case PMBUS_VIRT_RESET_TEMP_HISTORY:
|
|
ret = 0;
|
|
break;
|
|
default:
|
|
ret = -ENODATA;
|
|
break;
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
static int max16064_write_word_data(struct i2c_client *client, int page,
|
|
int reg, u16 word)
|
|
{
|
|
int ret;
|
|
|
|
switch (reg) {
|
|
case PMBUS_VIRT_RESET_VOUT_HISTORY:
|
|
ret = pmbus_write_word_data(client, page,
|
|
MAX16064_MFR_VOUT_PEAK, 0);
|
|
break;
|
|
case PMBUS_VIRT_RESET_TEMP_HISTORY:
|
|
ret = pmbus_write_word_data(client, page,
|
|
MAX16064_MFR_TEMPERATURE_PEAK,
|
|
0xffff);
|
|
break;
|
|
default:
|
|
ret = -ENODATA;
|
|
break;
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
static struct pmbus_driver_info max16064_info = {
|
|
.pages = 4,
|
|
.format[PSC_VOLTAGE_IN] = direct,
|
|
.format[PSC_VOLTAGE_OUT] = direct,
|
|
.format[PSC_TEMPERATURE] = direct,
|
|
.m[PSC_VOLTAGE_IN] = 19995,
|
|
.b[PSC_VOLTAGE_IN] = 0,
|
|
.R[PSC_VOLTAGE_IN] = -1,
|
|
.m[PSC_VOLTAGE_OUT] = 19995,
|
|
.b[PSC_VOLTAGE_OUT] = 0,
|
|
.R[PSC_VOLTAGE_OUT] = -1,
|
|
.m[PSC_TEMPERATURE] = -7612,
|
|
.b[PSC_TEMPERATURE] = 335,
|
|
.R[PSC_TEMPERATURE] = -3,
|
|
.func[0] = PMBUS_HAVE_VOUT | PMBUS_HAVE_TEMP
|
|
| PMBUS_HAVE_STATUS_VOUT | PMBUS_HAVE_STATUS_TEMP,
|
|
.func[1] = PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT,
|
|
.func[2] = PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT,
|
|
.func[3] = PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT,
|
|
.read_word_data = max16064_read_word_data,
|
|
.write_word_data = max16064_write_word_data,
|
|
};
|
|
|
|
static int max16064_probe(struct i2c_client *client)
|
|
{
|
|
return pmbus_do_probe(client, &max16064_info);
|
|
}
|
|
|
|
static const struct i2c_device_id max16064_id[] = {
|
|
{ .name = "max16064" },
|
|
{ }
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(i2c, max16064_id);
|
|
|
|
/* This is the driver that will be inserted */
|
|
static struct i2c_driver max16064_driver = {
|
|
.driver = {
|
|
.name = "max16064",
|
|
},
|
|
.probe = max16064_probe,
|
|
.id_table = max16064_id,
|
|
};
|
|
|
|
module_i2c_driver(max16064_driver);
|
|
|
|
MODULE_AUTHOR("Guenter Roeck");
|
|
MODULE_DESCRIPTION("PMBus driver for Maxim MAX16064");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_IMPORT_NS("PMBUS");
|