mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-08-28 19:14:35 -04:00
5164f7e7ff
The KMS framework uses two slightly different definitions for the state concept. For a given object (plane, CRTC, encoder, etc., so drm_$OBJECT_state), the state is the entire state of that object. However, at the device level, drm_atomic_state refers to a state update for a limited number of objects. Thus, drm_atomic_state isn't the entire device state, but only the full state of some objects in that device. This has been an endless source of confusion and thus bugs. We can rename the drm_atomic_state structure to drm_atomic_commit to make it less confusing. This patch was created using: rg -l drm_atomic_state | \ xargs sed -i 's/drm_atomic_state/drm_atomic_commit/g; s/drm_atomic_commit_helper/drm_atomic_state_helper/g' mv drivers/gpu/drm/tests/drm_atomic_state_test.c drivers/gpu/drm/tests/drm_atomic_commit_test.c Acked-by: Simona Vetter <simona.vetter@ffwll.ch> Acked-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Jani Nikula <jani.nikula@intel.com> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Tested-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Signed-off-by: Maxime Ripard <mripard@kernel.org> Signed-off-by: Dave Airlie <airlied@redhat.com> Link: https://patch.msgid.link/20260427-drm-drm-atomic-update-v4-1-c0e713bfdf25@kernel.org
116 lines
3.0 KiB
C
116 lines
3.0 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright 2024 Freebox SAS
|
|
*/
|
|
|
|
#include <linux/gpio/consumer.h>
|
|
#include <linux/i2c.h>
|
|
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_bridge.h>
|
|
|
|
struct tdp158 {
|
|
struct drm_bridge bridge;
|
|
struct drm_bridge *next;
|
|
struct gpio_desc *enable; // Operation Enable - pin 36
|
|
struct regulator *vcc; // 3.3V
|
|
struct regulator *vdd; // 1.1V
|
|
struct device *dev;
|
|
};
|
|
|
|
static void tdp158_enable(struct drm_bridge *bridge,
|
|
struct drm_atomic_commit *state)
|
|
{
|
|
int err;
|
|
struct tdp158 *tdp158 = bridge->driver_private;
|
|
|
|
err = regulator_enable(tdp158->vcc);
|
|
if (err)
|
|
dev_err(tdp158->dev, "failed to enable vcc: %d", err);
|
|
|
|
err = regulator_enable(tdp158->vdd);
|
|
if (err)
|
|
dev_err(tdp158->dev, "failed to enable vdd: %d", err);
|
|
|
|
gpiod_set_value_cansleep(tdp158->enable, 1);
|
|
}
|
|
|
|
static void tdp158_disable(struct drm_bridge *bridge,
|
|
struct drm_atomic_commit *state)
|
|
{
|
|
struct tdp158 *tdp158 = bridge->driver_private;
|
|
|
|
gpiod_set_value_cansleep(tdp158->enable, 0);
|
|
regulator_disable(tdp158->vdd);
|
|
regulator_disable(tdp158->vcc);
|
|
}
|
|
|
|
static int tdp158_attach(struct drm_bridge *bridge,
|
|
struct drm_encoder *encoder,
|
|
enum drm_bridge_attach_flags flags)
|
|
{
|
|
struct tdp158 *tdp158 = bridge->driver_private;
|
|
|
|
return drm_bridge_attach(encoder, tdp158->next, bridge, flags);
|
|
}
|
|
|
|
static const struct drm_bridge_funcs tdp158_bridge_funcs = {
|
|
.attach = tdp158_attach,
|
|
.atomic_enable = tdp158_enable,
|
|
.atomic_disable = tdp158_disable,
|
|
.atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
|
|
.atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
|
|
.atomic_reset = drm_atomic_helper_bridge_reset,
|
|
};
|
|
|
|
static int tdp158_probe(struct i2c_client *client)
|
|
{
|
|
struct tdp158 *tdp158;
|
|
struct device *dev = &client->dev;
|
|
|
|
tdp158 = devm_drm_bridge_alloc(dev, struct tdp158, bridge,
|
|
&tdp158_bridge_funcs);
|
|
if (IS_ERR(tdp158))
|
|
return PTR_ERR(tdp158);
|
|
|
|
tdp158->next = devm_drm_of_get_bridge(dev, dev->of_node, 1, 0);
|
|
if (IS_ERR(tdp158->next))
|
|
return dev_err_probe(dev, PTR_ERR(tdp158->next), "missing bridge");
|
|
|
|
tdp158->vcc = devm_regulator_get(dev, "vcc");
|
|
if (IS_ERR(tdp158->vcc))
|
|
return dev_err_probe(dev, PTR_ERR(tdp158->vcc), "vcc");
|
|
|
|
tdp158->vdd = devm_regulator_get(dev, "vdd");
|
|
if (IS_ERR(tdp158->vdd))
|
|
return dev_err_probe(dev, PTR_ERR(tdp158->vdd), "vdd");
|
|
|
|
tdp158->enable = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW);
|
|
if (IS_ERR(tdp158->enable))
|
|
return dev_err_probe(dev, PTR_ERR(tdp158->enable), "enable");
|
|
|
|
tdp158->bridge.of_node = dev->of_node;
|
|
tdp158->bridge.driver_private = tdp158;
|
|
tdp158->dev = dev;
|
|
|
|
return devm_drm_bridge_add(dev, &tdp158->bridge);
|
|
}
|
|
|
|
static const struct of_device_id tdp158_match_table[] = {
|
|
{ .compatible = "ti,tdp158" },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, tdp158_match_table);
|
|
|
|
static struct i2c_driver tdp158_driver = {
|
|
.probe = tdp158_probe,
|
|
.driver = {
|
|
.name = "tdp158",
|
|
.of_match_table = tdp158_match_table,
|
|
},
|
|
};
|
|
module_i2c_driver(tdp158_driver);
|
|
|
|
MODULE_DESCRIPTION("TI TDP158 driver");
|
|
MODULE_LICENSE("GPL");
|