mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
synced 2026-04-08 19:56:24 -04:00
114339ee4d
When someone has a global shellcheckrc file, for example at
~/.config/shellcheckrc, with the directive 'shell=sh', building perf
will fail with many shellcheck errors like:
In tests/shell/base_probe/test_adding_kernel.sh line 294:
(( TEST_RESULT += $? ))
^---------------------^ SC3006 (warning): In POSIX sh, standalone ((..)) is undefined.
For more information:
https://www.shellcheck.net/wiki/SC3006 -- In POSIX sh, standalone ((..)) is...
make[5]: *** [tests/Build:91: tests/shell/base_probe/test_adding_kernel.sh.shellcheck_log] Error 1
Passing the '-s bash' option ensures that it runs correctly regardless
of a developers global configuration.
This patch adds '-s bash' and other options to the SHELLCHECK variable
in Makefile.perf and makes use of the variable consistently.
Signed-off-by: Collin Funk <collin.funk1@gmail.com>
Link: https://lore.kernel.org/r/63491dbc8439edf2e949d80e264b9d22332fea61.1751082075.git.collin.funk1@gmail.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
37 lines
805 B
Plaintext
37 lines
805 B
Plaintext
perf-y += clone.o
|
|
perf-y += fcntl.o
|
|
perf-y += flock.o
|
|
perf-y += fs_at_flags.o
|
|
perf-y += fsmount.o
|
|
perf-y += fspick.o
|
|
ifeq ($(SRCARCH),$(filter $(SRCARCH),x86))
|
|
perf-y += ioctl.o
|
|
endif
|
|
perf-y += kcmp.o
|
|
perf-y += mount_flags.o
|
|
perf-y += move_mount.o
|
|
perf-y += pkey_alloc.o
|
|
perf-y += arch_prctl.o
|
|
perf-y += prctl.o
|
|
perf-y += renameat.o
|
|
perf-y += sockaddr.o
|
|
perf-y += socket.o
|
|
perf-y += statx.o
|
|
perf-y += sync_file_range.o
|
|
perf-y += timespec.o
|
|
perf-y += tracepoints/
|
|
|
|
ifdef SHELLCHECK
|
|
SHELL_TESTS := $(wildcard trace/beauty/*.sh)
|
|
SHELL_TEST_LOGS := $(SHELL_TESTS:trace/beauty/%=%.shellcheck_log)
|
|
else
|
|
SHELL_TESTS :=
|
|
SHELL_TEST_LOGS :=
|
|
endif
|
|
|
|
$(OUTPUT)%.shellcheck_log: %
|
|
$(call rule_mkdir)
|
|
$(Q)$(call echo-cmd,test)$(SHELLCHECK) "$<" > $@ || (cat $@ && rm $@ && false)
|
|
|
|
perf-y += $(SHELL_TEST_LOGS)
|