Thomas Zimmermann 171b357d18
drm/ast: Only set VGA SCREEN_DISABLE bit in CRTC code ...
The SCREEN_DISABLE bit controls scanout from display memory. The bit
affects all planes, so set it only in the CRTC's atomic enable and
disable functions.
A number of bugs affect this fix. First of all, ast_set_std_regs()
tries to set VGASR1 except for the SD bit. But the read bitmask is
invert, so it preserves anything except the SD bit. Fix this by
re-inverting the read mask.
The second issue is that primary-plane and CRTC helpers modify the
SD bit. The bit controls scanout for all planes, primary and HW
cursor, so set it only in the CRTC code.
Further add a constant to represent the SD bit in VGASR1. Keep the
plane's atomic_disable around to make the DRM framework happy.
v2:
- fix typos in commit message
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de >
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com >
Link: https://patchwork.freedesktop.org/patch/msgid/20240627153638.8765-7-tzimmermann@suse.de
2024-07-03 09:38:23 +02:00
2024-06-14 09:15:28 +02:00
2024-05-24 08:43:25 -07:00
2024-05-22 12:26:46 -07:00
2024-05-04 18:59:47 +02:00
2024-05-21 10:09:28 -07:00
2024-05-06 18:26:47 -07:00
2024-05-22 10:45:12 -07:00
2024-05-23 13:38:31 -07:00
2024-05-23 13:44:47 -07:00
2024-05-23 12:04:36 -07:00
2024-05-22 20:14:47 -04:00
2024-05-15 12:59:55 -06:00
2024-05-25 14:32:29 -07:00
2024-05-18 12:48:37 -07:00
2024-05-22 09:56:00 -07:00
2024-05-21 11:40:49 -07:00
2024-05-16 08:50:32 -07:00
2024-05-23 12:04:36 -07:00
2024-05-22 20:14:47 -04:00
2024-05-19 09:21:03 -07:00
2024-05-09 00:30:37 +09:00
2024-05-21 11:15:56 -07:00
2024-06-19 20:05:34 +05:30
2024-05-13 16:53:53 -07:00
2024-05-14 08:31:10 -07:00
2024-05-03 22:09:50 +02:00
2024-05-09 01:03:39 +09:00
2024-05-14 18:57:22 -07:00
2024-05-23 12:04:36 -07:00
2024-05-22 12:26:46 -07:00
2024-05-23 12:04:36 -07:00
2024-07-03 09:38:23 +02:00
2024-05-04 18:59:41 +02:00
2024-05-22 10:45:12 -07:00
2024-05-22 12:26:46 -07:00
2024-05-22 12:13:40 -07:00
2024-05-22 12:26:46 -07:00
2024-05-20 08:55:18 -07:00
2024-05-23 00:29:19 +02:00
2024-05-22 12:26:46 -07:00
2024-05-22 20:14:47 -04:00
2024-05-24 09:01:21 -07:00
2024-05-22 20:14:47 -04:00
2024-05-23 12:28:01 -07:00
2024-05-23 04:48:40 -07:00
2024-05-02 18:12:27 +01:00
2024-05-17 09:05:46 -07:00
2024-05-19 22:33:28 -05:00
2024-05-21 11:43:11 -07:00
2024-05-22 20:14:47 -04:00
2024-05-17 08:53:47 -07:00
2024-05-14 18:25:53 -07:00
2024-05-21 10:09:28 -07:00
2024-05-23 12:28:01 -07:00
2024-05-16 08:56:49 -07:00
2024-05-21 09:51:42 -07:00
2024-05-23 12:49:37 -07:00
2024-05-23 12:04:36 -07:00
2024-05-14 09:14:49 -06:00
2024-05-03 07:26:39 +02:00
2024-05-20 08:55:18 -07:00
2024-05-17 13:01:24 +02:00
2024-05-21 10:09:28 -07:00
2024-05-23 12:09:22 -07:00
2024-05-21 11:19:18 -07:00
2024-05-22 10:41:14 -07:00
2024-05-22 12:13:40 -07:00
2024-05-21 11:40:49 -07:00
2024-05-20 08:55:18 -07:00
2024-04-30 21:10:37 +02:00
2024-05-14 19:42:24 -07:00
2024-05-10 07:30:27 +02:00
2024-05-14 23:36:19 +09:00
2024-05-23 13:39:42 -07:00
2024-05-06 13:34:12 -06:00
2024-05-18 12:48:37 -07:00
2024-05-23 12:04:36 -07:00
2024-05-07 23:40:46 +02:00
2024-05-21 12:09:36 -07:00
2024-05-23 12:04:36 -07:00
2024-05-08 19:21:51 +01:00
2024-05-22 20:14:47 -04:00
2024-05-21 11:23:36 -07:00
2024-05-14 14:41:01 -07:00
2024-05-08 19:46:11 +01:00
2024-05-22 12:11:48 -07:00
2024-05-21 13:11:44 -07:00
2024-05-22 20:14:47 -04:00
2024-05-10 10:25:22 +01:00
2024-05-24 08:38:28 -07:00
2024-05-14 18:25:53 -07:00
2024-05-22 20:14:47 -04:00
2024-05-22 08:32:48 -04:00
2024-05-20 14:56:50 -07:00
2024-05-23 12:04:36 -07:00
2024-06-24 13:24:02 +02:00
2024-05-19 09:21:03 -07:00
2024-05-23 12:04:36 -07:00
2024-05-11 11:32:06 +02:00
2024-05-24 10:24:49 -07:00
2024-05-10 04:34:52 +09:00
171b357d18