Zhihao Cheng 122deabfe1 ubifs: dirty_cow_znode: Fix memleak in error handling path ...

Following process will cause a memleak for copied up znode:

dirty_cow_znode
  zn = copy_znode(c, znode);
  err = insert_old_idx(c, zbr->lnum, zbr->offs);
  if (unlikely(err))
     return ERR_PTR(err);   // No one refers to zn.

Fix it by adding copied znode back to tnc, then it will be freed
by ubifs_destroy_tnc_subtree() while closing tnc.

Fetch a reproducer in [Link].

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216705
Fixes: 1e51764a3c ("UBIFS: add new flash file system")
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>

2023-02-02 21:13:47 +01:00

..

auth.c

ubifs: Fix memleak in ubifs_init_authentication

2021-02-12 21:53:22 +01:00

budget.c

ubifs: Reserve one leb for each journal head while doing budget

2023-02-02 21:13:40 +01:00

commit.c

ubifs: Pass node length in all node dumping callers

2020-12-13 22:12:32 +01:00

compress.c

ubifs: Add support for zstd compression.

2019-07-08 19:43:53 +02:00

crypto.c

ubifs: Fix UBIFS ro fail due to truncate in the encrypted directory

2022-09-21 11:32:38 +02:00

debug.c

treewide: use get_random_u32_below() instead of deprecated function

2022-11-18 02:15:15 +01:00

debug.h

ubifs: ubifs_dump_sleb: Remove unused function

2020-12-13 22:12:38 +01:00

dir.c

ubifs: do_rename: Fix wrong space budget when target inode's nlink > 1

2023-02-02 21:13:40 +01:00

file.c

ubifs: Convert to filemap_migrate_folio()

2022-08-02 12:34:04 -04:00

find.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336

2019-06-05 17:37:07 +02:00

gc.c

ubifs: read-only if LEB may always be taken in ubifs_garbage_collect

2021-12-23 22:30:38 +01:00

io.c

ubifs: Fix read out-of-bounds in ubifs_wbuf_write_nolock()

2022-01-10 22:58:27 +01:00

ioctl.c

ubifs: setflags: Make dirtied_ino_d 8 bytes aligned

2022-01-10 22:18:42 +01:00

journal.c

Merge tag 'random-6.1-rc1-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/crng/random

2022-10-16 15:27:07 -07:00

Kconfig

fscrypt: Allow modular crypto algorithms

2019-12-31 10:33:51 -06:00

key.h

ubifs: allow both hash and disk name to be provided in no-key names

2020-01-22 14:49:56 -08:00

log.c

ubifs: remove unnecessary check in ubifs_log_start_commit

2019-07-08 19:43:51 +02:00

lprops.c

treewide: Use fallthrough pseudo-keyword

2020-08-23 17:36:59 -05:00

lpt_commit.c

treewide: use get_random_u32_below() instead of deprecated function

2022-11-18 02:15:15 +01:00

lpt.c

ubifs: Fix the printing type of c->big_lpt

2020-12-13 21:57:10 +01:00

Makefile

ubifs: Export filesystem error counters

2021-12-23 20:23:42 +01:00

master.c

ubifs: Fix spelling mistakes

2021-06-22 09:21:39 +02:00

misc.c

ubifs: Allow setting assert action as mount parameter

2018-08-15 00:25:21 +02:00

misc.h

ubifs: misc.h: delete a duplicated word

2020-08-02 22:59:03 +02:00

orphan.c

ubifs: Pass node length in all node dumping callers

2020-12-13 22:12:32 +01:00

recovery.c

ubifs: Pass node length in all node dumping callers

2020-12-13 22:12:32 +01:00

replay.c

ubifs: Fix spelling mistakes

2021-12-23 20:23:40 +01:00

sb.c

ubifs: Default to zstd compression

2021-04-15 22:00:26 +02:00

scan.c

ubifs: Pass node length in all node dumping callers

2020-12-13 22:12:32 +01:00

shrinker.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 336

2019-06-05 17:37:07 +02:00

super.c

ubifs: Fix memory leak in alloc_wbufs()

2023-02-02 21:13:43 +01:00

sysfs.c

ubifs: Fix memory leak in ubifs_sysfs_init()

2023-02-02 21:13:35 +01:00

tnc_commit.c

treewide: use get_random_u32_below() instead of deprecated function

2022-11-18 02:15:15 +01:00

tnc_misc.c

ubifs: Pass node length in all node dumping callers

2020-12-13 22:12:32 +01:00

tnc.c

ubifs: dirty_cow_znode: Fix memleak in error handling path

2023-02-02 21:13:47 +01:00

ubifs-media.h

ubifs: Add support for zstd compression.

2019-07-08 19:43:53 +02:00

ubifs.h

ubifs: Fix build errors as symbol undefined

2023-02-02 21:13:34 +01:00

xattr.c

ubifs: Fix AA deadlock when setting xattr for encrypted file

2022-09-21 11:32:58 +02:00